Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp808355imm;
        Fri, 5 Oct 2018 12:08:30 -0700 (PDT)
X-Google-Smtp-Source: ACcGV61tCD2XhxIfPmic7fT2MwF4nCCube3wAxE/R/X3dbEOQff0TSADB+YVQ6Ore/odw3Pvhqyz
X-Received: by 2002:a17:902:f096:: with SMTP id go22mr13077645plb.235.1538766510895;
        Fri, 05 Oct 2018 12:08:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538766510; cv=none;
        d=google.com; s=arc-20160816;
        b=Acr8fvq7sLDiPU8/Da7IxxOI1R9cKn+05FTONWRwFjm9b/QrQvgVA9HGLkQJt4t/Vu
         ixbh4fW91lyBqfG5YQgv9eKjNU3dAXBVtayzf+Muo7j5muwRY6yOqLZuSAFBXpLHg2T8
         zSQ4TJD2cBXmOb69rtI1+hx8qrkH0eJru8/7Y8eOgCkEgDiX8ClB3AgVHr76fJKHL7/v
         mdxL6n/NN4oQpxpehBIMoX8p7lGaoMPwYlmseAkAs4h17SpF6lAkw44E9cvWNEKDH7k9
         DqOoqq6kIRxMMyQEb6ZT3BykWU3WqQPxasT1F4QI1spyhVHHYar2v8XTYizwgPOGiq/x
         Dgqw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=cvzqVSxe8i1bgl/15NvZfNcDqKvIh/PO7fSrkyAi9M8=;
        b=D8z/r2NEy6YY6EKmuMB49kaueTgs+b+uWuShILoq6rdCR1jEzsPDGHZb+urQZ2E6Ex
         wQHw1+esiLI8vSgPDFF6sAS4xw6dDxFjUsoqe+W8XiR748pCKJ4o+e6Xglils6F7nMbQ
         A4ozZzw8oJcXiOiXZY4VF2AgTgBpNfmqB1mtjnv9ufM34g6vkbKhZDf3RH5+bt8iGN53
         bKDiZ5e42hlBWL6w8F9ZTQeiihrUXj9cBcn17AfOZHelxjrL7gVErwdB4Vr8OvZezuh/
         uw6gqBcnYN9661XtYKvtWNmhipwdnvIzewXzDRw78ERQFCvLj9n8qgbMUESq20j42PTU
         gWGg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id z11-v6si8849704pgf.66.2018.10.05.12.08.15;
        Fri, 05 Oct 2018 12:08:30 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729267AbeJFCHh (ORCPT <rfc822;hubert.jasudowicz@gmail.com>
        + 99 others); Fri, 5 Oct 2018 22:07:37 -0400
Received: from www62.your-server.de ([213.133.104.62]:41324 "EHLO
        www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728042AbeJFCHh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Oct 2018 22:07:37 -0400
Received: from [78.46.172.3] (helo=sslproxy06.your-server.de)
        by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89_1)
        (envelope-from <daniel@iogearbox.net>)
        id 1g8VRa-0008Tv-Cb; Fri, 05 Oct 2018 21:07:22 +0200
Received: from [62.203.87.61] (helo=linux.home)
        by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
        (Exim 4.89)
        (envelope-from <daniel@iogearbox.net>)
        id 1g8VRa-000Vtl-74; Fri, 05 Oct 2018 21:07:22 +0200
Subject: Re: [PATCH] bpf: fix building without CONFIG_INET
To:     Song Liu <liu.song.a23@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        John Fastabend <john.fastabend@gmail.com>,
        Martin KaFai Lau <kafai@fb.com>,
        makita.toshiaki@lab.ntt.co.jp, Lawrence Brakmo <brakmo@fb.com>,
        Andrey Ignatov <rdna@fb.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Mathieu Xhonneux <m.xhonneux@gmail.com>, dsahern@gmail.com,
        Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20181005161526.843924-1-arnd@arndb.de>
 <CAPhsuW7pg9Wp5am3Kc1t3UoAG1=EYzUeq8E2k7Pmv8yGu9JaEQ@mail.gmail.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <c4b5f1af-075a-4166-4108-81acda663970@iogearbox.net>
Date:   Fri, 5 Oct 2018 21:07:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <CAPhsuW7pg9Wp5am3Kc1t3UoAG1=EYzUeq8E2k7Pmv8yGu9JaEQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Authenticated-Sender: daniel@iogearbox.net
X-Virus-Scanned: Clear (ClamAV 0.100.1/25009/Fri Oct  5 14:48:12 2018)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/05/2018 09:02 PM, Song Liu wrote:
[...]
> BPF_CALL_x() has static already (before this patch). We should not
> need change that
> for all the BPF_CALL_?(). Joe's version looks better to me.

My preference as well, thanks!