Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp898249imm;
        Fri, 5 Oct 2018 13:51:31 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60GCTeinHgb8P4PAqQ3Xkrsyqs0j0k0HIvq69adCTiMjZccFBK0NXCDrLctotITdUjQbE1i
X-Received: by 2002:a17:902:bd85:: with SMTP id q5-v6mr12770764pls.73.1538772691549;
        Fri, 05 Oct 2018 13:51:31 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538772691; cv=none;
        d=google.com; s=arc-20160816;
        b=Wf3V4q5IODyJp1j89ilBzon0yZGy4/GGoVJWmjhBeTAb9AzJForE/dh5Leg6vcqOFE
         8Ah65wp3TcXvMMLXb5gm59/8NORSY0hUdbDzORDcKgSoX86AQbJk/xQTR6oEQRNPOzmX
         6EqdJLIyIdfTyyP0gaERKMSo3/CpKSQFZkCJDjoLyIyu6oQv/9BjXLpEkYNddlqnJIGh
         H/R08YBw1FxtfcHJFrrGWFib+7JvDBjEECvpZpGYl0SVK07g04I+wcn5nzYrmHba2ZXs
         r6c7xpry3j8y04lV4280/ojKZWIvm/xVaQKrGSYP1UIvEiQ7jrJRNVb6B+EbfWZ8ikYR
         7WHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=qU1BPzLe4IBQInyCA+nI3W3768FdHpbE62OZqv/RYGs=;
        b=V59PdkyCTIFXcIi4eWTeE45Ic0JTPQZ5C4LGjiR+zPxPGSS6xrELfUULD0ujNJBHQu
         8c8SvSNfn1/zZvYgIJlV0xJwbbFWdTRLBYSLWhbNJ9FPVmTzTxzjJuIlouHiqjjP5NfB
         mdWoGl0Aar800zQf3wsrN+M2yaADNTk0X3EiD4AZuR0Oxeg2hqOue/DFr7uTywhHNRBd
         5Ynvg2FXoBppar0cIyWHWDxpS0TXZoiBwQ/FjikJEhidwQrjOHdTAN56xFsRbQdgBp3b
         YolTI9tegw7uj7EuFng+wBlw+uEQAZ9JosZe4QwtiNVI1FyOh3jd/TeBZQtgOVtL46l+
         OLBQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=JG1za+Sn;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id e9-v6si10620313pln.265.2018.10.05.13.51.15;
        Fri, 05 Oct 2018 13:51:31 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=JG1za+Sn;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728848AbeJFDve (ORCPT <rfc822;hubert.jasudowicz@gmail.com>
        + 99 others); Fri, 5 Oct 2018 23:51:34 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:19807 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728139AbeJFDvd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Oct 2018 23:51:33 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bb7ceb90000>; Fri, 05 Oct 2018 13:51:05 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 05 Oct 2018 13:51:08 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 05 Oct 2018 13:51:08 -0700
Received: from [10.110.48.28] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 5 Oct
 2018 20:51:07 +0000
Subject: Re: [PATCH v2 2/3] mm: introduce put_user_page[s](), placeholder
 versions
From:   John Hubbard <jhubbard@nvidia.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>, <john.hubbard@gmail.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jan Kara <jack@suse.cz>, <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        Jerome Glisse <jglisse@redhat.com>,
        Christoph Hellwig <hch@infradead.org>
References: <20181005040225.14292-1-jhubbard@nvidia.com>
 <20181005040225.14292-3-jhubbard@nvidia.com>
 <20181005151726.GA20776@ziepe.ca>
 <c6f31004-3a67-880b-47bb-b560dfd85343@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <1d0f78e8-614f-293c-cf80-a2c82058b80e@nvidia.com>
Date:   Fri, 5 Oct 2018 13:51:07 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <c6f31004-3a67-880b-47bb-b560dfd85343@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1538772665; bh=qU1BPzLe4IBQInyCA+nI3W3768FdHpbE62OZqv/RYGs=;
        h=X-PGP-Universal:Subject:From:To:CC:References:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=JG1za+SnfwmKRIo4Oor3wG7iljforPPoGgC7kXXBGkuL0BhuvD5eixw4UA5p0aeeW
         aIl96RijkxzC44boUFXHX3OMxSEV98JEaCiL9dAfSTmqbv7dv8U8BSVWjwRCr+3Snh
         kbzV5/s/dhX1KkFJkgBNWYo+GAjIMhB8rSCJIuDPr/ZY+icaV4Ix47tu1ZFPIlaYZe
         sjb3Rp6PvQX8pmoJ4GNchwo3SfMjdRh61jrL/SVNp4e4SlgB6eolFqFMDf9g0tESX1
         ByYrWxjUh7Wy+I2M4hLie8fWHGTOgDr24jC9c3BiHbR9SqotJN+kuqpSoUYW6gTCMK
         TnzWOcyfEcd+w==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/5/18 12:49 PM, John Hubbard wrote:
> On 10/5/18 8:17 AM, Jason Gunthorpe wrote:
>> On Thu, Oct 04, 2018 at 09:02:24PM -0700, john.hubbard@gmail.com wrote:
>>> From: John Hubbard <jhubbard@nvidia.com>
>>>
>>> Introduces put_user_page(), which simply calls put_page().
>>> This provides a way to update all get_user_pages*() callers,
>>> so that they call put_user_page(), instead of put_page().
>>>
>>> Also introduces put_user_pages(), and a few dirty/locked variations,
>>> as a replacement for release_pages(), for the same reasons.
>>> These may be used for subsequent performance improvements,
>>> via batching of pages to be released.
>>>
>>> This prepares for eventually fixing the problem described
>>> in [1], and is following a plan listed in [2], [3], [4].
>>>
>>> [1] https://lwn.net/Articles/753027/ : "The Trouble with get_user_pages()"
>>>
>>> [2] https://lkml.kernel.org/r/20180709080554.21931-1-jhubbard@nvidia.com
>>>     Proposed steps for fixing get_user_pages() + DMA problems.
>>>
>>> [3]https://lkml.kernel.org/r/20180710082100.mkdwngdv5kkrcz6n@quack2.suse.cz
>>>     Bounce buffers (otherwise [2] is not really viable).
>>>
>>> [4] https://lkml.kernel.org/r/20181003162115.GG24030@quack2.suse.cz
>>>     Follow-up discussions.
>>>
> [...]
>>>  
>>> +/* Placeholder version, until all get_user_pages*() callers are updated. */
>>> +static inline void put_user_page(struct page *page)
>>> +{
>>> +	put_page(page);
>>> +}
>>> +
>>> +/* For get_user_pages*()-pinned pages, use these variants instead of
>>> + * release_pages():
>>> + */
>>> +static inline void put_user_pages_dirty(struct page **pages,
>>> +					unsigned long npages)
>>> +{
>>> +	while (npages) {
>>> +		set_page_dirty(pages[npages]);
>>> +		put_user_page(pages[npages]);
>>> +		--npages;
>>> +	}
>>> +}
>>
>> Shouldn't these do the !PageDirty(page) thing?
>>
> 
> Well, not yet. This is the "placeholder" patch, in which I planned to keep
> the behavior the same, while I go to all the get_user_pages call sites and change 
> put_page() and release_pages() over to use these new routines.
> 
> After the call sites are changed, then these routines will be updated to do more.
> [2], above has slightly more detail about that.
> 
> 

Also, I plan to respin again pretty soon, because someone politely pointed out offline
that even in this small patchset, I've botched the handling of the --npages loop, sigh. 
(Thanks, Ralph!)

The original form:

    while(--npages)

was correct, but now it's not so much.

thanks,
-- 
John Hubbard
NVIDIA