Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp952282imm; Fri, 5 Oct 2018 15:00:22 -0700 (PDT) X-Google-Smtp-Source: ACcGV62KA6sv0lU9vtovcIwEZ9rpiSWHVmEPE2HGgfLx8NklO+EMrKXLSCSJ+qMKRueA1H62m2b+ X-Received: by 2002:a17:902:286b:: with SMTP id e98-v6mr13381501plb.110.1538776822343; Fri, 05 Oct 2018 15:00:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538776822; cv=none; d=google.com; s=arc-20160816; b=xw2CHJ5FsQDM9dlaMUom9Jnvo83qcmqbhP9IIFpfkA6wgBJGTAg9nQlOsH/ir3L3ga MQM+6tTJTQZJNyus19wk4kWoCLYj6jKqCYdPrBuyDcagc2+pEzIliIcuf3QAQrhKz+Ai yT9c5+dfR/55OrmBduYEuFsn9AHHDD7kAZSvD1k0QAZdQ4bE1bpuDYeYhEAQS1fPyBUH nmgiLtAoNzFScGkTjPXP5WeIDRgiRMVCttSgN1ifqpPLNQYsSbFnhHM6b6fO+w1DwkfF 2tg1P7W78+X+X4jDq9ADNNj4VnrdguefjZESw/OjL2AFUynDLSjdKQB1nlWfmTFvt21r tpwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=tcwZnsvrjdcL9EMdFJflgIreX++ZQkFc2zi28u5ugEw=; b=hVCyJ+CFq4TgzyJPcGBCj36pNv4SL2iAogs339mrE/AL9/cV/ycQ305A3P28HdMhDN qe+ZCjY1zxTFhvlrzBHoax6BJWvGrdbqBJPizXgz05P2svqco5cMa9V0KnYCXpbp+X2r i97QQT9zMisW+f/zFgguKT8EusUIYRZXXyHP9M+2cEh2D1enPcHIjg+ysZbU5PKObpYU FX3cQn2NOOX0Gehizgc+MNfe2l9f7DTgeXYwwEKIFCuNCcP1z0CimhRkxdL2pUN7zzbx ZFTKVCoRt3tUbT4v2CQov3EaHeDJMsAdwBMqxzJzuaGaHlPAI1Zf8gVLZ8jkVUbLjgjN E1cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=PfA88pu1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14-v6si10670996plk.130.2018.10.05.15.00.07; Fri, 05 Oct 2018 15:00:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@micronovasrl.com header.s=dkim header.b=PfA88pu1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728718AbeJFFAi (ORCPT + 99 others); Sat, 6 Oct 2018 01:00:38 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:45194 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725859AbeJFFAh (ORCPT ); Sat, 6 Oct 2018 01:00:37 -0400 Received: from mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) by mail.micronovasrl.com (Postfix) with ESMTP id 57B17B00748 for ; Fri, 5 Oct 2018 23:59:56 +0200 (CEST) Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=micronovasrl.com; h=references:in-reply-to:x-mailer:message-id:date:date:subject :subject:to:from:from; s=dkim; t=1538776795; x=1539640796; bh=RT dTDc9aj5yU4rsjgtCJV/wCZutXTyJKHh4YN8AE/DM=; b=PfA88pu1Ubco24Rq4B YjfcW7+gNS4SfYi8Q2xN1YAVMHa1hsjytQGdXv70DoDQviZmIjOkt3cCCDPpey9j Ncor0XJ9F0dyqKJ07EYls3SPbMM0i5Ar9+/NS5uSv3SrHu1JvSz+utO0hPImu4mN 1Oi38+4mfOzUDVVVJXK41XX1g= X-Virus-Scanned: Debian amavisd-new at mail.micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 X-Spam-Level: X-Spam-Status: No, score=-2.9 tagged_above=-10 required=4.5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9] autolearn=unavailable autolearn_force=no Received: from mail.micronovasrl.com ([127.0.0.1]) by mail.micronovasrl.com (mail.micronovasrl.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Aq0_FqgMUU96 for ; Fri, 5 Oct 2018 23:59:55 +0200 (CEST) Received: from ubuntu.localdomain (unknown [192.168.123.60]) by mail.micronovasrl.com (Postfix) with ESMTPSA id 29F3FB0040F; Fri, 5 Oct 2018 23:59:54 +0200 (CEST) From: Giulio Benetti To: Maxime Ripard Cc: David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Giulio Benetti Subject: [PATCH v3 2/2] drm/sun4i: tcon: prevent tcon->panel dereference if NULL Date: Fri, 5 Oct 2018 23:59:51 +0200 Message-Id: <20181005215951.99003-2-giulio.benetti@micronovasrl.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181005215951.99003-1-giulio.benetti@micronovasrl.com> References: <20181004195605.txvbkshvxklyzxyb@flea> <20181005215951.99003-1-giulio.benetti@micronovasrl.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If tcon->panel pointer is NULL, trying to dereference from it (i.e. tcon->panel->connector) will cause a null pointer dereference. Add tcon->panel null pointer check before calling sun4i_tcon0_mode_set_dithering(). Signed-off-by: Giulio Benetti Fixes: f11adcecbd5f ("drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels") Reviewed-by: Chen-Yu Tsai --- Changes V1->V2: * None Changes V2->V3: * Rewrite commit log drivers/gpu/drm/sun4i/sun4i_tcon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c index e4b3bd0307ef..f949287d926c 100644 --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c @@ -491,7 +491,8 @@ static void sun4i_tcon0_mode_set_rgb(struct sun4i_tcon *tcon, sun4i_tcon0_mode_set_common(tcon, mode); /* Set dithering if needed */ - sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector); + if (tcon->panel) + sun4i_tcon0_mode_set_dithering(tcon, tcon->panel->connector); /* Adjust clock delay */ clk_delay = sun4i_tcon_get_clk_delay(mode, 0); -- 2.17.1