Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1039799imm;
        Fri, 5 Oct 2018 17:03:35 -0700 (PDT)
X-Google-Smtp-Source: ACcGV638EWmZMBNvpPug7B8jWMFrM9cVqBaY0c2gcyn9fRRUuFW04tC9AvhZe4Nyp6hhEStaYYp1
X-Received: by 2002:a17:902:b70d:: with SMTP id d13-v6mr13552790pls.44.1538784215507;
        Fri, 05 Oct 2018 17:03:35 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1538784215; cv=none;
        d=google.com; s=arc-20160816;
        b=O6fhWv+KsdIaeE13uNt4q7XH7f81pQschXNzMnLK2sJeENlE4UUG2s8FRDn+xAxSh4
         SGwWLgnIOdTU9Ip+SYJRc5clEnRZYFQXfzC+pqQROvnD7GzyVM5kAlUSH1OilAEbZo80
         4I62eymF54S/2LQPSGXm8Kcslp1HVaTZzYY0aN2vcQswphp8EQPmq8lGzXo3ivrkojWL
         PM2vIOhplznENpS63b42+fUsljcE2XXcqESYUc7Lprjw3MD7BR1VnCflQe5fBaGepkWf
         5dNAs/6CXcPlYETfZ4f6Uj/WIRQsQtcx+tkxjnBG4zKmYpgwP5FKXe/UdpvMltOvNFGB
         1r0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=nbX0a2BwHjJClBCxXwdomLCL7ALearOFbAqoHV2EXeY=;
        b=PdxV7GGzR54Gpjvd48wRxUKf/eUTb09T1cPfZguleDH0zibYAJNj7bbbgIhv/t/Rk5
         YSIpFyBSfRUuQf7wDy9BGXgpQMkVWCiKnZ05TPLVZ36q4B0OwJMiV40Yk0ozBmOw+fhv
         14m77/OM1BKbTleGpxtKS6eDaHe/6Es9TT3k8QjpJMLapV1f9pMOJNRdEY7jGqZh6lUZ
         ZtbA2AdycjWL2nupWm1KcvltAC7HCzfkt6ABQib16AYugIBGDWAZqeFlBcBse36h+1IN
         prCwWNv86Ydj7rJYB5YnvH8Tql3vXjC+woKf+bwsvFraQi5MP3Sc3TGAUnuCzq9rvkf0
         E+mg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WJ4tXzdO;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id e73-v6si9962297pfb.98.2018.10.05.17.03.13;
        Fri, 05 Oct 2018 17:03:35 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WJ4tXzdO;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729226AbeJFHEL (ORCPT <rfc822;michael.k.kehoe@gmail.com>
        + 99 others); Sat, 6 Oct 2018 03:04:11 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:11150 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726399AbeJFHEL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 6 Oct 2018 03:04:11 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bb7fbb80000>; Fri, 05 Oct 2018 17:03:04 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 05 Oct 2018 17:03:07 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 05 Oct 2018 17:03:07 -0700
Received: from [10.110.48.28] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 6 Oct
 2018 00:03:06 +0000
Subject: Re: [PATCH v2 2/3] mm: introduce put_user_page[s](), placeholder
 versions
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     <john.hubbard@gmail.com>, Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Jan Kara <jack@suse.cz>, <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        Jerome Glisse <jglisse@redhat.com>,
        Christoph Hellwig <hch@infradead.org>
References: <20181005040225.14292-1-jhubbard@nvidia.com>
 <20181005040225.14292-3-jhubbard@nvidia.com>
 <20181005151726.GA20776@ziepe.ca>
 <c6f31004-3a67-880b-47bb-b560dfd85343@nvidia.com>
 <20181005214826.GD20776@ziepe.ca>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <25021511-04f8-7b6a-6b15-2c95a3a01745@nvidia.com>
Date:   Fri, 5 Oct 2018 17:03:06 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181005214826.GD20776@ziepe.ca>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1538784184; bh=nbX0a2BwHjJClBCxXwdomLCL7ALearOFbAqoHV2EXeY=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=WJ4tXzdOv+Qzjxgo1t2STSgEYnZ1mz2emVbLj7YAqBxgPg9Rasrwgfd+ZLKgGYufj
         CKD55iP8CStdxaxcR/fNOr0R8AguRxESna6GNNbgzoUPkzgRysFuSVLWBQM4m40LB7
         aJDZAkMJntACFXHO0vcU3yQUBVwdsN9zaSYB71kf0WJHt47flIXO1X5DEPOoMgupLq
         e+H+pNvjdr2iuU0yBugPhjaE8/B7tOW7Pg/0ypxO1ZoeNm0WYqrBtMqVYClls0O5AY
         KRGMuk6wKmrGjdFu3nKykQ3x8CK8Db/V8TGp6l3wu7F8FBJ51Hj5YcCJsayqRHBrOl
         ufw441tF3IB6A==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/5/18 2:48 PM, Jason Gunthorpe wrote:
> On Fri, Oct 05, 2018 at 12:49:06PM -0700, John Hubbard wrote:
>> On 10/5/18 8:17 AM, Jason Gunthorpe wrote:
>>> On Thu, Oct 04, 2018 at 09:02:24PM -0700, john.hubbard@gmail.com wrote:
>>>> From: John Hubbard <jhubbard@nvidia.com>
>>>>
>>>> Introduces put_user_page(), which simply calls put_page().
>>>> This provides a way to update all get_user_pages*() callers,
>>>> so that they call put_user_page(), instead of put_page().
>>>>
>>>> Also introduces put_user_pages(), and a few dirty/locked variations,
>>>> as a replacement for release_pages(), for the same reasons.
>>>> These may be used for subsequent performance improvements,
>>>> via batching of pages to be released.
>>>>
>>>> This prepares for eventually fixing the problem described
>>>> in [1], and is following a plan listed in [2], [3], [4].
>>>>
>>>> [1] https://lwn.net/Articles/753027/ : "The Trouble with get_user_pages()"
>>>>
>>>> [2] https://lkml.kernel.org/r/20180709080554.21931-1-jhubbard@nvidia.com
>>>>     Proposed steps for fixing get_user_pages() + DMA problems.
>>>>
>>>> [3]https://lkml.kernel.org/r/20180710082100.mkdwngdv5kkrcz6n@quack2.suse.cz
>>>>     Bounce buffers (otherwise [2] is not really viable).
>>>>
>>>> [4] https://lkml.kernel.org/r/20181003162115.GG24030@quack2.suse.cz
>>>>     Follow-up discussions.
>>>>
>> [...]
>>>>  
>>>> +/* Placeholder version, until all get_user_pages*() callers are updated. */
>>>> +static inline void put_user_page(struct page *page)
>>>> +{
>>>> +	put_page(page);
>>>> +}
>>>> +
>>>> +/* For get_user_pages*()-pinned pages, use these variants instead of
>>>> + * release_pages():
>>>> + */
>>>> +static inline void put_user_pages_dirty(struct page **pages,
>>>> +					unsigned long npages)
>>>> +{
>>>> +	while (npages) {
>>>> +		set_page_dirty(pages[npages]);
>>>> +		put_user_page(pages[npages]);
>>>> +		--npages;
>>>> +	}
>>>> +}
>>>
>>> Shouldn't these do the !PageDirty(page) thing?
>>>
>>
>> Well, not yet. This is the "placeholder" patch, in which I planned to keep
>> the behavior the same, while I go to all the get_user_pages call sites and change 
>> put_page() and release_pages() over to use these new routines.
> 
> Hmm.. Well, if it is the right thing to do here, why not include it and
> take it out of callers when doing the conversion?
> 
> If it is the wrong thing, then let us still take it out of callers
> when doing the conversion :)
> 
> Just seems like things will be in a better place to make future
> changes if all the call sights are de-duplicated and correct.
> 

OK, yes. Let me send out a v3 with that included, then.

thanks,
-- 
John Hubbard
NVIDIA