Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1082911imm; Fri, 5 Oct 2018 18:13:47 -0700 (PDT) X-Google-Smtp-Source: ACcGV63o9iFFuD8ThyoY05vWlymvC43jRsrZ9oLfXDHuElbGQN3NXXcRfwhB+FEi+fq2HssLRho5 X-Received: by 2002:a17:902:b598:: with SMTP id a24-v6mr13814801pls.40.1538788427448; Fri, 05 Oct 2018 18:13:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538788427; cv=none; d=google.com; s=arc-20160816; b=lEY+QVhhMJ25pXvf8Vvm0MxyQ5ngJvXJgBXvBK9WhH9xjxp6NaCDKtGJmsyJiyCSym mWbZ/LYKs7k3JJEosUPJU/C7Xs5vX9nB1sM/LVcT51t/d+Ur59YdnYX+Xsgeoh8DtxFb BFO8ol2bCpubwjmAqq0rgg9fon39m4UlCzo2HyAp35oF27QGClIv3i2yfVAWp4Arh0dp jV98qqKAfKV/UGt+Kzf5MhyHK+MndHcFI3nHKul2sIIwd9EMqRG6ibhtr7r6hVr1ca5Y sSQldITf8JcnKvCesN9Zz8t22aSWnEtR6yvQWlwnVeSKkan64OhOOMDyVVvM1WgRPENk EpwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=bbcOSfmGPqGsrdH+cPdIozpr646I99ZSJ1i/nHZ0A3E=; b=T4QKe5H92S7KEnj4I3BCc58UG/O57yhTJ8WpOuF+YBLN3qOzipgAKH3Mt8LiWTvBMa 4kMkI0nIeyyiZzvoKFoPBZpejrD0NaI3D4uRL/eWkeSXW/gnJoxTePAsmMTiHqSEp4LY 24jxqrsTnQ1AS7nR5s+bwgIIRT5B9N8k1nkVVfy7NilHa9/Tvc2nubjY18RvQ/7OHDGw MtpvReBMl0sz+q5X1UyKh7v1HExtSpIDrBiGL4rc2U2nT5M02A5IvTM8JFNNjUQQ7cia 7t0Lj7n0GTKebKuM3m2XV8nNXiQu+ZH9uDx4Bv0DpzAeKXPzt5rzZ3QKCcHxTfaZF13B 4bmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=tFZGVcKm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q85-v6si10770428pfq.32.2018.10.05.18.13.31; Fri, 05 Oct 2018 18:13:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=tFZGVcKm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbeJFIOj (ORCPT + 99 others); Sat, 6 Oct 2018 04:14:39 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:45791 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726759AbeJFIOi (ORCPT ); Sat, 6 Oct 2018 04:14:38 -0400 Received: by mail-ed1-f65.google.com with SMTP id v18-v6so12037047edq.12 for ; Fri, 05 Oct 2018 18:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bbcOSfmGPqGsrdH+cPdIozpr646I99ZSJ1i/nHZ0A3E=; b=tFZGVcKmUw8OHecLASEe+AkStjykIYoxzwS3jc9RWFKVbNulzkJv91kQpGpmGBBxyw Y4/pkgguz/mxDb1il2ELYfQQ9jcx3JX5dbWXY+xP5tiJ8/w5gbREFdQVn8LIepn21FuZ d3oNXUlqnk3CINPB0Q3OX2bRoI0VcpCQ/z0Syu2lJPgChgRQufA74Oh221fthRIIkAXE Zgoz9iM40xO82cPJ47JntKa/qXPVXwADWmH/txhnS9yBAb5BkP/+c9BuhbgD/iN3XniC dNdlz4p9d21g9DlBDZ32wC3HBXj0pi9CaYDAjKQNVl5Qs8lvP6dMBh4KVeCaAKlLU6uG sS6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bbcOSfmGPqGsrdH+cPdIozpr646I99ZSJ1i/nHZ0A3E=; b=nrHMw9Dc4cuELGWxQfN8bbbJe/Za9AXGW3nHjPmiHS3hpTuVwokxCbuf00bUtt/tao OtfOl4bfIqnW6zJSVCoVFATM+nflZhwgHFib9SO442sR6voxUP6oLVdn0Gs6VDjm+Ahr /ogc/2QO3c8i/ulhhMB/zzrdazZY5B9wveXHlhYpt23R3jxRxm6XLJabsIZsuR8102r7 B3iwtRZuViz2ULKBxu4gVQfVaJDLRuIepmIZmCevfClzBPIbmmQKtGbesoR2Ngn9MTZI Bs768rYdGyZ/aZPn0txlaQfc3WhKv6TL5LzKxr5hdeKhRsRAIG2IEyegyy8C/vKTOCmf BBHw== X-Gm-Message-State: ABuFfoj7q0PU7GoSHmeZt3vItpdzVUjmAjTkYPeg/JHTeJcAK2+CE4ei 6PGkALjzDpHDV/OSWCJfy59toaRxaUg= X-Received: by 2002:a17:906:64c:: with SMTP id t12-v6mr13763381ejb.113.1538788399942; Fri, 05 Oct 2018 18:13:19 -0700 (PDT) Received: from [192.168.0.10] (95-166-82-66-cable.dk.customer.tdc.net. [95.166.82.66]) by smtp.googlemail.com with ESMTPSA id v15-v6sm38151edr.45.2018.10.05.18.13.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Oct 2018 18:13:18 -0700 (PDT) Subject: Re: [V2 PATCH 0/2] lightnvm: pblk: retrieve chunk metadata on erase To: javier@javigon.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, javier@cnexlabs.com References: <1538637235-25469-1-git-send-email-javier@cnexlabs.com> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: Date: Sat, 6 Oct 2018 03:13:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538637235-25469-1-git-send-email-javier@cnexlabs.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2018 09:13 AM, Javier González wrote: > Changes singe V1: > - remove sanity checks on the fast path > > This patchset implements support for retrieving chunk metadata on reset. > This is the base for implementing wear-leveling and allowing chunks to > shrink at runtime. > > Javier > > Javier González (2): > lightnvm: pblk: add helper for printing chunk state > lightnvm: pblk: retrieve chunk metadata on erase > > drivers/lightnvm/core.c | 44 ++++++++++++++++++++++++++++++++++-- > drivers/lightnvm/pblk-core.c | 54 +++++++++++++++++++++++++++++++++----------- > drivers/lightnvm/pblk.h | 9 ++++++++ > 3 files changed, 92 insertions(+), 15 deletions(-) > Right now there isn't a way in the spec to tell if the drive supports this feature or not, and DSM Reset doesn't support it either. Making it a bug in the spec. Until the updated spec is out, I like to avoid adding this feature into the kernel. The Get Log Page approach can be used for wear-levelling information. Similarly for knowing when a chunk shrink, pblk can't rely on a chunk not shrinking at runtime (and reporting early close error), so in the case this happens, pblk can either continue business as usual, or resync with the drive.