Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1877252imm; Sat, 6 Oct 2018 12:30:39 -0700 (PDT) X-Google-Smtp-Source: ACcGV63jeopyxGDVHs1N7qNYEJmZdbIauBWsGkj0PdxgOY6qNB/iP+7Agg8Vcd/08xBY4+/OzwwR X-Received: by 2002:a17:902:8690:: with SMTP id g16-v6mr16615773plo.302.1538854239231; Sat, 06 Oct 2018 12:30:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538854239; cv=none; d=google.com; s=arc-20160816; b=T9HatO2RBD0EbvWcdt2H45lDuKTGx1oxgYS1GycRM8OLVTawHe3ZO4l/fqQqwZM4iy sLVguD5imKjbq5wNRUAVNWZXekD0if1Pp9QFsnQCuk2YXkwr1MvJTQnUhxGqIhYk/ey6 Ng89PsNJzzWRzDPHeaJZWnjyb0Ct1kxWhWLmoICADlAbl5+eEC0l3juM4ci6EkEtJrco ZfgXjlIRZOA4EIenVRUyInODWEFtECHAoQlmAP/YgwHDIC4tZs+zV7KMytfe1UpttduC i6GPSFqicYxwB+w10ZsBigVKuGVvT1DxAqNvCwXXrhHtVBGcoANdDwW+1KGk/LP6jrV6 kUwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=fkgY0TEAqvCH9lixDZKwciJjg4l128lWBYK7tox1SSY=; b=pVfzkybytrysmdrDIV4+ZpP/1fCPOPJIcMjSWpoL2nB1BvFJ9NigaMfS1EHiYjcxCx PdRoTQkuIVXWvZcKUghkSi1Z0lDh0/2Viq9t4ryrgmYV28b7mDJ+G8WZxLPLAT4ib+aw ebPyP/tydyBN7hwWdpXxzcym+2klTr9GinCY9Vfe1Z30B7zmFmgV5YYdkS7ftR7Twx/Y LNg2Ys6iXSt6H92UXM3l2/btkNFU2SspN9Hn5Dtre4dTyhZ8voHbyNhD9hhl5SZNHthv qPirxoMotEKVyTNOEol5S/8stKKCpkuCJ00zbghHuial1Tqkqi64CbhSa5G1xz31wIC9 cqaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=cqTX2xYh; dkim=pass header.i=@codeaurora.org header.s=default header.b=lyVyQvrw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6-v6si3867693plf.164.2018.10.06.12.30.23; Sat, 06 Oct 2018 12:30:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=cqTX2xYh; dkim=pass header.i=@codeaurora.org header.s=default header.b=lyVyQvrw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727870AbeJGCeu (ORCPT + 99 others); Sat, 6 Oct 2018 22:34:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35182 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726217AbeJGCeu (ORCPT ); Sat, 6 Oct 2018 22:34:50 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 974A160C64; Sat, 6 Oct 2018 19:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538854219; bh=nvmBEWKaqrrmBrKgaCCI+tEon/SXkoK+j9x0HHJCUTM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cqTX2xYhvAeLIQ+nncaApC51vQ8SWNbPxlI/LXB8yjhnS4JZlxOH6wIo7Je1vdjkL +RB5i3FyPHVLKDCGL8r7cobxsRy6PQYPsu81nWpGF3uxZ6O1wztlDwE3xQNndwxtnE INbLqvnSwfy7fm8WTC4W17fjmh0ivXCC0LPGQf4U= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-52.elisa-laajakaista.fi [88.114.240.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B2C656079B; Sat, 6 Oct 2018 19:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1538854218; bh=nvmBEWKaqrrmBrKgaCCI+tEon/SXkoK+j9x0HHJCUTM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lyVyQvrwa31nle8IuxoB7pJzSVdP0PERcN/zeeWQGouvmEC6j4YjpiLjrgDa9rKoR vi9RntOIiYTOtyzm7ia8g8K38UvYU+0eNarlsCoAYtUCPpFFEptiqkvJkL4UgOf7Wx u4+q3dbXvy/vDChTh0OIM3kUziR57r0ZdyZvfQu0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B2C656079B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , Larry Finger , Tsang-Shian Lin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement References: <20181006184246.29985-1-colin.king@canonical.com> Date: Sat, 06 Oct 2018 22:30:13 +0300 In-Reply-To: <20181006184246.29985-1-colin.king@canonical.com> (Colin King's message of "Sat, 6 Oct 2018 19:42:46 +0100") Message-ID: <87r2h2euuy.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The switch case RATR_INX_WIRELESS_MC has a missing break, this seems > to be unintentional as the setting of variable ret gets overwritten > when the case falls through to the following RATR_INX_WIRELESS_AC_5N > case. Fix this by adding in the missing break. > > Detected by CoverityScan, CID#1167237 ("Missing break in switch") > > Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver") > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 1 + Is the fixes line correct? This patch is not for staging. -- Kalle Valo