Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2100970imm; Sat, 6 Oct 2018 18:58:43 -0700 (PDT) X-Google-Smtp-Source: ACcGV62lLwQSpUxBXF7v7VWRzG9goCRD2llKbc5rFafK7S8UzeSFUspbnYwoR1r47trk1xCr5jIl X-Received: by 2002:a17:902:8c90:: with SMTP id t16-v6mr17633651plo.251.1538877523349; Sat, 06 Oct 2018 18:58:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538877523; cv=none; d=google.com; s=arc-20160816; b=SjKBJNH9sicKAzpDrrRThbZ7qy6GeJXiI/5iPk67aitRMGlR/+n7lx1NtipQdTBvSz 0dzgd0gRBlenykAhSbxXH2W98Mzx/jwUni5IT2Zqeu2hr4GwTOqG0QAIhQq4BaOVf39M xlneMZUwJxKa5s7xhDUHJOILk0rt6rXIqMXabpx4DE8v+2YlI6LgRQFhdU/GjvZ5zP5M qr3BamWzqrRVNPCJCXGIAHr8Kh3weTkP6MKW+JIoLVKilGUdADEl2vQuxz6eXElEdTaz Ar0qk6ImvdUz1qLKYLC0YUBPNM01Y8MiGs+nk33KAieapI4bksouHMZIBCAX+R2hMX9c Y2/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0OaZaw47A/JttCtJEIkDRjZzgHhM4TZXBhMzf/0iXSY=; b=fAcu2nqfKlPY6J96HoJfVn0bYTwBt7XYg3qDuXm739VduKlPgHvyqIMXPQTe9G4IJP bTocklUcof8ortPf7NbZ424e9iUQEcJzij51W1IDmYNWsqAlc5OYm2ltEsldqgNT2f0q nTfTktv9pdb3GdFwcNxrAgVbnDhqXYCyXE1rsyN3TuUbAGXO503Jus+uQrfwvi6WXYjW hD4ZWqKaFnyuAWFsvvoqh2C09Dilu6tcvdZpZ6oUD1kHUi3TSzujbwMC7hz26zxvY/Ru iR9o8pjn5D/406KfT8YNY3brZ12flQPFdndgUP46TPF2H7f48oZ/hYZMsLs1pmaCqaV5 X8ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=iGsOx0M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u3-v6si13080192plz.353.2018.10.06.18.57.58; Sat, 06 Oct 2018 18:58:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=iGsOx0M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbeJGJDW (ORCPT + 99 others); Sun, 7 Oct 2018 05:03:22 -0400 Received: from frisell.zx2c4.com ([192.95.5.64]:40005 "EHLO frisell.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbeJGJDV (ORCPT ); Sun, 7 Oct 2018 05:03:21 -0400 Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id c3f4c4e7; Sun, 7 Oct 2018 01:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=w8fMCU7hDKsNZbRJpYnAWz9D0ng=; b=iGsOx0 M10cR8pGkoDaGS+n14YU3eJaDRqew7+NnqqLy1eCkSzd1YVA6IacaWb8Uzfup3+u CB8g8MS19Vwdn09khQcjjWDs/7U76/KhTnZmkc8bLpnBKW5AB4aVBz18MjPDDTOp 9umbZ9rKCR1ik7hlRO6yXtGZ7+t+GP8/PfTY8ZoXkfNzibDvwhtK8yq4Wc8ce5jK 5D4/xUTU8KQkoaWlQVWawS2RCLebBmo0TrhZNGbeDnciGWk6za9YJ78PUz8f3rEA JDHptU4n+GWeq/yneOA+rrFTIB7S1bH48oV8w5hYa2QrO27eoikf2POqlIoVt6NS 6RO4gf9khdHhOabA== Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 1fd957be (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Sun, 7 Oct 2018 01:57:15 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id o21so16092848otb.13; Sat, 06 Oct 2018 18:57:51 -0700 (PDT) X-Gm-Message-State: ABuFfojA/k6mW+vJMx3vGdEWLd0B1NDkVLWLBk+6T5Uy0PFKiaR3swUJ gPWZjMsXQX9EkN0UBivizsphCzmKAJn+frY2Xo0= X-Received: by 2002:a9d:17d0:: with SMTP id j74-v6mr9654669otj.268.1538877470789; Sat, 06 Oct 2018 18:57:50 -0700 (PDT) MIME-Version: 1.0 References: <20181006025709.4019-1-Jason@zx2c4.com> <20181006025709.4019-29-Jason@zx2c4.com> <20181006235414.GA11773@lunn.ch> In-Reply-To: <20181006235414.GA11773@lunn.ch> From: "Jason A. Donenfeld" Date: Sun, 7 Oct 2018 03:57:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel To: Andrew Lunn Cc: LKML , Netdev , David Miller , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Andrew, On Sun, Oct 7, 2018 at 2:01 AM Andrew Lunn wrote: > The BUG() statements all seemed to be removed. Thanks. > > We still have 1 errors, 193 warnings, 7529 lines checked from > checkpatch. There are still some Macros flow control statements in > them, despite me pointed them out multiple times. > > Im not reviewing this version any further. Until you get the very > basics right, i doubt this patch is going to make much progress > towards inclusion. Dave mentioned he wanted the Zinc stuff to be all set before looking at this, so I've been focusing my efforts mostly on that. But I haven't forgotten about your reviews, and seeing as you're actually interested in looking at this now, I'll be sure to address everything you've mentioned for v8. When I'm reasonably sure that's all done, I'll let you know, so that you're not disappointed again. Jason