Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2153585imm; Sat, 6 Oct 2018 20:37:32 -0700 (PDT) X-Google-Smtp-Source: ACcGV602y/ubLPvCpthoxOdq8Hf/v4t6N0uv81AcZEFmO7L1btVYcZunEEexCTxfLjK5BPtpjQD9 X-Received: by 2002:a62:be1a:: with SMTP id l26-v6mr9458587pff.204.1538883452243; Sat, 06 Oct 2018 20:37:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538883452; cv=none; d=google.com; s=arc-20160816; b=hRAbmeNWEWq3hgfJ8xIBYpmfp2NE2r+OJvYvfTdQBvI+1W6eLmP7DPZqII/cEFwYxk H86Y/ajVQs4L8hrhvjqr6/7eh6G6CEIGDTppzbHisWXGGOMcz3tQ8K2PDAdqwkIMgSUF YqdGrngjGjq4v6m+82HxKYMTEawR0DC7NSlhB3nZR8t2qf8KCQfa5aLrXSSlnfbLLn1Z lZa970k1TyqxV1PMO1nyqP+9/k/FbTv47Kon5HAdahtm1bCJ79B6JIKC2zVel42PvD7F sQ7HERRuizI/PQgMJn5R8VElFGHPFL2v0TnMRA5v0IwFfDlzYRTNFpArbwXjAlelKULu 6oVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=5zwO9NZgwJbTf09T6OEh+9VCoIdaGNT9FDjI2+3/4a8=; b=Ezy3F4i9IoxwU4eel7ORn03xcE4zSQmxVcqzjilG+ZJURRbnh4S/7DGcB0dFozWPpu IE4nrV1Xzdld+Ft4KWd5SujwzMPD5MlQd9g1y6BMSZmKhlA7stHt9+LeOY4+CnEaV+rK Lmug5wvuSCnPTuGqUvtGq1XcDmOg4u9nRP2//6ug0X7tDr3eiNW2CIb/Gt7vkZ1vTcPj g0G1NP0Vt4cWhl/Vh4SaxfYbbzWXomIclkxpRbOv5Z1pZSa0KKuZXEHSarjsVreUawyc ZhNvF6wBVfOzu91HxXTMT5Mh4T9sU3HjXnGq6kotA3Pj42t9BCA7wAjVzHTuxevnO7Gk tjQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=vUArfxnp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 8-v6si12210248pgv.137.2018.10.06.20.37.16; Sat, 06 Oct 2018 20:37:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=vUArfxnp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726406AbeJGKmz (ORCPT + 99 others); Sun, 7 Oct 2018 06:42:55 -0400 Received: from imap.thunk.org ([74.207.234.97]:44216 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726236AbeJGKmz (ORCPT ); Sun, 7 Oct 2018 06:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5zwO9NZgwJbTf09T6OEh+9VCoIdaGNT9FDjI2+3/4a8=; b=vUArfxnpSI0KNUOiB2cjRzn1c9 bxXfANSBF45jFhk94G99dh7ychFFIi5u9vjK51MZG232sFyz3nOcZGQf5FD2mIKO3LtEyq41jeIe3 8qiRFjgux5N2+ysW9y9KBKQkZxpUjEeXVEJr5//15JaP8G35A6ZHIQ/g5RObRsBZmjaQ=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1g8zs6-0006WK-Js; Sun, 07 Oct 2018 03:36:46 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 888177A5250; Sat, 6 Oct 2018 23:36:45 -0400 (EDT) Date: Sat, 6 Oct 2018 23:36:45 -0400 From: "Theodore Y. Ts'o" To: cgxu519 Cc: adilger.kernel@dilger.ca, jack@suse.com, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net Subject: Re: [PATCH v2 2/5] ext4: cache NULL when both default_acl and acl are NULL Message-ID: <20181007033645.GA12046@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , cgxu519 , adilger.kernel@dilger.ca, jack@suse.com, jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jfs-discussion@lists.sourceforge.net References: <20180831143352.22970-1-cgxu519@gmx.com> <20180831143352.22970-2-cgxu519@gmx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 12, 2018 at 11:04:35PM +0800, cgxu519 wrote: > On 08/31/2018 10:33 PM, Chengguang Xu wrote: > > default_acl and acl of newly created inode will be initiated > > as ACL_NOT_CACHED in vfs function inode_init_always() and later > > will be updated by calling xxx_init_acl() in specific filesystems. > > Howerver, when default_acl and acl are NULL then they keep the value > > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > > in this case. > > > > Signed-off-by: Chengguang Xu Applied, thanks. - Ted