Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2631419imm; Sun, 7 Oct 2018 08:18:56 -0700 (PDT) X-Google-Smtp-Source: ACcGV62Z2wjYpvaxmBKLS9QmBW7cMxVhtmj/lRR/YaH0tqYwvxjGDezv4Ihw/ypDte5TL8Oj6Ucc X-Received: by 2002:a17:902:5a0f:: with SMTP id q15-v6mr20710400pli.253.1538925536913; Sun, 07 Oct 2018 08:18:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538925536; cv=none; d=google.com; s=arc-20160816; b=JHcNzeuZmJ4FE52rvMxtDBYBi0519sjAu9a4olJKYDN8alqGoDk7kTH8JKvXfxdTre k0w/lLzo4G5ZPR0Y+MLL9nNgKlLKGKhSj2v5CcM0SVpxIX6TXgemGZedsW/Im2XztA3N 4O0J7A0I6yCQt2fBGEahq1sdaY+sypeZDTxDGwf+P54PkbJQ8wR2HwLz3bSXKIO9j0kg wgnffzaPpXzVM8ZWQIfUhbJaYXQbXnYThr4FNc3XEermjGyXNp5wKEJSIEYVj7xzsqwK cRhmy4o+y+tqjzO/iQNXVlNvIp1ZNlbVUZD0DzGw9UEaBH+hHLsXnjwny7Hdmm9U3Tht 6hxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=BorT1VJG9i6rdScAUl7EtOMAD5DKp30f1gIsAdUSHAA=; b=TvB5oIHElZzl9XtBCOP4M9pe3nxz8jOyL7fejwUfL6InIPdLLmFexDKVJy7jAltt6k 5yM/JTBDAnytGe4cgYoNXCKEYfMODN9666zvjnLBho+xa5TgN+JQb3fjAmFSkkhAseLe sNoYizf0AOBe5z1phUipyRfEXEr2jfkjCJeWK9VUyM4I3O6PkBB0r58msxU6ZpIJKLW6 RCDMrHztOnyfrmKWzD5Jy/JbZcaTtFL+jOBG0aAZBfVOkVQWMZHlUv1aKs8JOROK4Ujk y8eLtyzXBlnk+nI8QFGTHMx3pZEWdxWp2CAzmeUIB1eF28/Si3ItA6NXOEQYRvwDNJxi uBPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=y3TkYwh6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e26-v6si13401419pgb.161.2018.10.07.08.18.41; Sun, 07 Oct 2018 08:18:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=y3TkYwh6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728366AbeJGWZt (ORCPT + 99 others); Sun, 7 Oct 2018 18:25:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:58516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727517AbeJGWZs (ORCPT ); Sun, 7 Oct 2018 18:25:48 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A918320841; Sun, 7 Oct 2018 15:18:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538925493; bh=PE3/6sfnnWWhm8oWlbLk/w/cz7s0w072AhLkGd7g3hc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=y3TkYwh660vsKX8GQWlfjA1Hb7DdHkQw6wZG+maT+eQfyvlIR0AVBiaJbCY36g68c qdBLv75PrKcNTM8ar/k3vJutIndisUwfI6VOXqurvGu/lrFHHvqSrCrCQzq/k66jX4 yQybQI//lBWrSQ1xvFrf9rLmnWyDc21IC6BL8h1o= Date: Sun, 7 Oct 2018 16:18:08 +0100 From: Jonathan Cameron To: Song Qiang Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, himanshujha199640@gmail.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/3] dt-bindings: Add PNI RM3100 device tree binding. Message-ID: <20181007161808.44a61d45@archlinux> In-Reply-To: <20181002143812.3661-3-songqiang1304521@gmail.com> References: <20180925031724.21399-1-songqiang1304521@gmail.com> <20181002143812.3661-1-songqiang1304521@gmail.com> <20181002143812.3661-3-songqiang1304521@gmail.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Oct 2018 22:38:11 +0800 Song Qiang wrote: > Signed-off-by: Song Qiang > --- > .../bindings/iio/magnetometer/pni,rm3100.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/magnetometer/pn= i,rm3100.txt >=20 > diff --git a/Documentation/devicetree/bindings/iio/magnetometer/pni,rm310= 0.txt b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > new file mode 100644 > index 000000000000..4677690fc5d0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/magnetometer/pni,rm3100.txt > @@ -0,0 +1,20 @@ > +* PNI RM3100 3-axis magnetometer sensor > + > +Required properties: > + > +- compatible : should be "pni,rm3100" > +- reg : the I2C address or SPI chip select number of the sensor. > + > +Optional properties: > + > +- interrupts: data ready (DRDY) from the chip. > + The interrupts can be triggered on rising edges. =46rom Phil's response this appears to be incorrect and it's actually a level sensitive interrupt. I haven't checked the data sheet to confirm this. That'll bring all sorts of pain if you have a host that can only do edge sensitive so I'm hoping that's not true for you (edge sensitive only interrupts on hosts are pretty unusual though it cause me a lot of problems when I started out with IIO years ago :( The docs aren't super clear on this. The subtlety is whether there is a guaranteed 'low' time between reading the data and it going high again due to another reading. This usually only matters if you are running very quickly though so may be fine here. This will only become relevant with continuous mode if you add support for that later (I think!) Jonathan > + > +Example: > + > +rm3100: rm3100@20 { > + compatible =3D "pni,rm3100"; > + reg =3D <0x20>; > + interrupt-parent =3D <&gpio0>; > + interrupts =3D <4 IRQ_TYPE_EDGE_RISING>; > +};