Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp2935651imm; Sun, 7 Oct 2018 15:43:19 -0700 (PDT) X-Google-Smtp-Source: ACcGV624LxsU9Bctfk3kDr0XdtkWZgNVDjXPSnMNI/zDcLAjffQdkmla0brS435Dw29mw2FMFiU2 X-Received: by 2002:a63:f848:: with SMTP id v8-v6mr18545726pgj.82.1538952199817; Sun, 07 Oct 2018 15:43:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538952199; cv=none; d=google.com; s=arc-20160816; b=h/DOvqpI+Ra+8WCYAOT7m501U8UvoODf8sB1IpYPK8PwZguzP11+MYlahgraG4+Iwh gbaAfReuBKrTGsVUAJQttMHQ/i83oNfKxkyua6ZocmrvzG7hh0Zrh8euqoAgQiLvpx/Q qOlqtV2uEzr1BcLwuj2H7QiO/RlPpHKlp7Hpdfauwyos4rjIZTMUB+Nkl/OJ7Ebw9imF 9gfCnUKBx2yj3+06i0KwfKJ+YCOC2bMEA63BMkkGoTHv7bRll+ONOLw0u/29PsgMcfKY FB+1dKqwpsAAoZ5o/rtVatqCv5/52UEIQwTNREMRjeLc21U7kHmdmSy7vizh7Jc9L4EI DG8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=yxp5id9lMNvSglWhiNLo1rmpjCDxobRwASmj+aoEj7g=; b=XxoJfqpxONJH2N9FxGWWghTZTsiiBTH9aWHzp5V1UsyYbUgZMlOH+LakdUvcSzEWn7 h9Q0RoSlYVcSVIBXLSAjL+yhliu2dmewAIRxtK4N3Sc4SFm4oZ3JK47g4PUjxntRauXE oCItYdfheR1H/FZJCgfiyqGf2cDpdopi04R5RehZ+Sin8//iPy+1hqIJp3uic132fMVz QQCXnOQomqp5QaPgYjqdCsNucaUPYkqpFRKEYRQJc0aS8YqzBpR1W7yQyS5ONhiRoPJf jMrJ/oUTRdptAAxC1YcF6nvYQABdf3HY/wgP5BtKWDSDq3bU135mGCHzqkulZAP9NKoI UDSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=EBxgGcKh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l91-v6si17433952plb.315.2018.10.07.15.43.04; Sun, 07 Oct 2018 15:43:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=EBxgGcKh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbeJHFoV (ORCPT + 99 others); Mon, 8 Oct 2018 01:44:21 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:45642 "EHLO mail-pl1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726295AbeJHFoV (ORCPT ); Mon, 8 Oct 2018 01:44:21 -0400 Received: by mail-pl1-f179.google.com with SMTP id y15-v6so9155308plr.12 for ; Sun, 07 Oct 2018 15:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=yxp5id9lMNvSglWhiNLo1rmpjCDxobRwASmj+aoEj7g=; b=EBxgGcKhBKklnjENJ90TYhbHIpYEqMovFwW4IZCL5euGyQdCKW/G02LyL9w5rjTN9e txH0DEpR41mHWBHy6gfywaHxCUYQ63iFuMKMKK4nBIJLzjEahD27DngGl1ayBlZNPITK hPHJcZo1Onke0fsKg1vhu8KRk3RWcsY4lnhb7nE93CSbv+IiShi5U34Rbg5jnKI01Ekr Qm/1xlqC/LtLRzADwBV5bp/fMXJ0rSTu7CfE+LlLSJCW4BkRq1+AnS6aIQ8UKeJJyhc3 G1v+4eyKfb3vJRjLjJHR4kjFZcsudQRKLgP+1dPFrAlIjJZG1JYlYVFJtb3Teubh6pqE NACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=yxp5id9lMNvSglWhiNLo1rmpjCDxobRwASmj+aoEj7g=; b=ha5WR9T0DCEBj1mDI43u3NAPD7fKx6NrzcYECaNJbZJTWZ2uvWnYQYjTT/Kii9Q7kN RDKVVshta6qJ5+GMdBI70YUmJVztiaZsaDE0WXnboNbblezJMBRZm+EbHG6ken0eZ1Al EHZxafq+YrqpEqacAaXzKUozLJTryDmLx1wPuXvmDsoE/j+d3ene+fudpUug6Ud/qjiv rX+qzl5y2gqrpDN6znRooXbTV3aXg11wd19huZZEP5jYbzRxGGrt2QBOaLQUQSD6eR74 SGFCU5CVhy2cWcDfD88djOq+I7Vcq21yaVq0wqoTLJN5S0rwXNmGWoy42Jlc+oy9i5uj Cu5g== X-Gm-Message-State: ABuFfojKVvvB6WH7vtb50v1IMiZNEqkcGOGFYKZNySNP8o06x+AN1G4A 1hVvrnuj46bjofSZEMmDnOLAOA== X-Received: by 2002:a17:902:680e:: with SMTP id h14-v6mr21527729plk.177.1538951737974; Sun, 07 Oct 2018 15:35:37 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id m11-v6sm17694665pgn.39.2018.10.07.15.35.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Oct 2018 15:35:37 -0700 (PDT) Date: Sun, 7 Oct 2018 15:35:36 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Andrew Morton cc: Vlastimil Babka , Greg Thelen , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, page_alloc: set num_movable in move_freepages() In-Reply-To: <20181005142143.30032b7a4fb9dc2b587a8c21@linux-foundation.org> Message-ID: References: <20181005142143.30032b7a4fb9dc2b587a8c21@linux-foundation.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Oct 2018, Andrew Morton wrote: > On Fri, 5 Oct 2018 13:56:39 -0700 (PDT) David Rientjes wrote: > > > If move_freepages() returns 0 because zone_spans_pfn(), *num_movable can > > move_free_pages_block()? !zone_spans_pfn()? > move_freepages_block() more accurately, yes. And yes, it depends on the return value of zone_spans_pfn().