Date: Tue, 25 Nov 2003 11:26:25 -0800
From: Stephen Hemminger <shemminger@osdl.org>
To: Greg KH <greg@kroah.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org
Subject: [PATCH] prevent oops from read of proc entry for tty drivers
Message-Id: <20031125112625.4c2b40f0.shemminger@osdl.org>
In-Reply-To: <20031125004716.GA28135@kroah.com>
References: <20031124155222.6b44d2a3.shemminger@osdl.org>
	<20031125004716.GA28135@kroah.com>
Organization: Open Source Development Lab
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 809
Lines: 20

There are /proc handles there setup by proc_tty_register_driver, but there is
no module ownership association, so anything that reads after module unload
will blow.  Fix is to propagate owner of tty_driver to proc entry.

diff -Nru a/fs/proc/proc_tty.c b/fs/proc/proc_tty.c
--- a/fs/proc/proc_tty.c	Tue Nov 25 11:18:53 2003
+++ b/fs/proc/proc_tty.c	Tue Nov 25 11:18:53 2003
@@ -198,6 +198,7 @@
 		return;
 	ent->read_proc = driver->read_proc;
 	ent->write_proc = driver->write_proc;
+	ent->owner = driver->owner;
 	ent->data = driver;
 
 	driver->proc_entry = ent;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/