Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3194391imm; Sun, 7 Oct 2018 22:53:09 -0700 (PDT) X-Google-Smtp-Source: ACcGV61vxP5B5R+daqQ99spKeBbfaxaqr6doD3jGb+I2Dj0PDBZCG79rGJilsMW4kLYzysdt2glp X-Received: by 2002:a62:e110:: with SMTP id q16-v6mr23230317pfh.75.1538977989619; Sun, 07 Oct 2018 22:53:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538977989; cv=none; d=google.com; s=arc-20160816; b=VskkulUSzVi4Md9lCvw8KDzNB/Zk+gffkbco47axglg76rUGP/NqRKemQuKwIhQSHh Z7X8gYbVcDvdYnP8tugQ/f6E/fJawSvWyc+2ZAplqk1dyLWev5up6hGl0HTBU5Lqs4zr P7p3Ru/JYV3acx8YgZtlCLbAmpUdO1qjXSv08jm8rv00GRNrzudug7gD7Z/rF6UWez55 RlC8ovNT+lHGfn2zoAB0LQj10RwPt2gPBl6yImYmcVDfxBw50Cva62o/WiPISn64WM7w wjl0jebX4n0bX0t95f/VNwfPpqvnG8+ZfKAmDAyBLTD9Jrx7lliEYlokRRbMqA8nqYWy Nbtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=F3GSclkuq3Pbu5xA1wjLxztHPxn3xy8I0M0dJLWLxmI=; b=oFjNfdZCH0Wwa+b1XOsGQjbgcId8aYJkbs6q/CE246+78C3nt8VkJioeY477JUaj0R 8hgwkib++EN/RZAEDclb48Ky1CfLXvgARZ8J4nIWgb+xmNvTrNkLNAm/lRmrx9M+RmET 53SFXQef0y8L6hPjx/SuIQBbIc14JXbIAe1ZcXZehPbs3SeW72Mj6ypd3zqQPSmS13/P lwn2O9Y3lsmAKxVDpvrMEZo5xiYMN60mcMP39D5HLq75yfUoiDeYmaO33FDIwst47HUl tjAXEBXz7mVDaieLODJMLf3VdYI4cgxd+UVRJVZ2004mdcnBHrzg9ueOh3foXQjlaz78 Ux5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y30-v6si16624593pge.142.2018.10.07.22.52.54; Sun, 07 Oct 2018 22:53:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbeJHNCi (ORCPT + 99 others); Mon, 8 Oct 2018 09:02:38 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:41028 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725857AbeJHNCi (ORCPT ); Mon, 8 Oct 2018 09:02:38 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1g9OT0-0001pU-Fc; Mon, 08 Oct 2018 13:52:30 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1g9OSw-0005cX-Fn; Mon, 08 Oct 2018 13:52:26 +0800 Date: Mon, 8 Oct 2018 13:52:26 +0800 From: Herbert Xu To: Leonard Crestez Cc: Marek Vasut , Fabio Estevam , Horia Geanta , Franck Lenormand , Shawn Guo , Aymen Sghaier , "David S . Miller " , "linux-crypto@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/3] crypto: mxs-dcp - Fix tcrypt on imx6 Message-ID: <20181008055226.kpqykclsjmb72cde@gondor.apana.org.au> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 02, 2018 at 07:01:46PM +0000, Leonard Crestez wrote: > The mxs-dcp driver currently fails to probe on imx6. Fix the whole thing > by porting a cleaned/squashed version of fixes carried in the NXP vendor > tree. > > Tested with "modprobe tcrypt" and CONFIG_CRYPTO_MANAGER_DISABLE_TESTS=n > on imx6sl imx6sll imx6ull: no failures. > > I'm not very familiar with crypto and did not write write these fixes so > a skeptical review would be appreciated. > > Previously: > https://lore.kernel.org/patchwork/patch/989652/ > > Dan Douglass (1): > crypto: mxs-dcp - Implement sha import/export > > Radu Solea (2): > crypto: mxs-dcp - Fix SHA null hashes and output length > crypto: mxs-dcp - Fix AES issues > > drivers/crypto/mxs-dcp.c | 121 ++++++++++++++++++++++++++++++++------- > 1 file changed, 101 insertions(+), 20 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt