Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3269101imm; Mon, 8 Oct 2018 00:42:02 -0700 (PDT) X-Google-Smtp-Source: ACcGV62XrRt87Aq3CV70x21Cor0ccDEfBpuGWVBoOOM+eJ/z008jm3HQhS3WczWAYAIBg8iDfTE2 X-Received: by 2002:a17:902:1026:: with SMTP id b35-v6mr23100524pla.283.1538984522027; Mon, 08 Oct 2018 00:42:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538984522; cv=none; d=google.com; s=arc-20160816; b=WDdOmhVD1I0GhGalWIlybh/tS4xs4dM7quBxSOPtiW0pIzB597qgg82YodDQEWkCN0 iSnhgrmK4Bz1EUp5JbmPRMyDpf16aVK1gSy0Iaf/1mSxs6oVwIEVLk5ugH3/tofs1Yov hk0mcpwb5Z8BMRXq1n+NOGEU3y/uZFDO6o0APRupcFWWU8+w8Nd3/D5Po0/4t1l7kJMY Asxk1ypP3yH7dBDoyKHnagdSOfmIhro1C43La+4hjVnnXEckRB/qv/AleUjjKBOdREoF 9UQiRVfFubo8G64BKXyeI6tn7nV1t8zOS7zqhiZHzrRAZEJ+Zd4yZRGqmL83hgobu2qV jGkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version:dkim-signature; bh=MmMJIbnNXeuKuv5NvVuqA9ziOS+mm63Qt77MzDjWQno=; b=tR/hRh0tSxWgdvXTfIHTXs3tbxMdhMXcKj22bFqLk4MwZOaFIceaDT8pD3VSlFMSFh JftH9cnS0iL+dP0VCiZHbBrxaC5XSYL60Hsh4ZJgtV56TScqkeAYdeVHbNLTXYPBzjOL iLcxfgE/VffBwqRSA7h/ZFSU/YcndJ38lPOOCRPGtoucT0eT6YrRYQMIQzlB/SUiri/T 7o4yZHWfXsLt+XSx2uGmvlI/WCMBrVYchuby/ICdMfr+iJFQRPfjyl1oCh68FTTIYU7t kg9oHMyCKWAL3bguCRAorfQNeFhvR/ZFicCxvM+IIym//PbgNNW9yHOnT7IWwzugdYx8 i7XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TTF7l5Ni; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k6-v6si17247975pls.174.2018.10.08.00.41.46; Mon, 08 Oct 2018 00:42:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TTF7l5Ni; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbeJHOvP (ORCPT + 99 others); Mon, 8 Oct 2018 10:51:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:43220 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725925AbeJHOvO (ORCPT ); Mon, 8 Oct 2018 10:51:14 -0400 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B3FD20645; Mon, 8 Oct 2018 07:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1538984452; bh=9G2Wac3g3fZwGPGo6JirZ0jZGuqGW5bxWgvX1S5Anes=; h=To:From:In-Reply-To:Cc:References:Subject:Date:From; b=TTF7l5Nio33ZGmdpB3h/7Qox3/s8IHUbe3ow/anCTyzLZDBW0nhiWEulQLXKsqI38 L/QrsmmUw97cRkykqFMfHx3EIhNFQ6axyNrHYSR6nE68qrsUyA8FToMMSppURb44N5 J6utXh+kNZeM88RiPddUd/7o0ETy8hq2t31BjcV8= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Anson Huang , Fabio Estevam , Jerome Forissier , Peng Fan , Rob Herring From: Stephen Boyd In-Reply-To: Cc: dl-linux-imx References: <1533703167-26583-1-git-send-email-Anson.Huang@nxp.com> <1533703167-26583-2-git-send-email-Anson.Huang@nxp.com> <153567894721.93865.4092113232222931488@swboyd.mtv.corp.google.com> <153573827629.93865.6200966443862432044@swboyd.mtv.corp.google.com> Message-ID: <153898445180.119890.15025812558797341532@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: RE: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array Date: Mon, 08 Oct 2018 00:40:51 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2018-09-03 00:20:53) > > > On 08/31/2018 03:29 AM, Stephen Boyd wrote: > > > > Quoting Peng Fan (2018-08-12 18:15:41) > > > >> Hi Anson, > > > >> > > > >>>>> -----Original Message----- > > > >>>>> From: Anson Huang > > > >>>>> Sent: 2018=E5=B9=B48=E6=9C=888=E6=97=A5 12:39 > > > >>>>> To: shawnguo@kernel.org; s.hauer@pengutronix.de; > > > >>>>> kernel@pengutronix.de; Fabio Estevam ; > > > >>>>> mturquette@baylibre.com; sboyd@kernel.org; > > > >>>>> linux-arm-kernel@lists.infradead.org; > > > >>>>> linux-clk@vger.kernel.org; linux-kernel@vger.kernel.org > > > >>>>> Cc: dl-linux-imx > > > >>>>> Subject: [PATCH 2/2] clk: imx: imx7d: remove clks_init_on array > > > >>>>> > > > >>>>> Clock framework will enable those clocks registered with > > > >>>>> CLK_IS_CRITICAL flag, so no need to have clks_init_on array > > > >>>>> during clock > > > >>>> initialization now. > > > >>>> > > > >>>> Will it be more flexible to parse dts saying "critical-clocks = =3D " > > > >>>> or "init-on-arrary=3D" > > > >>>> and enable those clocks? > > > >>> > > > >>> Parsing the clocks arrays from dtb is another way of enabling > > > >>> critical clocks, but for current i.MX6/7 platforms, we implement > > > >>> it in same way as most of other SoCs, currently I did NOT see any > > > >>> necessity of putting them in dtb, just adding flag during clock > > > >>> registering is more simple, if there is any special requirement > > > >>> for different clocks set to be enabled, then we can add support t= o enable > > the method of parsing critical-clocks from dtb. Just my two cents. > > > >> > > > >> Thinking about OP-TEE want to use one device, but it's clocks are > > > >> registered by Linux, because there is no module in Linux side use > > > >> it, it will shutdown the clock, which cause OP-TEE could not acces= s the > > device. > > > >> > > > >> Then people have to modify clk code to add CLK_IS_CRITICAL flag to > > > >> make sure the clocks are not shutdown by Linux. > > > >> > > > >> However adding a new property in clk node and let driver code parse > > > >> the dts, there is no need to modify clk driver code when OP-TEE ne= eds > > another device clock. > > > >> > > > > > > > > If OP-TEE needs linux to keep things on then why can't the OP-TEE > > > > driver in Linux probe, acquire clocks, and keep the clks enabled fo= rever? > > > > > > Sounds reasonable, but how could this be done without introducing > > > platform-specific stuff in the OP-TEE driver? > > > > > = > > Why is that a goal? > = > I do NOT think we should consider such case in this patch series, whateve= r OP-TEE needs for its own > feature, it should do necessary operations either in its driver or somewh= ere else by adding new patch. > = Why can't we add clks to the op-tee node in DT's /firmware container? Then any clks in there can be turned on forever and left enabled by the linux driver?