Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3313742imm; Mon, 8 Oct 2018 01:41:37 -0700 (PDT) X-Google-Smtp-Source: ACcGV60432TlVMpRNwF64pnUg7K1uLpTgvawIgx1PMrn7PBXDj4r/IGIinNMwf0NUOYeZ8/flsMK X-Received: by 2002:a17:902:758b:: with SMTP id j11-v6mr23016257pll.5.1538988097892; Mon, 08 Oct 2018 01:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538988097; cv=none; d=google.com; s=arc-20160816; b=oP9W9UA+o2HymixSHfksPIPnyGhnLXb85ohDUvDTMCV4RY2sM+mcPZiTHZnO6M+hZe YNp8aLSZ0wfITmUeoQjE6AQWL5ou7KAAbs8/ThU2sh9SouI6C1vZBbIv6T/Yo3Sw3VoT AWFNicR0eXTjGld86/Bzy4+RS73TuK5LcmGq+Bq1h6NpNyWURpspSbyJaB8mE3V2mHBB D3/vnstwEuUTCv4Xg3j4Cr8jrLITCQBISUDlgLX0TZOZcjg7Rn9pQ9kD+WCGndbPmHeb VrN25BdD2KuSu42d9GzLfl5kHcP7f1avvd0WpwKLqP+dwksGrvM1SsjxMxuzp8geR7L/ yHKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=udpAA6g8Ywe9TbyqVq4caKf/X0IHuOCDnVvfBiOtuLU=; b=yxHPKrdRVPkP3Du6NYCbiaPIptSJ0btkBvjn70+DtJBRVKgCYqSytC1wMhOJLzdoLw Qy27QqEwd46hidQ7m9BSJXzy4GCdoB/MbUYG3Aah0KQ8K4vZXQ6UkW2B5jWjy1byvOOR tge2Xy59cP1pned4l5fBFzmJHslZeB8PJBPGE2YDeyo7DFn8mnEZ4G0VvR8OpMX9RNTd 3vsR9TCVFrtDcBi4TTGMzcyXNSCICQrExQ09htVsGuCGaUKPgQK46CNT9u3Qua3VD33P EddXlop7MdKUW0swDJE06S8GY7FzgIqBohaWpuPF1bMRMoBTWvZaD7TWAd2Rc25XYo94 P7sQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u9-v6si15224516pgh.580.2018.10.08.01.41.22; Mon, 08 Oct 2018 01:41:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727277AbeJHPvg (ORCPT + 99 others); Mon, 8 Oct 2018 11:51:36 -0400 Received: from www62.your-server.de ([213.133.104.62]:35350 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbeJHPvg (ORCPT ); Mon, 8 Oct 2018 11:51:36 -0400 Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1g9R5v-0008UB-2p; Mon, 08 Oct 2018 10:40:51 +0200 Received: from [62.203.87.61] (helo=linux.home) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1g9R5u-0004sg-Pm; Mon, 08 Oct 2018 10:40:50 +0200 Subject: Re: [PATCH] bpf: fix building without CONFIG_INET From: Daniel Borkmann To: Song Liu , Arnd Bergmann Cc: Alexei Starovoitov , "David S . Miller" , John Fastabend , Martin KaFai Lau , makita.toshiaki@lab.ntt.co.jp, Lawrence Brakmo , Andrey Ignatov , Jesper Dangaard Brouer , Jakub Kicinski , Mathieu Xhonneux , dsahern@gmail.com, Networking , open list References: <20181005161526.843924-1-arnd@arndb.de> Message-ID: <9330215e-27bf-9913-f7f9-6b5b83542a27@iogearbox.net> Date: Mon, 8 Oct 2018 10:40:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.1/25017/Mon Oct 8 06:49:45 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2018 09:07 PM, Daniel Borkmann wrote: > On 10/05/2018 09:02 PM, Song Liu wrote: > [...] >> BPF_CALL_x() has static already (before this patch). We should not >> need change that >> for all the BPF_CALL_?(). Joe's version looks better to me. > > My preference as well, thanks! ping, can someone send an updated patch? Thanks, Daniel