Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180927034829.2230-1-Tianyu.Lan@microsoft.com>
 <20180927034829.2230-3-Tianyu.Lan@microsoft.com> <2ab49b6e-59d1-1b1f-b533-85e5bc49dd85@redhat.com>
In-Reply-To: <2ab49b6e-59d1-1b1f-b533-85e5bc49dd85@redhat.com>
From:   Tianyu Lan <lantianyu1986@gmail.com>
Date:   Mon, 8 Oct 2018 17:17:28 +0800
Message-ID: <CAOLK0pykDDmXtDwGCMeokoFrYjd+qVrzFSxVi0iiq1=Z+_K9Pg@mail.gmail.com>
Subject: Re: [PATCH V3 2/13] KVM/MMU: Add tlb flush with range helper function
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Tianyu Lan <Tianyu.Lan@microsoft.com>, kys@microsoft.com,
        haiyangz@microsoft.com, sthemmin@microsoft.com,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Radim Krcmar <rkrcmar@redhat.com>,
        devel@linuxdriverproject.org,
        "linux-kernel@vger kernel org" <linux-kernel@vger.kernel.org>,
        kvm <kvm@vger.kernel.org>, Michael.H.Kelley@microsoft.com,
        vkuznets@redhat.com, Jork.Loeser@microsoft.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Paolo:
              Thanks for your review. Sorry for later response due to holiday.

On Mon, Oct 1, 2018 at 11:26 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 27/09/2018 05:48, Tianyu Lan wrote:
> > +
> > +     if (range && kvm_x86_ops->tlb_remote_flush_with_range) {
> > +             /*
> > +              * Read tlbs_dirty before flushing tlbs in order
> > +              * to track dirty tlbs during flushing.
> > +              */
> > +             long dirty_count = smp_load_acquire(&kvm->tlbs_dirty);
> > +
> > +             ret = kvm_x86_ops->tlb_remote_flush_with_range(kvm, range);
> > +             cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
>
> This is wrong, because it's not the entire TLB that is flushed.  So you
> cannot do the cmpxchg here.

Yes, nice catch. Will update in the next version.


-- 
Best regards
Tianyu Lan