Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3890096imm; Mon, 8 Oct 2018 11:11:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV60JORc75A0Kd9W4GfHXW0kBFE79O6qwPw2iuy/lgEaYg4ftkwnjnKT9hFlsHj1VkLRoBBCa X-Received: by 2002:a65:62d5:: with SMTP id m21-v6mr22591025pgv.243.1539022275460; Mon, 08 Oct 2018 11:11:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539022275; cv=none; d=google.com; s=arc-20160816; b=Uvu3K3pQMXyetohNBSgc1JQot+B2jsS0DjnvHHS7wqWtHBC5AVduNTd501thYfGfV7 hJtxru3reO0wbyjtsFje9h483GC2gWUsdv4Xzw2uFvJ+diGBPhgg2lVzTAkiSW08HXVv zyja0BI70ZUCm82msaYP98qGm8lQ9AM5+PoFHTqx39UPlCHATnPj2zf44GFcPNFOsfXN Ow8P8Ye0bZfZyKh/8E+ta7+f3fyW0Lxa1HzPtoPtbaOAiHskfwCFFOA+48BAEIPC2zDp nd/SDGpgFH3bZO+Euk2zrPw0HYKKNxvPbi4QgkiejemjoQVQ6OQGnq0w9eNh0n7RpKl3 YO/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=NLw4FI/TIaLkl+F/mFCJEwxbT6pRHxR+iAlWXJgbZz0=; b=iqdB4wDos6h2k7c7QmdYea4ZwKbiRWjvW4k87Qn9Rhkn9qXNbANe+0/kMvV5PhB1Pd Zl3ISJaU36AoURD77IJQ0E++fhKQOd6gqWVqQqw2HLIP7Bre8AceFcXc7D0krO0MXTQw U/deIrOA3r2IF0feF6akEkJhdso4vtENLOgfjT6Z4yK79Pfd+wRsRtajziminZWgphS3 cyPlh4OtDHzih2BqNc3yUBdSQHUzt3IzS4YFmpIGNsVgwG5QqESp7O1dz0tB1FzroMJx jZ8FIkpAioe/eFOc/YN80elSS0mlpsUqptpEzZrnmhmc6wXmPMWDungzRDqDes8PgeU1 VrwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si15855682pgi.5.2018.10.08.11.11.00; Mon, 08 Oct 2018 11:11:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726592AbeJIBXn (ORCPT + 99 others); Mon, 8 Oct 2018 21:23:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:57632 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeJIBXn (ORCPT ); Mon, 8 Oct 2018 21:23:43 -0400 Received: from localhost (c-67-183-145-105.hsd1.wa.comcast.net [67.183.145.105]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B2AF8141E0E9D; Mon, 8 Oct 2018 11:10:46 -0700 (PDT) Date: Mon, 08 Oct 2018 11:10:46 -0700 (PDT) Message-Id: <20181008.111046.1103300226053324861.davem@davemloft.net> To: keescook@chromium.org Cc: axboe@kernel.dk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH sparc-next] sunvdc: Remove VLA usage From: David Miller In-Reply-To: <20181008154651.GA36881@beast> References: <20181008154651.GA36881@beast> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Oct 2018 11:10:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Mon, 8 Oct 2018 08:46:51 -0700 > In the quest to remove all stack VLA usage from the kernel[1], this moves > the math for cookies calculation into macros and allocates a fixed size > array for the maximum number of cookies and adds a runtime sanity check. > (Note that the size was always fixed, but just hidden from the compiler.) > > [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com > > Cc: Jens Axboe > Cc: linux-block@vger.kernel.org > Signed-off-by: Kees Cook Applied.