Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3904227imm; Mon, 8 Oct 2018 11:26:13 -0700 (PDT) X-Google-Smtp-Source: ACcGV62dcHdUKdC7cft5WMSa2sMl1iS8Glpm5sxUmL37PLlyy8a+iH1/8oVs80YkeYm6TlwG1cRE X-Received: by 2002:a17:902:8a4:: with SMTP id 33-v6mr25328267pll.65.1539023173377; Mon, 08 Oct 2018 11:26:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539023173; cv=none; d=google.com; s=arc-20160816; b=ka6vTUKzntrJcOhvk0iktK8Pl2Wdz8SDkU8DS0aJB/uUu2ZDDQHV5CY4pYoERV25gx ik7XkwK9zTjMwTTdT+uKflUIOO4rrKalo1F1jMehq7PyTEUYc+G8al1EruZkx3Y5VPYk yTHfhrWaGE480fVPoR7NICK6k7FDscmmM8mmVCiq60tZzGURAyCG30YiS8SvjsJ4Rcdx 5dy9SaN6R3IpgwIW9EVU49dON7eCdR+uLfVExoaFpFGQnKldsXw0lDw4G5N0+qnpORmL fRDqBV0qrir8iLBqOwMo49dtXqEibmXHohhuSkXGMQBGWIh+Klrxz0bdo0vt0+oIZaHB d9fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=jzYHC3xKOHawKbR+h1mRy77otqwJGD6Kk1BNMZe0X6s=; b=m4yRN2SuHOz5Cp18SwXoL1XOczxIvHzUAJ7r7FjK3uyOTv9E1RBDJLG4fAdoLKaGLw UV1eopt4zMFpv6YWiuPAYCE1jYka+PPdMor5vDsaHJkYgIsf5IdVcYUmXHOQMNOonncQ TX2O1+WjM0YlXL3EnKSJIrswtgmZbGIQMJQt4lCf0oxc9+50F/KlXPd4LwRTUuJaxHCQ RI46XcblO9D7VPBVALYtK7c0pWE42nTDg5gCzgawH8lH0g79ZgdaC0BnW3eKJzUUxzHL 4zHWnL3T2JkVsedm7d0K35r7vLohXPJ7yAJQOG36PU0ku9i7RNG4jwFYkjaqOVsM3fOj q0SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n77-v6si19025812pfi.67.2018.10.08.11.25.58; Mon, 08 Oct 2018 11:26:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbeJIBhh (ORCPT + 99 others); Mon, 8 Oct 2018 21:37:37 -0400 Received: from mail-qt1-f171.google.com ([209.85.160.171]:34369 "EHLO mail-qt1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726391AbeJIBhh (ORCPT ); Mon, 8 Oct 2018 21:37:37 -0400 Received: by mail-qt1-f171.google.com with SMTP id o17-v6so6047456qtr.1; Mon, 08 Oct 2018 11:24:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jzYHC3xKOHawKbR+h1mRy77otqwJGD6Kk1BNMZe0X6s=; b=sbvLhGCgAYqa7MTLtJGtyrw94NWcEFYuLtCA0Y7n9vevL88+PBPU3c8twBaEcAq2rm zihzfsSWwwkMkN+Iwn5Bi2yKQLOWWU72w6F4VfGzm5ueQ27F+QMHcWY2zHE58erscg67 mq4yD1HNuSWnjW3zkYEN43K6nk93qIGF7RwEZ3aRO6TeGNCI7OOmACWJgHpgYco8d3Lj sQVXFO55sBOgukUODv3Chkmog/iYtH36sJAVvLcvAtnl1+QgyUGznU0V6c1cNeCTS2UY vvE2W/EH9qB80t9Hd7KKWGDLctKHPHNiwEYy6RwIyGMnJOQQCZkahDsuP8LcGUsvKlm/ sOQw== X-Gm-Message-State: ABuFfojVkc5QnMMegNYy3Sesr4fb82Wuh3z7oQvPNnTGjGc90XnCb0Nt 08fwh3M8QJgn1Bf4BEUxY3OKMKRt5sfCfzrTD8A= X-Received: by 2002:a05:6214:114e:: with SMTP id b14mr19833457qvt.169.1539023077412; Mon, 08 Oct 2018 11:24:37 -0700 (PDT) MIME-Version: 1.0 References: <20181005161526.843924-1-arnd@arndb.de> <9330215e-27bf-9913-f7f9-6b5b83542a27@iogearbox.net> In-Reply-To: <9330215e-27bf-9913-f7f9-6b5b83542a27@iogearbox.net> From: Joe Stringer Date: Mon, 8 Oct 2018 11:24:25 -0700 Message-ID: Subject: Re: [PATCH] bpf: fix building without CONFIG_INET To: daniel@iogearbox.net Cc: liu.song.a23@gmail.com, arnd@arndb.de, ast@kernel.org, David Miller , john fastabend , Martin KaFai Lau , makita.toshiaki@lab.ntt.co.jp, brakmo@fb.com, rdna@fb.com, Jesper Brouer , jakub.kicinski@netronome.com, m.xhonneux@gmail.com, dsahern@gmail.com, netdev , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Oct 2018 at 01:41, Daniel Borkmann wrote: > > On 10/05/2018 09:07 PM, Daniel Borkmann wrote: > > On 10/05/2018 09:02 PM, Song Liu wrote: > > [...] > >> BPF_CALL_x() has static already (before this patch). We should not > >> need change that > >> for all the BPF_CALL_?(). Joe's version looks better to me. > > > > My preference as well, thanks! > > ping, can someone send an updated patch? I will send a fresh version shortly.