Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3912302imm; Mon, 8 Oct 2018 11:34:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV60vYRIamD9hKGok+VeNbHoxBegBCwf6MK+OBZaC49K4C/eLPLiI39r+WizeDtLLuDI2Fq7w X-Received: by 2002:a62:1f03:: with SMTP id f3-v6mr26314170pff.168.1539023664538; Mon, 08 Oct 2018 11:34:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539023664; cv=none; d=google.com; s=arc-20160816; b=P9UjQ62OFQSkcvB298UHsc1xreG5fSmPleFlfj3B2BPy+T4dQu6cQ+fCWSWsq4tza6 rjOriq3XlXj//5tua3BlykCTMddENGgRSnq+ASledgWNsgq/DjmZttCfKfX1hgsRCXTy 7ExxmHIcAgThNHobguZVrjonEhJnoJ7IBRN87ullRVIBLMxUMTw1vJgd78QHlU3BTLat m8NIh0RwraB+AWtBWfQIxPPwaosP4QSe/5EYZsMXbd310eqHEuo8ygMor+ZoXtkddnqb UU7v1fELrLahHzXyc64eCTXPOEJp6JDdrtlsFOLWLGmb5mQGLQEZUaW2YsezqA2osBZS eAow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fk5x2NW3oqx4lrfFyFhe4QgtWLvUNhgFohcTBntmqrs=; b=hpq1jaw15JxdkCsd1UXYyoc2yllixX/omxn3hWA/Nc4YwJHCdK0ra7RXM2sU/bHM+7 EZTYgxPgfsIfrwXUxlrOr1lsIDlwmAa6fD/uITYL4mYE6nLckIAbEMFHhkyJibsW9hb9 hfYGcohBYxMHTT/VJFuG8yJCKBRDesQA4Df49dkoGr7dmdRO7MHqo2i0olAIsCCzTAKL G8PIRQ2yEfRbGcfzXZTlvSvcNj8iVtwttnZbmin4tKB41qe+Pq2xckkjRrnaya1iI64C Yvj0Ulcn/pzHP0V+UBrZwrInw6jvD4L2BLYO20FQau1c1fTnQsS7OJbzLX3SBQnTK733 sRIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mj88gPeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r13-v6si18383127pfb.43.2018.10.08.11.34.09; Mon, 08 Oct 2018 11:34:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mj88gPeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727226AbeJIBqh (ORCPT + 99 others); Mon, 8 Oct 2018 21:46:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:56934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbeJIBqh (ORCPT ); Mon, 8 Oct 2018 21:46:37 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 790A52145D; Mon, 8 Oct 2018 18:33:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539023615; bh=DP1O8OgbXQJEl0mQY3umTj/IX1qylcPDe1nYacozShw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mj88gPeUzPCsQlNtZhxxqAVbdg2y/eIhO+8ar8YL+iwYVHDWh5osKiwaD0fiMc10R /gooKmJ6wfjsYxhGs5P+UhbQzwANvCtE/23a6Pksk2q1yHM+GJCFsXCIfucpzc+ZJj FUXpmj5ywzs2VwJpfDcMw3587PHVUbB/RnPHji50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Anton Vasilyev , Sasha Levin Subject: [PATCH 4.4 006/113] uwb: hwa-rc: fix memory leak at probe Date: Mon, 8 Oct 2018 20:30:07 +0200 Message-Id: <20181008175531.171527299@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181008175530.864641368@linuxfoundation.org> References: <20181008175530.864641368@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Anton Vasilyev [ Upstream commit 11b71782c1d10d9bccc31825cf84291cd7588a1e ] hwarc_probe() allocates memory for hwarc, but does not free it if uwb_rc_add() or hwarc_get_version() fail. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/uwb/hwa-rc.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/uwb/hwa-rc.c +++ b/drivers/uwb/hwa-rc.c @@ -875,6 +875,7 @@ error_get_version: error_rc_add: usb_put_intf(iface); usb_put_dev(hwarc->usb_dev); + kfree(hwarc); error_alloc: uwb_rc_put(uwb_rc); error_rc_alloc: