Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3913005imm; Mon, 8 Oct 2018 11:35:06 -0700 (PDT) X-Google-Smtp-Source: ACcGV60LbTZQUhhewdLvacykR4eSKf2hGp+anhev+IjfAiCjAgGsUdsygEf2iWiBcChGK2ZRPtNz X-Received: by 2002:a17:902:9005:: with SMTP id a5-v6mr24996429plp.86.1539023706298; Mon, 08 Oct 2018 11:35:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539023706; cv=none; d=google.com; s=arc-20160816; b=tLccr0/cO1/UPzpnJuOXUDSovIFT/RzZb0XCne4/cGhCfwvngNusF/crzS4EVENEJU Cc6KpWKxYZyeKr3DenTugzSMdgZVO3w5nUkBhj8couHc8Fa2gJdj6h6ExGABzTusUiNe fC0e46aAX4rU89o66FfWiHDs5xD13o5+upTP1jcPUfvigPJVpiP6p/aQ6G4OjXvKrzxx RNZ8aVv3eaCg1rvVviUd+9T+RL/VH/IKb8JYYzEbSO07rpFbx8AhH5gaWeboCgFelWda /VY9UsS0czHTohzbAi0WLKcprPshN4plKRRrWpIDshrW961c/1OYyamw8NxBEVHckYkM YXmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4uXXxPO+eCD3N2MS0LRCEYArxVduzcsFOYmaOwFEWzw=; b=gDXFIOPTYfx4VD04arnVqBkNxnRaUczIj9tjJiuzWPrwDJRVXwHPQ6M1uk2xvy8BoZ A8iq6nRc5eMqsVD8dBBApQH61S6f6HohbDnxTmnfLatqNeEm6PBRD1i9STs+wV4g7k3+ ud2bwEgS6Dagrz161vS/aytonJpzZLAiQmjgTYYh8twzowGIcK+mvu5oVAleR8XKBjBs Bf4h9pmjA8EqqscgCUbvDZ2DcS/KBbhRSQrwphGTaAeAJf1SPRk95L2MK9WUTWyJ7AUh qaLZfNBUojokYt0MOiQi5L2GbVqGiIjaypbs9lkG+WLFOzVmkKKjKy9IZFV3x+gQAhL1 gugw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SVxINuue; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2-v6si20983040pln.270.2018.10.08.11.34.51; Mon, 08 Oct 2018 11:35:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SVxINuue; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727638AbeJIBrO (ORCPT + 99 others); Mon, 8 Oct 2018 21:47:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:58100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726568AbeJIBrN (ORCPT ); Mon, 8 Oct 2018 21:47:13 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 617892087D; Mon, 8 Oct 2018 18:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539023651; bh=LQIEHvda/E3TvQAso4zR2/9YwPEX2gIa/BIAn4oe0GM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SVxINuuePwcNGo22jk5QoDEyhtY0SZu82aIIXjG85et8oSXN04/f0e1OXzF6a0A5J bKYMCe5ck+mFggqlXYle/zkwdaZQyKbsBVwzijt0ctlugSvMEcBD/dDBOQKgd+89tO txm6LGeMvL7+GELauAUjxUv6Y63bXFRG4LtB3tIs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zhouyang Jia , Johannes Thumshirn , Manish Rangankar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.4 037/113] scsi: bnx2i: add error handling for ioremap_nocache Date: Mon, 8 Oct 2018 20:30:38 +0200 Message-Id: <20181008175532.637054788@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181008175530.864641368@linuxfoundation.org> References: <20181008175530.864641368@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyang Jia [ Upstream commit aa154ea885eb0c2407457ce9c1538d78c95456fa ] When ioremap_nocache fails, the lack of error-handling code may cause unexpected results. This patch adds error-handling code after calling ioremap_nocache. Signed-off-by: Zhouyang Jia Reviewed-by: Johannes Thumshirn Acked-by: Manish Rangankar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/bnx2i/bnx2i_hwi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c @@ -2742,6 +2742,8 @@ int bnx2i_map_ep_dbell_regs(struct bnx2i BNX2X_DOORBELL_PCI_BAR); reg_off = (1 << BNX2X_DB_SHIFT) * (cid_num & 0x1FFFF); ep->qp.ctx_base = ioremap_nocache(reg_base + reg_off, 4); + if (!ep->qp.ctx_base) + return -ENOMEM; goto arm_cq; }