Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp3926150imm; Mon, 8 Oct 2018 11:48:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV63NrAyhq1zOaSGrFT9ANJ61XZaaMOWYDDU1ZqF/dMIsDYpiMXVtw/unYwD8bvBrsQTMfxZt X-Received: by 2002:a62:2606:: with SMTP id m6-v6mr24037141pfm.104.1539024498697; Mon, 08 Oct 2018 11:48:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539024498; cv=none; d=google.com; s=arc-20160816; b=JA+2dMfD3O3fOuyxfhwtQcd40KxIBEmg89tqn4odZCgYzTE++aPLXA0gH6ciKYA18a P+cTuQjPoixrN4QqbRW77VOusP/DlJMzuzCXTU7Yf9Tnx3CsSfDp1ZTyQGH7qO1DP4ZI AkD8wzwfTbY90ruTdPc1AHOp9IPVuOAxPgufoy+1ngFE67ANvf8gQxqxm8EzeBDCGNR8 lP1d3FvzYMuCMAaNXplw46zY99P8uJR7CZvVjpxGr00hPy5CghLSAq7KePxiNXYYqITc m9e3pgSRgT1c6kJjgOBXVY0Z0xp299uhCYdV0jGF2vTKRfEnGRcqFmksg9rxevBCfyMW A1Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gz2hs3G5ceq7fX3HsPOucukDApElh31eHb8DlBY11E8=; b=SopcLYV9XpF1lF4MM6KGLBuxe1lbN1ecMhoqstHvlnaL6CZdC14BzlN1kd9irrSo9G VMFu+P3Q5lnKb3Udc5xeWjVItAPdNwVWkUL3pg/YVzfawSfVb0SaseMuLGCjZSiuURV7 YWi2jhb5P2rbN8tzI4p7TLfE/oosS56T2HlARheps8Mph68jK3UgU6XdZQqQBM2oEOoz 04ZfKYpJPUDt+UNPHevbMNP0+w+9oKEVOMX+VtGZkBezDmwBXiLQNa8t3s03FCE5Oq93 dSHUClBnZDuz00kACBtkGUXmAHCHJe1xUdjtbTu1sJYW4ifaIi/V2DPaTNkSawIdP40f YJTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sfKvjHX3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5-v6si17700522pgg.559.2018.10.08.11.48.03; Mon, 08 Oct 2018 11:48:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sfKvjHX3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731519AbeJICAy (ORCPT + 99 others); Mon, 8 Oct 2018 22:00:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:49746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728239AbeJICAx (ORCPT ); Mon, 8 Oct 2018 22:00:53 -0400 Received: from localhost (ip-213-127-77-176.ip.prioritytelecom.net [213.127.77.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7AE96204FD; Mon, 8 Oct 2018 18:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539024467; bh=gxUctPa8XgcIEbfQwXdRQQAEkVDqB2q+gB4TKrLDGVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sfKvjHX3n9aX+rqTVuE1SyNOpTLHdkLBcCS1rXTIZT+J1JKg1LNMSPQdF2rwi5Vr/ pCyLFKSZbEQLfEfJ4Q7/AvlZHA5jk1X8kUatdM/Gvof2RX95+/wMwyyxdYuyJi97qC y1SVHna6iWuRShZf7nok96p2PRAN6XBv093Y1iZ8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sabrina Dubroca , Stefano Brivio , "David S. Miller" , Sasha Levin Subject: [PATCH 4.18 049/168] selftests: pmtu: detect correct binary to ping ipv6 addresses Date: Mon, 8 Oct 2018 20:30:29 +0200 Message-Id: <20181008175621.919251665@linuxfoundation.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181008175620.043587728@linuxfoundation.org> References: <20181008175620.043587728@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sabrina Dubroca [ Upstream commit c81c7012e0c769b5704c2b07bd5224965e76fb70 ] Some systems don't have the ping6 binary anymore, and use ping for everything. Detect the absence of ping6 and try to use ping instead. Fixes: d1f1b9cbf34c ("selftests: net: Introduce first PMTU test") Signed-off-by: Sabrina Dubroca Acked-by: Stefano Brivio Signed-off-by: David S. Miller Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/net/pmtu.sh | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- a/tools/testing/selftests/net/pmtu.sh +++ b/tools/testing/selftests/net/pmtu.sh @@ -46,6 +46,9 @@ # Kselftest framework requirement - SKIP code is 4. ksft_skip=4 +# Some systems don't have a ping6 binary anymore +which ping6 > /dev/null 2>&1 && ping6=$(which ping6) || ping6=$(which ping) + tests=" pmtu_vti6_exception vti6: PMTU exceptions pmtu_vti4_exception vti4: PMTU exceptions @@ -274,7 +277,7 @@ test_pmtu_vti6_exception() { mtu "${ns_b}" veth_b 4000 mtu "${ns_a}" vti6_a 5000 mtu "${ns_b}" vti6_b 5000 - ${ns_a} ping6 -q -i 0.1 -w 2 -s 60000 ${vti6_b_addr} > /dev/null + ${ns_a} ${ping6} -q -i 0.1 -w 2 -s 60000 ${vti6_b_addr} > /dev/null # Check that exception was created if [ "$(route_get_dst_pmtu_from_exception "${ns_a}" ${vti6_b_addr})" = "" ]; then