Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4048079imm; Mon, 8 Oct 2018 14:03:10 -0700 (PDT) X-Google-Smtp-Source: ACcGV60F844uqWrQxR485LWbXF7yARFOins1Zvn0zIBLHMmPYeWF4HfEXfMdrhCpkfo2gwygNCc8 X-Received: by 2002:a63:c912:: with SMTP id o18-v6mr22533192pgg.331.1539032590683; Mon, 08 Oct 2018 14:03:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539032590; cv=none; d=google.com; s=arc-20160816; b=Jh3ZzChISYptvPBCsPC7WnywoRqhILI+GWrLyQPuc7dmZrsEFzr8gIxMo/W0CSbcVH zLmGZ7Ds14XBT4ViVnn7U/zxT/EXmJXZXb3fyyhdiXhK8FH83/9CBhioAj7CGHUwWuoA boQ05U10AiXwp5D3Hj8XiWwAcXcRg4h6cl9pwXQG/1/Orh7bC+BlMFz8hMitReu8D+yk WeIW7ItWcsDDlnKjo4+89y50QsRgl6Hqe1sIEr5tYY+NIEjafR1XrOHM5goLCGniTyWa e12NqW9Y4mB9Z4lovoNiqqCgaWkCqw8W513obXwm4xCvFWOZ89EeQl78S9tRZ7sy31nJ mvEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:openpgp:from:references:cc:to; bh=8koShDTrAEGYfiyr9mJ2vnRp40sSJqw9AQ9nvM1JD3U=; b=M3Ot0yhgABwv+d6YZNBW2vsw0xCnkBxN1ITCb9dwJJZNzlgP5yoJijFVF11jdjAqem uNz5Y0s3psYEfOZ7DPO41IW8LPqUVGbZ4QbyqhiqbBRubKSOBRE++E5t8Hu7N0ZwjxUI meB9Nr6RqiMxR9fTg2lFWad3mybHeWVdsKcizvAjXR4A5rb7QinMBL0A2q1c48V/drhW 7+76PAg3Mtk+DSAJdQQrqxac/0LuNx0qLeopG0f2ubEWRlm7T0y/FnsYtP04hqMVDzMA fRwyHs2TQvpmwBf/AFl7b6ezzm7Z/VgqKDslUhe4x2kxHWwn3dxSZCTmgtItwqpK6dAQ jhzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n11-v6si15668511pgv.260.2018.10.08.14.02.55; Mon, 08 Oct 2018 14:03:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726678AbeJIEQL (ORCPT + 99 others); Tue, 9 Oct 2018 00:16:11 -0400 Received: from gateway22.websitewelcome.com ([192.185.47.129]:23378 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725749AbeJIEQL (ORCPT ); Tue, 9 Oct 2018 00:16:11 -0400 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 99859D308 for ; Mon, 8 Oct 2018 16:02:31 -0500 (CDT) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 9cffgyHCdSjJA9cffgVWR5; Mon, 08 Oct 2018 16:02:31 -0500 X-Authority-Reason: nr=8 Received: from 174.206.93.92.rev.sfr.net ([92.93.206.174]:35400 helo=[192.168.43.69]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1g9cff-001Q2L-5d; Mon, 08 Oct 2018 16:02:31 -0500 To: Quentin Schulz Cc: Kishon Vijay Abraham I , "David S. Miller" , linux-kernel@vger.kernel.org References: <20181008180649.GA9152@embeddedor.com> <20181008205536.emefo2lddcuxl6sr@qschulz> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Subject: Re: [PATCH] phy: ocelot-serdes: fix out-of-bounds read Message-ID: <9c497948-b85e-7981-ce9a-4c862632715b@embeddedor.com> Date: Mon, 8 Oct 2018 23:02:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181008205536.emefo2lddcuxl6sr@qschulz> Content-Type: text/plain; charset=windows-1252 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 92.93.206.174 X-Source-L: No X-Exim-ID: 1g9cff-001Q2L-5d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174.206.93.92.rev.sfr.net ([192.168.43.69]) [92.93.206.174]:35400 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Quentin, On 10/8/18 10:55 PM, Quentin Schulz wrote: > Hi Gustavo, > > On Mon, Oct 08, 2018 at 08:06:49PM +0200, Gustavo A. R. Silva wrote: >> Currently, there is an out-of-bounds read on array ctrl->phys, >> once variable i reaches the maximum array size of SERDES_MAX >> in the for loop. >> >> Fix this by changing the condition in the for loop from >> i <= SERDES_MAX to i < SERDES_MAX. >> > > Thanks for the heads up. However, as defined today, SERDES_MAX is a > valid value so I need it in the iteration. There are two possible fixes > though: > Oh okay. I've got it. > Either we let all the for loops as `for (i = 0; i <= SERDES_MAX; i++)` > and define ctrl->phys as an array of size SERDES_MAX + 1. > > Or we modify the for loops as `for (i = 0; i < SERDES_MAX; i++)` and we > update SERDES_MAX in include/dt-bindings/phy/phy-ocelot-serdes.h to be > SERDES6G_MAX + 1. > I think this one is better. > As you wish! > I'll send v2 shortly. Thanks for the feedback. :) -- Gustavo