Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4194919imm;
        Mon, 8 Oct 2018 17:03:27 -0700 (PDT)
X-Google-Smtp-Source: ACcGV62FW6Jw804TM7D6wMg2Qji1o3dq2XlvQg0mQVLVCLsz5HH0O16MtEstCEvXybl15uXiMJYM
X-Received: by 2002:a17:902:4103:: with SMTP id e3-v6mr26112832pld.236.1539043407684;
        Mon, 08 Oct 2018 17:03:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539043407; cv=none;
        d=google.com; s=arc-20160816;
        b=nmVaUNW4cLxl5fVOFr7iH+Zpzuw77id3rSw3QsH2Oj3ZgJFBmG3QemqWuJ+WK/3hxu
         uCQHr2Dt8F8GEV6KnGCzrfIBKOWXC2dPs7M+1lHr7ag8epbUOrHQhDGp89d2lph8LZRu
         3WEzCwjmhzoS2VHfbTHFmAtfjtGbM+3aWFdU9TjP8JuatGH6TnD5tzgIdl7+C77VF8Sg
         PBoqolPZrvgh3t3ZDEwLqX8ZeJpHG0V57xstMwqxq5DXtcJiO0MNZfujSnw9QwrX84Y1
         bc/s+9/VEH6n1Qdm/tt8aKxw6/L0beFSVZvXqGTDUrycx5WdAKmKMez9Dj9gxxTYTHMA
         DKuw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=xfhoNMOZDmmyAzZ1nAK5n785uaeWlrIZhT1SMmNxC2s=;
        b=mmxC3uK0izZ4NrpVYLP/EUJ0Uq1CgKGDUGCMGdidE2S6/TXm5tQLfg/rpSrHVolShI
         nOPfsQz3Th+0m4brudAYVOnSaQDX62SvUPdE7siDvqtKGdnxqapIACQrP3hYcSXifiP2
         GUh1JfjBoehrjpvKmSEQ9WbUlGvIRARfrhUXBzJnvW6T1K42x7gYBP4EaFxw4EqS6s8i
         6w72bClLdtnQGvNLkMWv3ZZpZLzlwv/0pA/4BVgsOYY9p2+RFhOS4O66yRKCEO33CKA8
         bvwDdET8F9OhAbKokNoK2XmnMXEOOVsdD7MOsnPgskJw2SDuK3VhACH4GRK67ok8iTYv
         Kz/g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b="nE/1HXCi";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id t7-v6si12810739pfb.16.2018.10.08.17.03.13;
        Mon, 08 Oct 2018 17:03:27 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b="nE/1HXCi";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726664AbeJIHRB (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Tue, 9 Oct 2018 03:17:01 -0400
Received: from frisell.zx2c4.com ([192.95.5.64]:40547 "EHLO frisell.zx2c4.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725759AbeJIHRA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Oct 2018 03:17:00 -0400
Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 215f7c60;
        Tue, 9 Oct 2018 00:01:56 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version
        :references:in-reply-to:from:date:message-id:subject:to:cc
        :content-type; s=mail; bh=5in/RYU2U40tdxrJ1ovROPUS/yo=; b=nE/1HX
        Ci+RiM0J0Wg4TlNGb7coUZLx08RsY2o0L1EPhcSV3h2kaetFfGnVfYRYO5xb0ovH
        lst8UGk1M1uTkSTQqfV5ZBcCHu0D0cIZvYw8optxLPc3lsJIFdONl9PW+BMfnJvS
        L+KxPyKzMNb7VE834CxbzdEmJg4iGTayPTdJ/nGJZeTDS2MAy1azpA4LKbVLMWj4
        UrIoF/uBI/w8Rs2dFGS2UI1ns0GuHGMhG9vdZTmH0vsK2e0I2Qp8fmkcNqA50jtv
        uKjzfymrJAYjyLO3lAbDR08A6An4o3owCK+Wchnk6xtSI0nFbr+dm/rvJLA/8e3D
        obkStD7BUO95AqIw==
Received: by frisell.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id af354587 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO);
        Tue, 9 Oct 2018 00:01:55 +0000 (UTC)
Received: by mail-oi1-f177.google.com with SMTP id e17-v6so16852369oig.12;
        Mon, 08 Oct 2018 17:02:45 -0700 (PDT)
X-Gm-Message-State: ABuFfoiUI82ORPZDQ0qB8glViL31lnuN6/ATHWH0UwNzS96ex95623kI
        OvNlxHwr3dWbOeyToU0h+qffCXOSrABFazmivdc=
X-Received: by 2002:aca:f512:: with SMTP id t18-v6mr6095485oih.244.1539043364096;
 Mon, 08 Oct 2018 17:02:44 -0700 (PDT)
MIME-Version: 1.0
References: <20181006025709.4019-1-Jason@zx2c4.com> <20181006025709.4019-26-Jason@zx2c4.com>
 <20181008232059.GA164708@gmail.com>
In-Reply-To: <20181008232059.GA164708@gmail.com>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Tue, 9 Oct 2018 02:02:32 +0200
X-Gmail-Original-Message-ID: <CAHmME9qo+8JKL_J10UghiJjxQABA5meOg=TqgpfvbV=nPJx7Tg@mail.gmail.com>
Message-ID: <CAHmME9qo+8JKL_J10UghiJjxQABA5meOg=TqgpfvbV=nPJx7Tg@mail.gmail.com>
Subject: Re: [PATCH net-next v7 25/28] crypto: port Poly1305 to Zinc
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Netdev <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Samuel Neves <sneves@dei.uc.pt>,
        Andrew Lutomirski <luto@kernel.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Eric,

On Tue, Oct 9, 2018 at 1:21 AM Eric Biggers <ebiggers@kernel.org> wrote:
> This crashes on very short inputs.  crypto_poly1305_final() is missing:
>
>         if (dctx->rem_key_bytes)
>                 return -ENOKEY;

Good catch, thanks. Queued for v8.

Jason