Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Frieder Schrempf <frieder.schrempf@exceet.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC] usb: chipidea: Add minimal support for HSIC interface on
 i.MX6QDL
Thread-Topic: [RFC] usb: chipidea: Add minimal support for HSIC interface on
 i.MX6QDL
Thread-Index: AQHUXwsDLRUbQlbQbUi4BM689kvOEaUWHfPw
Date:   Tue, 9 Oct 2018 01:24:09 +0000
Message-ID: <VI1PR04MB5327D0F4AA27C5AED5C535388BE70@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <1539005352-10909-1-git-send-email-frieder.schrempf@exceet.de>
In-Reply-To: <1539005352-10909-1-git-send-email-frieder.schrempf@exceet.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 45216917-ab17-4ad1-a4a1-08d62d85ea09
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2018 01:24:09.7983
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4046
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> The topic has been discussed before: [1] And there is some implementation=
 in the
> vendor kernel: [2]
>=20
> It seems like two things need to be done:
>=20
> 1. Switch the pinmux of the strobe signal to use a pullup after
>    the core has been initialized.
> 2. Enable HSIC mode and HSIC clock
>=20
> This patch only implements these basics in a minimal approach.
> You need to have an additional pinmux setting "active" in the dt, that se=
ts the pullup.
>=20
> It was tested with the SMSC LAN9730 USB Ethernet adapter on the iMXceet S=
olo S
> board.
>=20

Thanks, I should do it earlier, I could not find a suitable board with HSIC=
 support at mainline kernel.
It is very kind that you could help on it and test function at real board. =
My suggestion is
follow all flows in Link [2] since we need to cover suspend/resume and remo=
te wakeup.=20

Peter

> [1]
> https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fpatc=
hwork.
> kernel.org%2Fpatch%2F3541771%2F&amp;data=3D02%7C01%7CPeter.Chen%40nx
> p.com%7Cea362518eae9440028aa08d62d22246b%7C686ea1d3bc2b4c6fa92cd99
> c5c301635%7C0%7C0%7C636746022015840824&amp;sdata=3DsHE2yZha9%2FhN
> SSBjXogDMtdflhNc2n9mNlUe9t8E1kY%3D&amp;reserved=3D0
> [2]
> https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fgit.f=
reescale
> .com%2Fgit%2Fcgit.cgi%2Fimx%2Flinux-
> imx.git%2Fcommit%2F%3Fid%3Dcf2d3ff6b217ef41f0e594daa9615e2&amp;data=3D0
> 2%7C01%7CPeter.Chen%40nxp.com%7Cea362518eae9440028aa08d62d22246b
> %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636746022015840824
> &amp;sdata=3DiDRlnA9liWua7UMHBcVdUlMkBP6MIG7KUpHIAwQbDA0%3D&amp;re
> served=3D0
>=20
> Signed-off-by: Frieder Schrempf <frieder.schrempf@exceet.de>
> ---
>  drivers/usb/chipidea/ci_hdrc_imx.c | 10 ++++++++++
> drivers/usb/chipidea/usbmisc_imx.c | 22 ++++++++++++++++++++++
>  2 files changed, 32 insertions(+)
>=20
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci=
_hdrc_imx.c
> index 19f5f5f..fef8bda 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -256,6 +256,7 @@ static int ci_hdrc_imx_probe(struct platform_device *=
pdev)
>  	const struct of_device_id *of_id;
>  	const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
>  	struct device_node *np =3D pdev->dev.of_node;
> +	struct pinctrl *pinctrl;
>=20
>  	of_id =3D of_match_device(ci_hdrc_imx_dt_ids, &pdev->dev);
>  	if (!of_id)
> @@ -331,6 +332,15 @@ static int ci_hdrc_imx_probe(struct platform_device =
*pdev)
>  		pm_runtime_enable(&pdev->dev);
>  	}
>=20
> +	pinctrl =3D devm_pinctrl_get(&pdev->dev);
> +	if (!IS_ERR(pinctrl)) {
> +		struct pinctrl_state *state;
> +
> +		state =3D pinctrl_lookup_state(pinctrl, "active");
> +		if (!IS_ERR(state))
> +			pinctrl_select_state(pinctrl, state);
> +	}
> +
>  	device_set_wakeup_capable(&pdev->dev, true);
>=20
>  	return 0;
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/us=
bmisc_imx.c
> index 34ad5bf..a6556c8 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -64,10 +64,16 @@
>  #define MX6_BM_OVER_CUR_DIS		BIT(7)
>  #define MX6_BM_OVER_CUR_POLARITY	BIT(8)
>  #define MX6_BM_WAKEUP_ENABLE		BIT(10)
> +#define MX6_BM_UTMI_ON_CLOCK		BIT(13)
>  #define MX6_BM_ID_WAKEUP		BIT(16)
>  #define MX6_BM_VBUS_WAKEUP		BIT(17)
>  #define MX6SX_BM_DPDM_WAKEUP_EN		BIT(29)
>  #define MX6_BM_WAKEUP_INTR		BIT(31)
> +
> +#define MX6_USB_HSIC_CTRL_OFFSET	0x10
> +#define MX6_BM_HSIC_CLK_ON		BIT(11)
> +#define MX6_BM_HSIC_EN			BIT(12)
> +
>  #define MX6_USB_OTG1_PHY_CTRL		0x18
>  /* For imx6dql, it is host-only controller, for later imx6, it is otg's =
*/
>  #define MX6_USB_OTG2_PHY_CTRL		0x1c
> @@ -351,6 +357,22 @@ static int usbmisc_imx6q_init(struct imx_usbmisc_dat=
a
> *data)
>  	writel(reg | MX6_BM_NON_BURST_SETTING,
>  			usbmisc->base + data->index * 4);
>=20
> +	/*
> +	 * Core 2 and 3 are host only and HSIC only,
> +	 * so we enable HSIC by default to make them usable
> +	 */
> +	if (data->index =3D=3D 2 || data->index =3D=3D 3) {
> +		reg =3D readl(usbmisc->base + data->index * 4);
> +		writel(reg | MX6_BM_UTMI_ON_CLOCK,
> +		       usbmisc->base + data->index * 4);
> +
> +		reg =3D readl(usbmisc->base + MX6_USB_HSIC_CTRL_OFFSET +
> +			    (data->index - 2) * 4);
> +		reg |=3D MX6_BM_HSIC_EN | MX6_BM_HSIC_CLK_ON;
> +		writel(reg, usbmisc->base + MX6_USB_HSIC_CTRL_OFFSET +
> +		       (data->index - 2) * 4);
> +	}
> +
>  	spin_unlock_irqrestore(&usbmisc->lock, flags);
>=20
>  	usbmisc_imx6q_set_wakeup(data, false);
> --
> 2.7.4