Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4423418imm; Mon, 8 Oct 2018 22:31:11 -0700 (PDT) X-Google-Smtp-Source: ACcGV616jTGXavgPdzN2hDFh3pMn5S26/UqitP/+5BYMbnVPjeB30kaT0vvIwHeIHjepCLqxUAET X-Received: by 2002:a62:2606:: with SMTP id m6-v6mr26004754pfm.104.1539063070994; Mon, 08 Oct 2018 22:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539063070; cv=none; d=google.com; s=arc-20160816; b=H7Z8dObvmnoP1qUw6wXalUKPeuHkJNmCjg1dW8XADP69OXfKpWq6fcIzuKTR8BYeCy F1/3OWXwISwDzhvV7pjq2JtNLNEQ4x041IO3tY451zi5tyxXdJF3x90Knrwi0zavr/dj y00UckquoWFimAZ5n3EiTP0utXsXCKnLemjudnyHNF7yiUi2dHwLXkVvJRoM18LwVB1n qUQ0EWNhQTs7qncoeIh8CJ2cdIedICxEDxx2qMpOGIujo2kG9CWRHqMmDFHTldtviaFb XKQ0c1ACMKikSNmoZEK951cXtkcHDPzmzr7Uu+CkpbbiWc0RvljKfMLBSlSTQC1a7o0v DX4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=JQsK2MpgAe4DGH9uj4e5z9Fj7v4aFOYbKhESvrSUr44=; b=G+7efHSf5yZ8O3Orfqh24QnWHWR7rEzkLi1a4318CRvvWKpmhQh2VhmMq6olX5DcW0 YGGqyz/NKIWEL/MBHTCP2Zyf00VqZSEWfBGc45vOSl9EU44MXdSXA53+VgWnaolFQ3lf DzsgW48WgNvd0GleL4QBswvEvvlyDwWVOClvTPpB3PcE1lShb+xGbLlzV4Ea+spoaCuE J0qwgyQ4rH2ibA1rYUF1GE3Wu6l0PkzpGShUokAJDMf69NEEvetmdfdzcU/ANMsyhd+K /18pzAOGHEXr18qqECGE/vCCQv5V36t4aZQVJGgpLgSjVwpcRRv8giGgKDatqfMjC0Vt 1PEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7-v6si17858191pgj.532.2018.10.08.22.30.56; Mon, 08 Oct 2018 22:31:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726617AbeJIMpL (ORCPT + 99 others); Tue, 9 Oct 2018 08:45:11 -0400 Received: from terminus.zytor.com ([198.137.202.136]:43049 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725823AbeJIMpL (ORCPT ); Tue, 9 Oct 2018 08:45:11 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id w995Tv3n909927 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 8 Oct 2018 22:29:57 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w995TvI8909924; Mon, 8 Oct 2018 22:29:57 -0700 Date: Mon, 8 Oct 2018 22:29:57 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Sanskriti Sharma Message-ID: Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, acme@redhat.com, joe.lawrence@redhat.com, sansharm@redhat.com, linux-kernel@vger.kernel.org, jolsa@kernel.org Reply-To: acme@redhat.com, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, sansharm@redhat.com, linux-kernel@vger.kernel.org, jolsa@kernel.org, joe.lawrence@redhat.com In-Reply-To: <1538490554-8161-3-git-send-email-sansharm@redhat.com> References: <1538490554-8161-3-git-send-email-sansharm@redhat.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf tools: Cleanup trace-event-info 'tdata' leak Git-Commit-ID: faedbf3fd19f2511a39397f76359e4cc6ee93072 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-0.7 required=5.0 tests=ALL_TRUSTED,BAYES_00, DATE_IN_FUTURE_48_96 autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: faedbf3fd19f2511a39397f76359e4cc6ee93072 Gitweb: https://git.kernel.org/tip/faedbf3fd19f2511a39397f76359e4cc6ee93072 Author: Sanskriti Sharma AuthorDate: Tue, 2 Oct 2018 10:29:11 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 8 Oct 2018 14:23:45 -0300 perf tools: Cleanup trace-event-info 'tdata' leak Free tracing_data structure in tracing_data_get() error paths. Fixes the following coverity complaint: Error: RESOURCE_LEAK (CWE-772): leaked_storage: Variable "tdata" going out of scope leaks the storage Signed-off-by: Sanskriti Sharma Reviewed-by: Jiri Olsa Cc: Joe Lawrence Link: http://lkml.kernel.org/r/1538490554-8161-3-git-send-email-sansharm@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/trace-event-info.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c index 7b0ca7cbb7de..8ad8e755127b 100644 --- a/tools/perf/util/trace-event-info.c +++ b/tools/perf/util/trace-event-info.c @@ -531,12 +531,14 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs, "/tmp/perf-XXXXXX"); if (!mkstemp(tdata->temp_file)) { pr_debug("Can't make temp file"); + free(tdata); return NULL; } temp_fd = open(tdata->temp_file, O_RDWR); if (temp_fd < 0) { pr_debug("Can't read '%s'", tdata->temp_file); + free(tdata); return NULL; }