Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Felipe Balbi <balbi@kernel.org>
To:     Anurag Kumar Vulisha <anuragku@xilinx.com>,
        Anurag Kumar Vulisha <anuragku@xilinx.com>,
        "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "v.anuragkumar\@gmail.com" <v.anuragkumar@gmail.com>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Thinh.Nguyen\@synopsys.com" <Thinh.Nguyen@synopsys.com>,
        Ajay Yugalkishore Pandey <APANDEY@xilinx.com>
Subject: RE: [PATCH v5 0/8] usb: dwc3: Fix broken BULK stream support to dwc3 gadget driver
In-Reply-To: <BL0PR02MB563373F068BC275BCB14DBE3A7E60@BL0PR02MB5633.namprd02.prod.outlook.com>
References: <1537021801-23896-1-git-send-email-anurag.kumar.vulisha@xilinx.com> <BL0PR02MB563373F068BC275BCB14DBE3A7E60@BL0PR02MB5633.namprd02.prod.outlook.com>
Date:   Tue, 09 Oct 2018 08:36:47 +0300
Message-ID: <871s8zptow.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


(no top-posting, please)

Hi,


Anurag Kumar Vulisha <anuragku@xilinx.com> writes:

> Hi Felipe,
>
> Please let us know if you have any suggestions / comments on this patch s=
eries.
> If you feel this patch series are okay, can we proceed with them?

I really don't like this dwc3-specific timer. The best way here would be
to add a timer on udc/core.c which can be reused by any udc. This would
mean, of course, teaching udc/core about streams and lettting it do part
of the handling.

Best

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlu8Pm8ACgkQzL64meEa
mQaqhA//ckgUXIdmIfoE4VgRkjG2wdD4R8YiV/7hWue04nGbuDF/hTaZ5R24xQDf
4vCfl0kHlj2HyQ2HaxvpniVLi2OY4Fpdxg9Bq+E9EgB81kEJATa7H7O+ieQzOG9x
A0Dznj9Fa6VfHGJQHwI/fndujxwzUtTd0aWcz7KnGlMjiHCd6e2lkFYgjtsfbcFu
ifuUcVHwLhiro4NuQStH3VjnrtgIYRP+N3s+kMC7UpS1JvKy7IsMZV8hpP8JO7dn
lB780TpweqAkODPWZ1AAvmfGouiJuc+6QYKI+S90tNzuQyOWmOn5g2Afkn9WQX9D
slXQO15Jxr/7mTnugkcXnF2dU+NswOwVEhtnEYjQlGH3ajSehrJJz6GvUgj8yUpx
XKlhhMwDXLxM/INrVXh6jIRQ3mMPXvLUvRfumX7FA6bTkrWdPXlEPlKtHsjWWJAh
Bz+09yrZIuJkakZ5QJMRWnVycR3+HEgT6dTySJtjT9VVxa/Iu/m0LFb59YkvdU8e
f4cCjpkQ7BIIR6VViAVtjErZ9UUgQO+Zi1vEVGMmQ6Ayx0xbmcPq7MIYSbZDcB6E
LOAGLd5vABZI12BiapPKnB0nIaqMrWdhZ2VlAun2lBtT16rWDjr588m3fK+lR1U/
l1Ye0mRUDpnoMgaxDizCwokPrA+oeHJk4O//b0iyV5RvPsBhnlw=
=g7TO
-----END PGP SIGNATURE-----
--=-=-=--