Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 9 Oct 2018 09:28:08 +0200
From:   Quentin Schulz <quentin.schulz@bootlin.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] phy: ocelot-serdes: fix out-of-bounds read
Message-ID: <20181009072808.5eynmktmkgjpi2ho@qschulz>
References: <cover.1539036280.git.gustavo@embeddedor.com>
 <30c1dcb4a8d3707238fcf0a996b9e0bf0a4a7bbc.1539036280.git.gustavo@embeddedor.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="b4ojgugveeianwqy"
Content-Disposition: inline
In-Reply-To: <30c1dcb4a8d3707238fcf0a996b9e0bf0a4a7bbc.1539036280.git.gustavo@embeddedor.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--b4ojgugveeianwqy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Gustavo,

On Tue, Oct 09, 2018 at 12:22:33AM +0200, Gustavo A. R. Silva wrote:
> Currently, there is an out-of-bounds read on array ctrl->phys,
> once variable i reaches the maximum array size of SERDES_MAX
> in the for loop.
>=20
> Fix this by changing the condition in the for loop from
> i <=3D SERDES_MAX to i < SERDES_MAX.
>=20

Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>

Thanks,
Quentin

--b4ojgugveeianwqy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEXeEYjDsJh38OoyMzhLiadT7g8aMFAlu8WIgACgkQhLiadT7g
8aPENQ//Yku5/atqMQnfPkL9gPlXcwqnKzdLPoqg8STNzSFCL+/Z19M/1EhIQWHG
DqY04THJUqXwNpFeFXeR3Ac1gsZ0juK71c6iDIveL81xuH6CFJyh3zX5iCr4NlBA
h/qpxXc6//3HmnpoEMLZj8LzSwGi2nsfYuXbxgEAbQ8TmTruSaIBYyj41h78uBXk
j3tWNYAZUXX/QkoKCK3S/UmhhM4wqc3vw9CiuUENAwWyq4uC0j+8xBYpMIzoyvWU
gBimIVlNGZx+FefedTmS1AUrXT92QAcaoaT7/g1T2BcnHY2J0kvZy1Wk/1botn5q
C5ywzft5xn7OxJ1WBeoXFz2oHFUA7+hehotqCfWcsJ8vWLQqxpJwzcaVFfo1OPik
taCbiaBdsLugVjr9PIRZ4+4f9sSWCxfNK8sxY6PrNC89hF+BKbGA+YKJgVuK7Y6C
K/s3tpl5uGcIHZ8nvQhWtEJnGnUEGau7GYkQLMfrgC96CRFcPcriRlcVL9M3cXfa
4Ey3NVT8X1p4v8EX7B6l1ItNB/Eo2FhnYY5j+rnxGZnj+UJh6qfUUhkwdxlr09rl
fI9Yx/jwUVdXxw/INJBRx9z6MLvZRPUsAGLfp42VFfj0is1DqKJyb0rRI+ydnwTo
G/n/DLxL6qrP6DF4WEJgqSgSPvgHTM/aZZEuv7I6Jx5eM9Re+w8=
=q13U
-----END PGP SIGNATURE-----

--b4ojgugveeianwqy--