Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181008114518.GA2475@AD01277334> <61b485f4-539b-0f25-cf3d-574ebb17197c@embeddedor.com>
In-Reply-To: <61b485f4-539b-0f25-cf3d-574ebb17197c@embeddedor.com>
From:   DaeSeok Youn <daeseok.youn@gmail.com>
Date:   Tue, 9 Oct 2018 16:31:59 +0900
Message-ID: <CAHb8M2A1OSs=WmDKwy9F8H4jkLheiM89yJgzj9NnWZ7xF8RSmA@mail.gmail.com>
Subject: Re: [PATCH] staging: erofs: adds a space around '*'
To:     gustavo@embeddedor.com
Cc:     Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        linux-erofs@lists.ozlabs.org, devel <devel@driverdev.osuosl.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018=EB=85=84 10=EC=9B=94 8=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 9:37, G=
ustavo A. R. Silva <gustavo@embeddedor.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=
=84=B1:
>
> Hi,
>
> On 10/8/18 1:45 PM, Daeseok Youn wrote:
> > fix checkpatch.pl error:
> > ERROR: need consistent spacing around '*' (ctx:WxV)
> > +                       memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> >
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> >  drivers/staging/erofs/unzip_vle_lz4.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/erofs/unzip_vle_lz4.c b/drivers/staging/er=
ofs/unzip_vle_lz4.c
> > index f5b665f..501cfe0 100644
> > --- a/drivers/staging/erofs/unzip_vle_lz4.c
> > +++ b/drivers/staging/erofs/unzip_vle_lz4.c
> > @@ -181,7 +181,7 @@ int z_erofs_vle_unzip_vmap(struct page **compressed=
_pages,
> >               for (i =3D 0; i < clusterpages; ++i) {
> >                       void *t =3D kmap_atomic(compressed_pages[i]);
> >
> > -                     memcpy(vin + PAGE_SIZE *i, t, PAGE_SIZE);
> > +                     memcpy(vin + PAGE_SIZE * i, t, PAGE_SIZE);
> >                       kunmap_atomic(t);
> >               }
> >       } else if (clusterpages =3D=3D 1)
> >
>
Hi Gustavo,

Thanks for letting me know the patch.
> This exact fix was applied to linux-next some days ago:
>
> commit ea0b2d429bd82ec152d286a0c026ebcaa4154ccc
yes, you're right.
>
> Make sure you are working from linux-next rather than from mainline.
I got the linux kernel source from the staging-next tree than
linux-next. I knew that the patches related to staging should be
merged into staging-tree first. But I didn't update the source tree to
get latest.
>
> See this link: https://www.kernel.org/doc/man-pages/linux-next.html
>
Thanks.
Regards,
Daeseok Youn.
> Thanks
> --
> Gustavo