Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4657983imm; Tue, 9 Oct 2018 03:14:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV62ANed6WqzFUzdgxwoIaednodC3Xc9OJrBuV89LsXT4RGWLL+k4aE7m7EvuHvNH7pmPlTAm X-Received: by 2002:a62:6f43:: with SMTP id k64-v6mr28455751pfc.87.1539080058755; Tue, 09 Oct 2018 03:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539080058; cv=none; d=google.com; s=arc-20160816; b=w+7SBz00oCsaCajZiRzL8jXBywbRuxUD2Kup4iMs9QgyMflJek0LpRVqnNylT5Rd6a Dld+7k5ZjfQB1NX/XKTxUYFDsGBncRBGdsTM0v5n4PWMerzW16TuwCIZHSX3x11DMV5f EJML6j3/p6CCSpLV8v6GFuo+IbORjFuuWaWyHnrLDzgAEz39bBlqx+Lkw/I4aU5Vmc6g XqRD1p8qC3RCw9ddgEfzrQVDaLj0jl/8clJ+Pw837d63UwKxscAalbcQRM3FYw8REYEb 7Qe2gPvVsBUyPfcwk7uFKKiMUpcUVrDPEZQNeo6OyNhYcC6/qk5mWDwaU8x8Z7XEi4So i4HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2xsRKZa1uKBHfwg4CzfLh8Ae3Yvsc3dg8c0uYfkL1M0=; b=sEGhjXe/y47M8EkVhMJlLA7FMknmJbEKgnCfHk4IK3IOwO9iAQQ+b+UWITQPDJ/JDR RAO7YcjpPTaUw6tVPIPnN0+XZ5EQjGcCUAvZDJUBrHGXZf95yas7d9fpu2cSJEKpm8wx LZ/QR/pb8PwzsNh0QhQZzU78hNdzYZhBiie9ATu0UeWlQ56kk4/hXHZS+uFxU4arY9bn 4sM6GWS/WjDdfYsbPYwJWObO/vhSqNvRbhUZYEpL+BIEyi2guQM/VVXh2tijiD7zeFD6 DlbYhSd5Z6XVsurWaXSPlKtIUddb3jXjN6z6LadE+wk8uFWQBV5NszUhRXeW46Hrr7Kd 4/CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HjhTot1Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u135-v6si24240300pfc.79.2018.10.09.03.14.03; Tue, 09 Oct 2018 03:14:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HjhTot1Q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbeJIR3k (ORCPT + 99 others); Tue, 9 Oct 2018 13:29:40 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52340 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbeJIR3k (ORCPT ); Tue, 9 Oct 2018 13:29:40 -0400 Received: by mail-wm1-f66.google.com with SMTP id 189-v6so1250492wmw.2 for ; Tue, 09 Oct 2018 03:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=2xsRKZa1uKBHfwg4CzfLh8Ae3Yvsc3dg8c0uYfkL1M0=; b=HjhTot1Q0SWekRGU6jmnrr23jiE92siqk3YupJ9EFsya57Gdl4/FJyeLOG6IJ8V+vL UIRKi6EvdeSpikC28kMKfftCBQ0Ad23rT9N2AeSbuWNwwAg9e34+0ePvm33fHkVszjRJ Na74OuwgXENPZRFQ0esILAqPTaQmo6t1wJf9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=2xsRKZa1uKBHfwg4CzfLh8Ae3Yvsc3dg8c0uYfkL1M0=; b=odjmX/+XlPiiILFiaAJ0Ia++u5mRe695/KI7TdSESOjPZJVKzi5HO2C53liwToIO1V jWM+3NUiUENE7z7q6YVF7IaeTsI/ThVcD5m5acDcqDQu6yy59eKtVWfO4XYMqhZ3/417 i2sm+HogvQFSC7cLMwLJEP6gKIiOEWzv810y3hkZd64kAweD7SvnnHQMYHssbXOYoUB2 I12xA9CiFgweyqDPUC8xHehXn9J0Za2pJB2Zg9CI0eNLh894P0lxsApoiWGhrJLv52Lm QO2+obTNKo6l729NJWkPy3LdsrINUQde8rxkufLPdQLPAenErHkrMkDqAKco/+eAeKEE NayA== X-Gm-Message-State: ABuFfoi6tBm9gxoqlaJwp+g60IEbN8n+EXA9wuF6233gKr7q3EAPw7st uWMNpRduwoaP+5uB06MODzds5g== X-Received: by 2002:a1c:d750:: with SMTP id o77-v6mr1348470wmg.110.1539080007207; Tue, 09 Oct 2018 03:13:27 -0700 (PDT) Received: from dell ([2.27.167.111]) by smtp.gmail.com with ESMTPSA id 78-v6sm920779wma.38.2018.10.09.03.13.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Oct 2018 03:13:26 -0700 (PDT) Date: Tue, 9 Oct 2018 11:13:24 +0100 From: Lee Jones To: Emil Karlson Cc: Emil Renner Berthing , Neil Armstrong , Stefan Adolfsson , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: cros-ec: copy the whole event when msg->version is 0 Message-ID: <20181009101324.GL4939@dell> References: <20180927092427.507-1-jekarlson@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180927092427.507-1-jekarlson@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Sep 2018, Emil Karlson wrote: > Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events > be truncated on many chromebooks so that Left and Right keys on Column 12 were > always 0. This commit fixes the issue by restoring the old semantics when the > protocol version is 0. > --- > drivers/platform/chrome/cros_ec_proto.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Once you guys have all reviewed, agreed and tested the patches, can you please send a final version with all of the Acks pre-collected as a separate (not threaded/attached to this thread) submission please? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog