Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4718577imm; Tue, 9 Oct 2018 04:18:14 -0700 (PDT) X-Google-Smtp-Source: ACcGV63j1Kww1wV+5FL9o3dkCT+4nh7Hp/aAa03YJ66Lm9obzgsAIgn/DD/1Ln83vY+dOSpnlLX7 X-Received: by 2002:a63:f210:: with SMTP id v16-v6mr4603632pgh.371.1539083894319; Tue, 09 Oct 2018 04:18:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539083894; cv=none; d=google.com; s=arc-20160816; b=z6bjOqmDDtGlutla2ZfDHI++QEKmEaAscR/1XSFA7Kz7+VT8XpOmPEDb0P/aCMK5Bg BEZBgLIuL66ee8YFytIyv7xEKKOdd8nyfagAPzEYsWIY7Ajz+oOgWcr3mSSvVp9seAcC 6jZrrJRLly6VeOlp0dw4BLs0WgZGm8eIRswRYikq8+eENv/vWBQeG/trK0O6OzwANycy XlVyonZ2taHDri/VRR4xnO0Y2UTFAqzcgJkOD6HLEee+AL26qgYGF2xzq2n5Ci99JgRm nHPSMR3jWkkAg5IZatlTFynk/KEhSrGqZJer2yF8Y+n1DjiI7nq8rCWamHS/TQaVWbH5 K9jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=obBBG+/vjhkx2sjBc8D/J/RQKkavutEZvS8nBnwz9NQ=; b=e2p/Ugm+yZ0hPm1Ap3uBLfPDGNpIB+Te1yCrsh0/1x1QmqmHvnrwAFa5ZmLg0lMnU9 lEAVIFl01PD/ZKbEm3fiwbOoTfHO3mJYSY4eXgk0ayUVyrPdOdclc0C4VVHsqjngMcnE MRkgm032e9zmwMalgmb96ynJ9gR4+N71ikZaI8JX3Qy7avjQNmD5MoYwvzJ03vvCguin KsG2uBiayomYZt37DJxpr/ABfsScTpZXDKDjhLDWbzxVXeuCBUkrf6/+TEJ/jFmO/fAy RKEz4jexws+cYNcFvXd+7VRP35g5SRqkZbunx881m/HUkOAYxOoHyTGZqpwUPyVRkg9j 4G8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=ZY3vPO1P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u7-v6si19992433pgj.443.2018.10.09.04.17.59; Tue, 09 Oct 2018 04:18:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=ZY3vPO1P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbeJISda (ORCPT + 99 others); Tue, 9 Oct 2018 14:33:30 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36426 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727470AbeJISal (ORCPT ); Tue, 9 Oct 2018 14:30:41 -0400 Received: by mail-pl1-f195.google.com with SMTP id y11-v6so671537plt.3 for ; Tue, 09 Oct 2018 04:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=obBBG+/vjhkx2sjBc8D/J/RQKkavutEZvS8nBnwz9NQ=; b=ZY3vPO1P9XcgjiE8poykd+e3chkQOCCFPcPXCkQr2j30j+1ZfPxRmc5WqXkGGn06Yr P0Ab/EAxMHoZv7qFkpxoS1uxs+g9gRWYGKfDxVVlRy3V5Psm7FVB2q44cyJyWFbXtDCe PUgn0FVLnl25OqU6V5+Sz8LZb75THbtKKrbrffsusgs6NcsTXf7XooDIgfAmpPzA45lV 864H5J3HA1IDS7MjtcdpaKaTPsSNgah93EExoF0t0W8XtNg+kz/lMnU6N7hsXYh72q1p kQI4ztaJCTDTgCO5mX/ThaK9MCPB6o7ggzp7ZvbTcDz0fLUDlcZ+1oKOS5VrrQqQdfEP 8vJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=obBBG+/vjhkx2sjBc8D/J/RQKkavutEZvS8nBnwz9NQ=; b=KpUFRT92q4w71xp+jUds+NGfOx+iyhkrfLauheWqLKMAH8toRgx45l9WQwTG00ppZa OB6f65BZnt3hPOUAgiO783GYBzAv9/t7yrUwQpY3ms7PAkI0zYxBfJNu4nbEVMLpkCEr wLJzHES4GBNPeaBYviE/y7HavVQW4F1ToAqTGEXF6CTdADfXvuzakKAm7DLRn3YbU+oL kkcuDs25uGDuzA+fyBqtZVEYcTOUpwTKlTT2a4tABGs01F5jnqitVin4oI7ottjHL3jK hSUWTUTVnF6GV17H71+4tnMNkKhFxMT+GXFutFgFZCJ5a3ilcKCrddeg7TR0A4rRDIAQ LNrA== X-Gm-Message-State: ABuFfoiob68GOG/WipgbH8ygbUQJ8zZ1CxzzXmBxuXxwE9Cp9aq4CeVq 2MFQiWcpFnPYFXs70H6Hoko5yA== X-Received: by 2002:a17:902:6a8b:: with SMTP id n11-v6mr27620538plk.16.1539083655085; Tue, 09 Oct 2018 04:14:15 -0700 (PDT) Received: from skyninja.hgst.com (rap-us.hgst.com. [199.255.44.250]) by smtp.gmail.com with ESMTPSA id p1-v6sm25342380pff.128.2018.10.09.04.14.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Oct 2018 04:14:13 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Holmberg , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 18/45] lightnvm: pblk: remove unused parameters in pblk_up_rq Date: Tue, 9 Oct 2018 13:11:48 +0200 Message-Id: <20181009111215.7653-19-mb@lightnvm.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181009111215.7653-1-mb@lightnvm.io> References: <20181009111215.7653-1-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Holmberg The parameters nr_ppas and ppa_list are not used, so remove them. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 3 +-- drivers/lightnvm/pblk-write.c | 5 ++--- drivers/lightnvm/pblk.h | 3 +-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index e1207a4f9d54..bb1a7cc24cbb 100644 --- a/drivers/lightnvm/pblk-core.c +++ b/drivers/lightnvm/pblk-core.c @@ -1929,8 +1929,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas) up(&rlun->wr_sem); } -void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, - unsigned long *lun_bitmap) +void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap) { struct nvm_tgt_dev *dev = pblk->dev; struct nvm_geo *geo = &dev->geo; diff --git a/drivers/lightnvm/pblk-write.c b/drivers/lightnvm/pblk-write.c index c20bb7f6d703..cd579b440b56 100644 --- a/drivers/lightnvm/pblk-write.c +++ b/drivers/lightnvm/pblk-write.c @@ -81,8 +81,7 @@ static void pblk_complete_write(struct pblk *pblk, struct nvm_rq *rqd, #ifdef CONFIG_NVM_PBLK_DEBUG atomic_long_sub(c_ctx->nr_valid, &pblk->inflight_writes); #endif - - pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap); + pblk_up_rq(pblk, c_ctx->lun_bitmap); pos = pblk_rb_sync_init(&pblk->rwb, &flags); if (pos == c_ctx->sentry) { @@ -215,7 +214,7 @@ static void pblk_submit_rec(struct work_struct *work) pblk_map_remaining(pblk, ppa_list); pblk_queue_resubmit(pblk, c_ctx); - pblk_up_rq(pblk, rqd->ppa_list, rqd->nr_ppas, c_ctx->lun_bitmap); + pblk_up_rq(pblk, c_ctx->lun_bitmap); if (c_ctx->nr_padded) pblk_bio_free_pages(pblk, rqd->bio, c_ctx->nr_valid, c_ctx->nr_padded); diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h index 9068b158de22..0ca67e8f99d5 100644 --- a/drivers/lightnvm/pblk.h +++ b/drivers/lightnvm/pblk.h @@ -827,8 +827,7 @@ void pblk_up_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas); void pblk_down_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, unsigned long *lun_bitmap); void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas); -void pblk_up_rq(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas, - unsigned long *lun_bitmap); +void pblk_up_rq(struct pblk *pblk, unsigned long *lun_bitmap); int pblk_bio_add_pages(struct pblk *pblk, struct bio *bio, gfp_t flags, int nr_pages); void pblk_bio_free_pages(struct pblk *pblk, struct bio *bio, int off, -- 2.17.1