Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp4865804imm; Tue, 9 Oct 2018 06:28:57 -0700 (PDT) X-Google-Smtp-Source: ACcGV61veyK6vR9zpUyBOa0t22rq9klJBS6NFISVGSjrOlqv3EVG/Zj1wdFlmkbMPL3UC5F0gODV X-Received: by 2002:a17:902:5602:: with SMTP id h2-v6mr28680239pli.220.1539091737212; Tue, 09 Oct 2018 06:28:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539091737; cv=none; d=google.com; s=arc-20160816; b=FqYkWQg5raD1Tl2tI0jKZ4g8pAxYhPSWVQSYoRfzZJmjwSyI7kuPfmIL8dGUNk2UuP pHRuQo101ONd3Mm/HNpyev8sKWzcjd/61MiAcoBwVNtVSiQMhKB2OuKQcQWaMHA3Jgnf cwbZUf3N0qjvuiTX5q6Uu+ugfmWeE3grrkUk2WnQazApxemBtGlXIlPC2cAtDi2qUwx7 K4Hp6RtvOtnPae9kHiOR8za662mEzXqB0hngUhMQzei1LvCTVI/PofnjHStabD7OlCN7 GstdwDr6jbEOI3gh1B6xIG17TpPxA4GKl80VFWpT1/2TJtluk4Soyh/O+EjD/w2FXWII 0Xfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2smE7t1ubnM/aBYiGbsyFVtZBSQMbwLYlNYKOPwJFGE=; b=gDurTxNRiLgYPX16WZv44+PQx1zN23kKFxmYYh6jlXNn3GSve/G6won8zqJG58Vr1v ARy2G6mQ2vowm48I4CPcxQacVqY5jtpmrpmhyelJbB096K283YlC9gflnewGWiRok/xq p3tyNExUnCDLiUSeVcL2sx123TTKsZPgqeju7DWVTe5u68mq1ZPw6j6dFTQAdeFSikte YjhtQK8Yewub0pmU4yFI/cxCvSfwS2NjpAz3R5glF6ue80QTh3IRx3TYrhSMwUvNSVmw IoevJcsoIaBjudbR8wkKgTTd75erXWA97/LpbQKMMVUxp02QpY9rurQ2nUpHB9vBLWXo HY0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Ad4Bp8Y4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x16-v6si19916681pgh.41.2018.10.09.06.28.42; Tue, 09 Oct 2018 06:28:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Ad4Bp8Y4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727753AbeJIUnW (ORCPT + 99 others); Tue, 9 Oct 2018 16:43:22 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49968 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727705AbeJIUnU (ORCPT ); Tue, 9 Oct 2018 16:43:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2smE7t1ubnM/aBYiGbsyFVtZBSQMbwLYlNYKOPwJFGE=; b=Ad4Bp8Y4dt+Sx1b+QODbLDE7jW qp3pnjRMZpzX4bSQV88DBJK7v7Lgn0m5NOQfgSEZCvvITTzqoNr+CddsojnVnWlmEsB32lIH4sHzz V24jwBHBDcpZ5eRtcvXvY0jubjpjqEwHaAILEnL8H+jHXN1JXpjhByXksdT2zV9z9X70sbeIkKtb+ mrUqpNwE3WbmPAOCLbhFHzWzP/JMJfpERrXPmznPR27oG3IOkfCR8U+dQDnvwDfUZiebEnI+OIUVJ XbQr7VAN3MCoQX4trkMweV2hHV8F62mxD9M+2yo+pc5s+DuTf0wB5b/EjlCp25EVPHcySO4Rh14hn ze/6Lmog==; Received: from clnet-p19-102.ikbnet.co.at ([83.175.77.102] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1g9s1W-0001TF-8H; Tue, 09 Oct 2018 13:26:06 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 25/33] cxl: drop the dma_set_mask callback from vphb Date: Tue, 9 Oct 2018 15:24:52 +0200 Message-Id: <20181009132500.17643-26-hch@lst.de> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181009132500.17643-1-hch@lst.de> References: <20181009132500.17643-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The CXL code never even looks at the dma mask, so there is no good reason for this sanity check. Remove it because it gets in the way of the dma ops refactoring. Signed-off-by: Christoph Hellwig --- drivers/misc/cxl/vphb.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c index 7908633d9204..49da2f744bbf 100644 --- a/drivers/misc/cxl/vphb.c +++ b/drivers/misc/cxl/vphb.c @@ -11,17 +11,6 @@ #include #include "cxl.h" -static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask) -{ - if (dma_mask < DMA_BIT_MASK(64)) { - pr_info("%s only 64bit DMA supported on CXL", __func__); - return -EIO; - } - - *(pdev->dev.dma_mask) = dma_mask; - return 0; -} - static int cxl_pci_probe_mode(struct pci_bus *bus) { return PCI_PROBE_NORMAL; @@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops = .reset_secondary_bus = cxl_pci_reset_secondary_bus, .setup_msi_irqs = cxl_setup_msi_irqs, .teardown_msi_irqs = cxl_teardown_msi_irqs, - .dma_set_mask = cxl_dma_set_mask, }; int cxl_pci_vphb_add(struct cxl_afu *afu) -- 2.19.0