Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 0/4] Various cleanup + Mic Fix
To:     Connor McAdams <conmanx360@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Alastair Bridgewater <alastair.bridgewater@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <1539027601-20910-1-git-send-email-conmanx360@gmail.com>
From:   Takashi Sakamoto <o-takashi@sakamocchi.jp>
Message-ID: <2ded9b74-4140-c0b9-b628-42811284f403@sakamocchi.jp>
Date:   Tue, 9 Oct 2018 23:15:33 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1539027601-20910-1-git-send-email-conmanx360@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018年10月09日 04:39, Connor McAdams wrote:
> This patch set fixes the microphone inconsistency issue, which means
> the microphone now works all the time on all of the cards I've tested
> (ZxR, Z, AE-5), along with the input effects.
> 
> It also includes changes suggested by Takashi Sakamoto, I believe I did
> what he asked properly, but if I messed it up I'm sure you guys will
> let me know.
> 
> This should finish up most of the ca0132 work, with all inputs and
> outputs working on the desktop cards.
> 
> Connor McAdams (4):
>    ALSA: hda/ca0132 - Fix microphone inconsistency issues
>    ALSA: hda/ca0132 - Clean up patch_ca0132()
>    ALSA: hda/ca0132 - Add error checking in ca0132_build_controls()
>    ALSA: hda/ca0132 - Fix input effect controls for desktop cards
> 
>   sound/pci/hda/patch_ca0132.c | 75 +++++++++++++++++++++++++++++++-------------
>   1 file changed, 54 insertions(+), 21 deletions(-)

Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>


Thanks

Takashi Sakamoto