Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5112728imm; Tue, 9 Oct 2018 09:51:33 -0700 (PDT) X-Google-Smtp-Source: ACcGV60ZFfqkWIWju5ceaolVeYcPFo7Y4tb7ZfTqYb5lTwYDdXqKX50MqovROQPUOwvyZXFB6vhy X-Received: by 2002:a63:c746:: with SMTP id v6-v6mr26846713pgg.108.1539103893239; Tue, 09 Oct 2018 09:51:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539103893; cv=none; d=google.com; s=arc-20160816; b=WntlNGe8KcTAk2Oo04o9S7sm1W2peeyKlL3JQEWBISJxOKoBBx+3XAvpJ+dsKIBtgR lAEu3T6eRurDUEaSOmRdrx1cxXtjl895OMnoYd2TMg1w2sIRb5ZLx3iLjAPd5a8N+BSt 5sdYf4+gFZuYL5FCF/lYbE4k9n1RotjLnTUGk689JoFAq7zkkohVL5V3fjpKYzL3cTG+ apUX/2Tw4LUKY4ApsP4cGOV6HukzbZGL+/NP6tlo47ga3MASe1v8QlFmwqWKzRK2O+nw t6Uvfjq4aIqWpkdv9CshC/Ak4+MT9H3VjxuEvFt9//LSw8AYRRqFOsKBAo3W+r+foTMQ h9wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:organization; bh=IqhNPPfN/1ClooWbrmeznTBztgj43KWNvpz1K4jBf2U=; b=SenDgM4qijMMT7OJxPAzEvrmoa4I8SJIga3/YF3wZiZqQsCG0cBHeMKU+Vb4OdvzDD nPvhUyxFSso9LjXmAeHD8MV67dlJXBf9Av8/5vbocJvqtQ+xTdyY/4+4Ubsq89RPmGGK S+8NsGxs9Jw3Q+Sl9JSl47Qr6X/b2CzB+z/NRTG8kFa5SdOL+3JmBhvJfdTLNxsVgprF aq6/InQnmQHFSBPlY6prJ1pxAAlkuI7nguadmBnfqLbKLKK6snc46hIsvz7TPPHs8xEq NGNKdMTtN5927AxkxtU11Jn06cPSQIvwUUkx1vI0aWAEJzqN8w/zSfHCcXraruERTdI9 Yncw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n84-v6si19119486pfg.127.2018.10.09.09.51.18; Tue, 09 Oct 2018 09:51:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727620AbeJJAG7 (ORCPT + 99 others); Tue, 9 Oct 2018 20:06:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726995AbeJJAG7 (ORCPT ); Tue, 9 Oct 2018 20:06:59 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E3BF356E8; Tue, 9 Oct 2018 16:49:08 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id A412B1778F; Tue, 9 Oct 2018 16:49:06 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 18/22] KEYS: asym_tpm: Implement tpm_unbind [ver #2] From: David Howells To: jmorris@namei.org Cc: Denis Kenzior , James Morris , Marcel Holtmann , Marcel Holtmann , dhowells@redhat.com, denkenz@gmail.com, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 09 Oct 2018 17:49:05 +0100 Message-ID: <153910374590.12141.16983394369161634140.stgit@warthog.procyon.org.uk> In-Reply-To: <153910360263.12141.6032694262361399627.stgit@warthog.procyon.org.uk> References: <153910360263.12141.6032694262361399627.stgit@warthog.procyon.org.uk> User-Agent: StGit/unknown-version MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 09 Oct 2018 16:49:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Kenzior Signed-off-by: Denis Kenzior Reviewed-by: James Morris Signed-off-by: David Howells Tested-by: Marcel Holtmann Reviewed-by: Marcel Holtmann --- crypto/asymmetric_keys/asym_tpm.c | 82 +++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/crypto/asymmetric_keys/asym_tpm.c b/crypto/asymmetric_keys/asym_tpm.c index 6a2d33014ecc..e893b5212222 100644 --- a/crypto/asymmetric_keys/asym_tpm.c +++ b/crypto/asymmetric_keys/asym_tpm.c @@ -18,8 +18,10 @@ #define TPM_ORD_FLUSHSPECIFIC 186 #define TPM_ORD_LOADKEY2 65 +#define TPM_ORD_UNBIND 30 #define TPM_LOADKEY2_SIZE 59 #define TPM_FLUSHSPECIFIC_SIZE 18 +#define TPM_UNBIND_SIZE 63 #define TPM_RT_KEY 0x00000001 @@ -106,6 +108,86 @@ static int tpm_flushspecific(struct tpm_buf *tb, uint32_t handle) return trusted_tpm_send(tb->data, MAX_BUF_SIZE); } +/* + * Decrypt a blob provided by userspace using a specific key handle. + * The handle is a well known handle or previously loaded by e.g. LoadKey2 + */ +static int tpm_unbind(struct tpm_buf *tb, + uint32_t keyhandle, unsigned char *keyauth, + const unsigned char *blob, uint32_t bloblen, + void *out, uint32_t outlen) +{ + unsigned char nonceodd[TPM_NONCE_SIZE]; + unsigned char enonce[TPM_NONCE_SIZE]; + unsigned char authdata[SHA1_DIGEST_SIZE]; + uint32_t authhandle = 0; + unsigned char cont = 0; + uint32_t ordinal; + uint32_t datalen; + int ret; + + ordinal = htonl(TPM_ORD_UNBIND); + datalen = htonl(bloblen); + + /* session for loading the key */ + ret = oiap(tb, &authhandle, enonce); + if (ret < 0) { + pr_info("oiap failed (%d)\n", ret); + return ret; + } + + /* generate odd nonce */ + ret = tpm_get_random(NULL, nonceodd, TPM_NONCE_SIZE); + if (ret < 0) { + pr_info("tpm_get_random failed (%d)\n", ret); + return ret; + } + + /* calculate authorization HMAC value */ + ret = TSS_authhmac(authdata, keyauth, SHA1_DIGEST_SIZE, enonce, + nonceodd, cont, sizeof(uint32_t), &ordinal, + sizeof(uint32_t), &datalen, + bloblen, blob, 0, 0); + if (ret < 0) + return ret; + + /* build the request buffer */ + INIT_BUF(tb); + store16(tb, TPM_TAG_RQU_AUTH1_COMMAND); + store32(tb, TPM_UNBIND_SIZE + bloblen); + store32(tb, TPM_ORD_UNBIND); + store32(tb, keyhandle); + store32(tb, bloblen); + storebytes(tb, blob, bloblen); + store32(tb, authhandle); + storebytes(tb, nonceodd, TPM_NONCE_SIZE); + store8(tb, cont); + storebytes(tb, authdata, SHA1_DIGEST_SIZE); + + ret = trusted_tpm_send(tb->data, MAX_BUF_SIZE); + if (ret < 0) { + pr_info("authhmac failed (%d)\n", ret); + return ret; + } + + datalen = LOAD32(tb->data, TPM_DATA_OFFSET); + + ret = TSS_checkhmac1(tb->data, ordinal, nonceodd, + keyauth, SHA1_DIGEST_SIZE, + sizeof(uint32_t), TPM_DATA_OFFSET, + datalen, TPM_DATA_OFFSET + sizeof(uint32_t), + 0, 0); + if (ret < 0) { + pr_info("TSS_checkhmac1 failed (%d)\n", ret); + return ret; + } + + memcpy(out, tb->data + TPM_DATA_OFFSET + sizeof(uint32_t), + min(outlen, datalen)); + + return datalen; +} + /* * Maximum buffer size for the BER/DER encoded public key. The public key * is of the form SEQUENCE { INTEGER n, INTEGER e } where n is a maximum 2048