Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp5239391imm; Tue, 9 Oct 2018 11:49:19 -0700 (PDT) X-Google-Smtp-Source: ACcGV60G+TP0CmcS+5oqfH1ikSlBxD2LA+SxMp4zYAhX0qcRypx0Wa8RSqNntjuKCKi5n4RLv/a1 X-Received: by 2002:a17:902:509:: with SMTP id 9-v6mr30124451plf.155.1539110959852; Tue, 09 Oct 2018 11:49:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539110959; cv=none; d=google.com; s=arc-20160816; b=yWxSU5Ks1QF0TZmwahW/Jl59qVSmUbRM2YKAm0ZBr2bm5ilrKdck8GMdeZ/dLFoJFD hJejy8jNfKLLFBxUlJAHvlrXzwF7kKm+Bmj7vbU5o/LdbN/LXPgC8l3wUdQ4BmImO7WU gVUwKzzywQ1ity1AFnVImRtjT3PgAMHAruB16MssgKsuvu///x+QeHrfchR47y0Tzvjx p4ozQTuvvCLoJr4bwUNOJGsfjBHJCHvMeIMMOeJ7nyxvZNlShmq0f/w5CKq7dqz4FvHZ uN1bU6xWOKHH4a+GDy3RxpSuJUCGqAVK4/VYS8rbAiIDTOBBJ4PmJfcJGw8BYSYmflYf M9kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xqbsKb6+MsTOYxvFNkRY6HKryVHEiHLbzY5smiU/q9o=; b=zw/3U912p7V69kaLZXrx32nXFp9wxJBQ/rCYzSBNy1qLg58dxtSJIUxI1AbTEMgjsR Sif0ZLKZ91QoOd1MZwQ+45Jcus/nVrMfSYKpXyF2vxyof4cBxjXdPq8AdkzLkFEUQWLg /SvlBOP0Z6dgcMOCFOFWmt4R6lOkOZW3EINSpseizLSN6ZhBeyYmgb26M/3t+c9zbXxk /OSJ5wGJtiWyp/DeUi5LHClNrqMZp1wFoz7kDCBa4Wrkax7mxeuQSdb+v3QIXA6tvXKt XbkYTveWQ6bRARQgy1eg9n2KcdwK6tVix0grr8wM7hgBkKqaNQZLpqzZnXaTTXgkKv88 Mhxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=2JpSxkRR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10-v6si16057822pgm.374.2018.10.09.11.49.04; Tue, 09 Oct 2018 11:49:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=2JpSxkRR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbeJJCGi (ORCPT + 99 others); Tue, 9 Oct 2018 22:06:38 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:38324 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbeJJCGi (ORCPT ); Tue, 9 Oct 2018 22:06:38 -0400 Received: by mail-yb1-f194.google.com with SMTP id e190-v6so1105314ybb.5 for ; Tue, 09 Oct 2018 11:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xqbsKb6+MsTOYxvFNkRY6HKryVHEiHLbzY5smiU/q9o=; b=2JpSxkRR4M31hSqYhIRpOAxAMei/UCRotaZiDLuYmqn1wzDkrYi0oaTAYG0Sma9CJP rrCe43lMHImNHs03pdLNqlzHCJLD1/VZ2QoXjnKpnQ9Nx1RDVgiC/0gGnd3Vlp5nmsU0 Q20toGmCeq3Y37XWIzJXU99nCVWHFvU6V79lZWy4BVbmvSPNEsrUorMHsvCryacKMDfe y7fXLYsue/bduZGQWQ6cmhCrEweq0bTltnrBnDv2UN3WOY2jLwaDQVqsJ2aThf7hEOY3 kjF+KcsjpTo4cTxKQzgoJ0ezK6qf5yDk7XI1qdClu/ELAY7FzUcUiz8leUxAA1C2tkb1 UbOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xqbsKb6+MsTOYxvFNkRY6HKryVHEiHLbzY5smiU/q9o=; b=YHUke7hngpohcXDDPSSKQYhjosECG4LHW8A1dY3IVNPdeFFqOdyel8dEwFX+yDrGWi 97AGUDgOfuI4NFzZ3/tDFvK4j7HCkWnZRKyiev7jSgC3mY0FcYmXRX43LVkuK4A5FRAP VhIUezqL/+MM5U46VwyLtnws2gVQLEIKhix9380lsQj8RMVE7knn0cyxqP7nqcHeb+RH Fr7WeSAwr+gEv23teo4iy6NdkE3an7s9gszDEVB5GAqzEnyB8RhwOyMMKrgT7vlWdmxg M/6sQxLYdsMsAh3pvLdJ/Ti7ekPPhjanuoiisOSZ+aCBECYrz4B1VkwrIR34gGxgfAAA YN4w== X-Gm-Message-State: ABuFfoh3OiWkjIyGtyr4IrYMEoynPu5pHQo/Eenx+HpkwkiXE9MZA8oX UNO++dq5d51Og108+pooukritw== X-Received: by 2002:a25:7ec5:: with SMTP id z188-v6mr4015990ybc.250.1539110897163; Tue, 09 Oct 2018 11:48:17 -0700 (PDT) Received: from localhost ([2620:10d:c091:200::6:14c5]) by smtp.gmail.com with ESMTPSA id r8-v6sm15176282ywa.56.2018.10.09.11.48.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Oct 2018 11:48:16 -0700 (PDT) From: Johannes Weiner To: Andrew Morton Cc: Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: [PATCH 2/4] mm: workingset: use cheaper __inc_lruvec_state in irqsafe node reclaim Date: Tue, 9 Oct 2018 14:47:31 -0400 Message-Id: <20181009184732.762-3-hannes@cmpxchg.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181009184732.762-1-hannes@cmpxchg.org> References: <20181009184732.762-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to use the preemption-safe lruvec state function inside the reclaim region that has irqs disabled. Signed-off-by: Johannes Weiner --- mm/workingset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/workingset.c b/mm/workingset.c index e5c70bc94077..f564aaa6b71d 100644 --- a/mm/workingset.c +++ b/mm/workingset.c @@ -493,7 +493,7 @@ static enum lru_status shadow_lru_isolate(struct list_head *item, * shadow entries we were tracking ... */ xas_store(&xas, NULL); - inc_lruvec_page_state(virt_to_page(node), WORKINGSET_NODERECLAIM); + __inc_lruvec_page_state(virt_to_page(node), WORKINGSET_NODERECLAIM); out_invalid: xa_unlock_irq(&mapping->i_pages); -- 2.19.0