Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <13bda116-5766-1340-81e1-48ca899ff41a@baylibre.com> <20181003184318.856-1-jekarlson@gmail.com>
In-Reply-To: <20181003184318.856-1-jekarlson@gmail.com>
From:   Benson Leung <bleung@chromium.org>
Date:   Tue, 9 Oct 2018 22:06:33 -0700
Message-ID: <CANLzEkucw1KPOw+oRO-7NoxODhnj4BJsGgp4A+aQ7fTRPtxmhQ@mail.gmail.com>
Subject: Re: [PATCH v3] mfd: cros-ec: copy the whole event in get_next_event_xfer
To:     Emil Karlson <jekarlson@gmail.com>
Cc:     kernel@esmil.dk, Neil Armstrong <narmstrong@baylibre.com>,
        Stefan Adolfsson <sadolfsson@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        Olof Johansson <olof@lixom.net>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Emil,
On Wed, Oct 3, 2018 at 11:43 AM Emil Karlson <jekarlson@gmail.com> wrote:
>
> Commit 57e94c8b974db2d83c60e1139c89a70806abbea0 caused cros-ec keyboard events
> be truncated on many chromebooks so that Left and Right keys on Column 12 were
> always 0. Use ret as memcpy len to fix this.
>
> The old code was using ec_dev->event_size, which is the event payload/data size
> excluding event_type header, for the length of the memcpy operation. Use ret
> as memcpy length to avoid the off by one and copy the whole msg->data.
>
> Fixes: 57e94c8b974d ("mfd: cros-ec: Increase maximum mkbp event size")
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Tested-by: Emil Renner Berthing <kernel@esmil.dk>
> Signed-off-by: Emil Karlson <jekarlson@gmail.com>

Applied. Sent to Greg for rc8, hopefully.


-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org