Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 9 Oct 2018 22:43:06 -0700
From:   Benson Leung <bleung@google.com>
To:     Nathan Chancellor <natechancellor@gmail.com>
Cc:     Benson Leung <bleung@chromium.org>,
        Olof Johansson <olof@lixom.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: chromeos_tbmc - Remove unneeded const
Message-ID: <20181010054306.GA231593@decatoncale.mtv.corp.google.com>
References: <20181008222041.7713-1-natechancellor@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL"
Content-Disposition: inline
In-Reply-To: <20181008222041.7713-1-natechancellor@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--vtzGhvizbBRQ85DL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Nathan,

On Mon, Oct 08, 2018 at 03:20:41PM -0700, Nathan Chancellor wrote:
> Clang warns:
>=20
> drivers/platform/chrome/chromeos_tbmc.c:102:14: warning: duplicate
> 'const' declaration specifier [-Wduplicate-decl-specifier]
> static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL,
>              ^
> ./include/linux/pm.h:365:56: note: expanded from macro
> 'SIMPLE_DEV_PM_OPS'
> #define SIMPLE_DEV_PM_OPS(name, suspend_fn, resume_fn) \
>                                                        ^
> 1 warning generated.
>=20
> SIMPLE_DEV_PM_OPS is already declared as const, this one is unnecessary
> so remove it.
>=20
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>

Applied for 4.20. Thank you.

Benson

> ---
>  drivers/platform/chrome/chromeos_tbmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/c=
hrome/chromeos_tbmc.c
> index 1e81f8144c0d..ce259ec9f990 100644
> --- a/drivers/platform/chrome/chromeos_tbmc.c
> +++ b/drivers/platform/chrome/chromeos_tbmc.c
> @@ -99,7 +99,7 @@ static const struct acpi_device_id chromeos_tbmc_acpi_d=
evice_ids[] =3D {
>  };
>  MODULE_DEVICE_TABLE(acpi, chromeos_tbmc_acpi_device_ids);
> =20
> -static const SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL,
> +static SIMPLE_DEV_PM_OPS(chromeos_tbmc_pm_ops, NULL,
>  		chromeos_tbmc_resume);
> =20
>  static struct acpi_driver chromeos_tbmc_driver =3D {
> --=20
> 2.19.0
>=20

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--vtzGhvizbBRQ85DL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlu9kWkACgkQHwn1ewov
5ljQ1w//VHQx5XuQYO9p4QO7cu8gXQ0vHrfBw1IZgt1zmpgtvAmfj1tCrW9bKok6
j/SRkBybsKr0ld3LKrQpiySzNj57f6HfXdZKMJq8uGQ3n9K2U9hPnCzeydD5fmNk
VFk2oCsR0mQl+F871wlXs68jvD21NvaWXWWR/5gO2JuxrZMizmmna6tTviPVRhPD
IQhDnwF6RLcR6TZ7yxb9c+xUr5/GoeooZRl7Gzd7z6+DTZ15YWnkJQaF7LmedBi6
bCyn0696SRx9MTcvzW++Wjme9N5jtNJUcF/haeVAqdXwHrNFW9ppiBz0dgX4Gc2P
ZI8esipsBFaBv2SPDaCqg05mZ16YcwScDVQTnMQ9xUWc0Ya1juKvtfhDBdn5NwPg
wTJKui1BD+6qi+3Q563jprx1GMzaQv7m7p5G/8tqf7F6PzjZyWtLaXiJsdaiIGWm
QY4i0dYprg3EOpIy2RWB2Co/IsFfH3Mvkg0dtk8tbf4HbyzTxGIauy8VqI6DYMon
9827p80BI7J47Ci4DGw6Z2/QqStktk8vFzVREZkOyF+IxD94kA2T5XFxscgNM1jZ
8i4Po8vxVwiCMt2FrhkSdRgfVc9TBdKhAcjMiGLZKgih047wL/W39RziimGw+4Lh
yL2hfcZwaGMJEKMjtcX7DnwcdPfqu7snyMspVzrYazHkV0ChFYU=
=V6lN
-----END PGP SIGNATURE-----

--vtzGhvizbBRQ85DL--