Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp508084imm; Tue, 9 Oct 2018 23:07:01 -0700 (PDT) X-Google-Smtp-Source: ACcGV62XkPmnBXw1otBCsF6xYZ/abX2V5qtfs/N6Ns4CX59wvbrwLY0FnPfsJzESKf3LEsy/PouY X-Received: by 2002:a17:902:3a5:: with SMTP id d34-v6mr810393pld.231.1539151621932; Tue, 09 Oct 2018 23:07:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539151621; cv=none; d=google.com; s=arc-20160816; b=z0f5LGUqJW5oQzArQ0N+1uvBo5f4d2BWrzUXK0H+Sla+L+MzWxajy3JaYxUiiGk81h zIfi3yRveEgSKKR3+V+K2eQ8UFIz0DSuIbxDAnVMmzp2zYkHk/qL0zv1EHpI6iT0Hexn AypwpTSTpTgcV7XYFmoQFc0YnQBbxf+2gYrDCixdElJpJPNexDNv8EUe7TCMhLFyb4Go 4f52yBc7cjI4K4vwXmIwNRFjmDKNH+cYX8ONOrG2TbAEKMHccaXw/TSIp83k8nNjLcQD qLyFjv5JJr9FjDvFUm5QV+QGiHovN1XizZBq9LIKmfXAl3H+zIA71USrtdRqWFKcggRQ gUFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=4aCy5tTznrQu5jxgwpzh99WmSKO89ArK9yV9VYtEufA=; b=KUvLqslirWj3+FVjCrbzaSFbLdE6eiqFay6niyeHL7EDh8oV7OTsynrRttHyNtpGtx 6wKrhO0l9VG0ZzaQflL+G/VOVTPYvDRxsiNsHI5ILbxyKvFh1ssf3ReB6omX40furHOO HE2tXOXQSvihD5nqGcrlCheahiAkIkcEPSdXWVFEQzetEvQ5+gubIh0qqsaQy859ZSlp UbN+NME3/LymXZCgvzKswc1YXZ7spJNb8jg0Rt+AhSMHehxKQPnQD+CzBXlPLIfYL+2b mr7wP1z2H6u5veUqbqrJMuL+Ii6jkLrub+4yCtwZQdoceYeLhog3p9pfsvQimsXXEZjE rmyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ah62hQjR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e36-v6si19174211pge.127.2018.10.09.23.06.44; Tue, 09 Oct 2018 23:07:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ah62hQjR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726562AbeJJN0y (ORCPT + 99 others); Wed, 10 Oct 2018 09:26:54 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39527 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726015AbeJJN0y (ORCPT ); Wed, 10 Oct 2018 09:26:54 -0400 Received: by mail-pf1-f194.google.com with SMTP id c25-v6so2070442pfe.6; Tue, 09 Oct 2018 23:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4aCy5tTznrQu5jxgwpzh99WmSKO89ArK9yV9VYtEufA=; b=Ah62hQjRFq6E2r1YAqvgpalFraes1n93EziZXIrc4nMLgsB6Be17kz9vx8gwEx1aki UQS7AFHGboInTRnZLjc3an39lkWbI0bPx4C4gCfntVdxPK9gFUBgs7DPeInUHiZUq2H3 g/JALcawT7ECbwSjR5YbNqTDXepkNwowvWPGBzoQKPyzkp45FxTJBHptvL5rSBbnheWx QcrrUsHFSJ8QnCJFhioypS6K+ahdxPj1hW6MBbSWV1oBUSXZkBN8Nfqx1BCdNPOGw56N Y35U0h/lBOO0YKZFB00NTvy3wSiixtnNWBmeBbvUHesz/UBhB2efjrv/pWPvdt4kJm/d xcyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4aCy5tTznrQu5jxgwpzh99WmSKO89ArK9yV9VYtEufA=; b=fKHgaMZltWVmT/wmx3ZjPQbeOvz/Em6G2PWZzcAqvIzo2Tl8ZWf5IWhAm27gjSLp9A VtLm0JiqFXyB1wS7ZsoskvSYVV8/sUKp1pBTnC+73WzCi2hYfFcRyEo6/fZ4H0sL4frc ZGculhPFrksNlNvACxy6Ps0fWtcqhnRrmRkdzcvvvzGA5DQuusUZ2eQnqyLwCMgT+mWX +Wj9h0Hfi2exHfa/zFN2fjjFamu8NWPvcMtgWr8bOjxFGlYQzmSqdk5KAXl3JmpwNJb9 70L2HG5ln/MkV6k392ovEumPnlHwX38T2KOsVL2sySVguk94tOnno70nm5Nr8gkFj8g4 QpmQ== X-Gm-Message-State: ABuFfoi/XaVAEQRc82QHVyqSBCQ3/M2I1cxqAhmPt+qjrHv2RYSyxtas B8IIxG6pnaZvB4IRMjZNOMs= X-Received: by 2002:a63:c44a:: with SMTP id m10-v6mr28749830pgg.416.1539151580757; Tue, 09 Oct 2018 23:06:20 -0700 (PDT) Received: from localhost.localdomain (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id p84-v6sm26314354pfi.22.2018.10.09.23.06.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 09 Oct 2018 23:06:20 -0700 (PDT) From: frowand.list@gmail.com To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, devicetree@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH 05.1/16] of:overlay: missing name, phandle, linux,phandle in new nodes Date: Tue, 9 Oct 2018 23:04:55 -0700 Message-Id: <1539151495-8110-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand "of: overlay: use prop add changeset entry for property in new nodes" fixed a problem where an 'update property' changeset entry was created for properties contained in nodes added by a changeset. The fix was to use an 'add property' changeset entry. This exposed more bugs in the apply overlay code. The properties 'name', 'phandle', and 'linux,phandle' were filtered out by add_changeset_property() as special properties. Change the filter to be only for existing nodes, not newly added nodes. The second bug is that the 'name' property does not exist in the newest FDT version, and has to be constructed from the node's full_name. Construct an 'add property' changeset entry for newly added nodes. Signed-off-by: Frank Rowand --- Hi Alan, Thanks for reporting the problem with missing node names. I was able to replicate the problem, and have created this preliminary version of a patch to fix the problem. I have not extensively reviewed the patch yet, but would appreciate if you can confirm this fixes your problem. I created this patch as patch 17 of the series, but have also applied it as patch 05.1, immediately after patch 05/16, and built the kernel, booted, and verified name and phandle for one of the nodes in a unittest overlay for both cases. So minimal testing so far on my part. I have not verified whether the series builds and boots after each of patches 06..16 if this patch is applied as patch 05.1. There is definitely more work needed for me to complete this patch because it allocates some more memory, but does not yet free it when the overlay is released. -Frank drivers/of/overlay.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c index 0b0904f44bc7..9746cea2aa91 100644 --- a/drivers/of/overlay.c +++ b/drivers/of/overlay.c @@ -301,10 +301,11 @@ static int add_changeset_property(struct overlay_changeset *ovcs, struct property *new_prop = NULL, *prop; int ret = 0; - if (!of_prop_cmp(overlay_prop->name, "name") || - !of_prop_cmp(overlay_prop->name, "phandle") || - !of_prop_cmp(overlay_prop->name, "linux,phandle")) - return 0; + if (target->in_livetree) + if (!of_prop_cmp(overlay_prop->name, "name") || + !of_prop_cmp(overlay_prop->name, "phandle") || + !of_prop_cmp(overlay_prop->name, "linux,phandle")) + return 0; if (target->in_livetree) prop = of_find_property(target->np, overlay_prop->name, NULL); @@ -443,10 +444,13 @@ static int build_changeset_next_level(struct overlay_changeset *ovcs, struct target *target, const struct device_node *overlay_node) { struct device_node *child; - struct property *prop; + struct property *prop, *name_prop; + bool has_name = false; int ret; for_each_property_of_node(overlay_node, prop) { + if (!strcmp(prop->name, "name")) + has_name = true; ret = add_changeset_property(ovcs, target, prop, 0); if (ret) { pr_debug("Failed to apply prop @%pOF/%s, err=%d\n", @@ -455,6 +459,57 @@ static int build_changeset_next_level(struct overlay_changeset *ovcs, } } + /* + * With FDT version 0x10 we may not have the name property, + * recreate it here from the unit name if absent + */ + + if (!has_name) { + const char *p = target->np->full_name, *ps = p, *pa = NULL; + int len; + + /* + * zzz + * TODO: stash name_prop on a list in ovcs, to be freed + * after overlay removed + */ + + while (*p) { + if ((*p) == '@') + pa = p; + else if ((*p) == '/') + ps = p + 1; + p++; + } + + if (pa < ps) + pa = p; + len = (pa - ps) + 1; + + name_prop = kmalloc(sizeof(*name_prop), GFP_KERNEL); + if (!name_prop) + return -ENOMEM; + + name_prop->name = kstrdup("name", GFP_KERNEL); + name_prop->value = kmalloc(len, GFP_KERNEL); + if (!name_prop->name || !name_prop->value) { + ret = -ENOMEM; + goto err_free_name_prop; + } + + memcpy(name_prop->value, ps, len - 1); + ((char *)name_prop->value)[len - 1] = 0; + + name_prop->length = strlen(name_prop->value) + 1; + + ret = add_changeset_property(ovcs, target, name_prop, 0); + if (ret) { + pr_debug("Failed to apply name_prop @%pOF/%s, err=%d\n", + target->np, name_prop->name, ret); + goto err_free_name_prop; + } + } + for_each_child_of_node(overlay_node, child) { ret = add_changeset_node(ovcs, target, child); if (ret) { @@ -466,6 +521,13 @@ static int build_changeset_next_level(struct overlay_changeset *ovcs, } return 0; + +err_free_name_prop: + kfree(name_prop->name); + kfree(name_prop->value); + kfree(name_prop); + return ret; + } /* -- Frank Rowand