Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp531746imm; Tue, 9 Oct 2018 23:36:15 -0700 (PDT) X-Google-Smtp-Source: ACcGV61BDGTED/vVKdOQbN5m+ZT1FGAsqrI72OQQZeQgPWMUozhcElXj6LQ2KUxic1gqDdRZmsnC X-Received: by 2002:a17:902:89:: with SMTP id a9-v6mr30774475pla.279.1539153375816; Tue, 09 Oct 2018 23:36:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539153375; cv=none; d=google.com; s=arc-20160816; b=j+E+rppRcD9hpSI69mDrEruc0FTshOk4BZiKSlx8bWYLeLC8oFKKbQ36Gur002hZYg X67KSSt0eSRrDQ49e58NIxMmFfPNBL5/0JaRKx4cNyLZajY/4X54L6v96SnORwTsVpJr JfyZm0yZLPBogfE3X2c/3Kx4SXY43j1g4dhnwsJS6pUca03kdPwCUJhOs4hWGBBHDThz Cf7V+FZzXJ+WcIRO9KQa4LFMpX+nz2YGWxsgIqdRGfP0IYYAv4x0MuIiQwvZdMDicR+E JJc599LqMepbT5WwLQy3hp79r8mLke1Rfugz+DoJQkaUFvVepMmGD1pBhfSDHZE6dHyV gF8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=c/b+tGNeYLdIoMaVBGbfpEfqfRH4TY0pQUseN/E8q9g=; b=nVjtTlFl9fim3p5OdjwiksIjDZpQRzgSNHVzXE1Cp2Xtmd0QLO0sgVvS3HUEM/gbvk gwfVBHaVezbhZSanuCzNLhxkSbDI3HSdesdGKCTj6BNEJCIJ/e9MfSHuScTeM86DTLTf SL6L8kHLd81THtdHQPBcdv1ep0MMdjuEblkyel6yj8Tio9vZimIVyzNUFItmLEbudDxi 5fsw5ug+G96DJ1vkG8q4a9upz1MQ28dMSz01W714rsyvY2aWwaEH1uU+RW4OdTIFIs+4 O/RuhTao8PgT7rhTXdawxmHUvLKNza/HuKyMlfVD02hw+GjhAf9smDUMafo5WMl0x5US mR6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Gg9b864o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w30-v6si27295464pfl.171.2018.10.09.23.36.00; Tue, 09 Oct 2018 23:36:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Gg9b864o; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726656AbeJJN4U (ORCPT + 99 others); Wed, 10 Oct 2018 09:56:20 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:39858 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725757AbeJJN4U (ORCPT ); Wed, 10 Oct 2018 09:56:20 -0400 Received: by mail-wr1-f65.google.com with SMTP id 61-v6so4292421wrb.6; Tue, 09 Oct 2018 23:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c/b+tGNeYLdIoMaVBGbfpEfqfRH4TY0pQUseN/E8q9g=; b=Gg9b864oudgq5QNt04lzCm1yWQe2m2oN53NFboy3V1QxTuzKy1gsFdX2cN/LnDbi6Q 7IHi+kp8TM0F8SQ5owNL0gtnpszBtRsFA4N8E5Gmm88UuY0nekqsO6pR8apP5QpYYME1 h9dLWRU0Wvb0zDdlyZOYrby+IssJfZGQQfNA2xOn46k8QkuRTaeyT6WTejWe+efoT1u4 r+duFC7zApRpZ4JG7/mypHal8xMwUHOi/KocZKoCOBH8HXkTdea3iovKzR697v2qu8pb RoX4UQIXok7De9Wr21u2MPm+J0h/by3BjGqHxHKKvt3TKyUza8l50dd9stYKGNckfZQk zQ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=c/b+tGNeYLdIoMaVBGbfpEfqfRH4TY0pQUseN/E8q9g=; b=cbAjs4dTt18THjIjQuk0qzORzJMiNWicdHy/VzQHHnjry36YwN/ocfCGfoPT0AGdet PgYKmt72KIOW4892CEM09/xQjCzc3wTsfuLjdOwiirNGaeo0wXQPbiTxLauqqcqM538V cCGtLebLazq3p1zXZmPoUwv579cryXGvN3K2RmIqzfYQohF255Jx+Yos7bvfouioGwWW FJyPtqg5YWVd5wsNmxgvvdtx0H8dmdEV5eiQXNy4tSD752LWuqShZs+ZOSDNx68aYb+u w926FFFTZBHlMpQ9l+D6y3QbExyv1RRC/rzY2cFoHiAjS5pHHLrmjNtZUBj98EO9xEY4 w1xA== X-Gm-Message-State: ABuFfohICkfTu7JeJqjO+467LJuAbg2iLh79DX6cC1euUCctBeAm6Pso AJ7p02JsKjXG/Wi39NMHnCE= X-Received: by 2002:a5d:6883:: with SMTP id h3-v6mr22374466wru.108.1539153339556; Tue, 09 Oct 2018 23:35:39 -0700 (PDT) Received: from gmail.com (2E8B0CD5.catv.pool.telekom.hu. [46.139.12.213]) by smtp.gmail.com with ESMTPSA id t143-v6sm13901675wmt.2.2018.10.09.23.35.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Oct 2018 23:35:38 -0700 (PDT) Date: Wed, 10 Oct 2018 08:35:36 +0200 From: Ingo Molnar To: Segher Boessenkool Cc: Richard Biener , Michael Matz , Borislav Petkov , gcc@gcc.gnu.org, Nadav Amit , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, Masahiro Yamada , Sam Ravnborg , Alok Kataria , Christopher Li , Greg Kroah-Hartman , "H. Peter Anvin" , Jan Beulich , Josh Poimboeuf , Juergen Gross , Kate Stewart , Kees Cook , linux-sparse@vger.kernel.org, Peter Zijlstra , Philippe Ombredanne , Thomas Gleixner , virtualization@lists.linux-foundation.org, Linus Torvalds , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org Subject: Re: PROPOSAL: Extend inline asm syntax with size spec Message-ID: <20181010063536.GA124923@gmail.com> References: <20181003213100.189959-1-namit@vmware.com> <20181007091805.GA30687@zn.tnic> <20181007132228.GJ29268@gate.crashing.org> <20181008073128.GL29268@gate.crashing.org> <20181009145330.GT29268@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181009145330.GT29268@gate.crashing.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Segher Boessenkool wrote: > On Mon, Oct 08, 2018 at 11:07:46AM +0200, Richard Biener wrote: > > On Mon, 8 Oct 2018, Segher Boessenkool wrote: > > > On Sun, Oct 07, 2018 at 03:53:26PM +0000, Michael Matz wrote: > > > > On Sun, 7 Oct 2018, Segher Boessenkool wrote: > > > > > On Sun, Oct 07, 2018 at 11:18:06AM +0200, Borislav Petkov wrote: > > > > > > Now, Richard suggested doing something like: > > > > > > > > > > > > 1) inline asm ("...") > > > > > > > > > > What would the semantics of this be? > > > > > > > > The size of the inline asm wouldn't be counted towards the inliner size > > > > limits (or be counted as "1"). > > > > > > That sounds like a good option. > > > > Yes, I also like it for simplicity. It also avoids the requirement > > of translating the number (in bytes?) given by the user to > > "number of GIMPLE instructions" as needed by the inliner. > > This patch implements this, for C only so far. And the syntax is > "asm inline", which is more in line with other syntax. > > How does this look? Cool, thanks for implementing this! In the kernel we'd likely wrap this in some "asm_inline()" type of construct to be compatible with older toolchains and other compilers. Thanks, Ingo