Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp571053imm; Wed, 10 Oct 2018 00:22:38 -0700 (PDT) X-Google-Smtp-Source: ACcGV63/uZ8LXCiETd28BoPCuvFpVfbKFDVmQ2VoV1JoMZrv/xT/L4oCVJNWOB3l5cQwoleD1rmp X-Received: by 2002:a17:902:aa42:: with SMTP id c2-v6mr31060551plr.119.1539156158596; Wed, 10 Oct 2018 00:22:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539156158; cv=none; d=google.com; s=arc-20160816; b=BXcn2Cm8AelxCL7k4PIktFCnB2ZIDWPrnCksXoOSPU3LxzOeveeP26lX8K6+6cn2dE NGRa0Qwrs5iJIt8ZYeAaXutYGbXmk+Wh5U1sWohv5+tv8p7a2JRBF1ikmfaCm6mmu5Wq ChcxHLLMbYKgNXMuKrArGdydIofpl7B5yl0vUZMw858r1PkpqTqOlyk05C1/DoV7u0wo 3VhBkNZCnTjIPSgu0JxM4YyXdyuZqlfS/28tJvV+wMOUWMFGPgYEdSCUXw/mJcci8uZF m0WtF6v5RwnjRUzL3VbkSnK5mVWx+Q1pb2tueokw1j+vuBkcZLo/U7rsz19kc+6qiI2w P22A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=V4+AD3EwFltS3outCF1jgU65qiPT/+fK8lPv6uY7r0U=; b=ebwlzXVpXZTnDnMnMmKKIbQKHojiHF0JYuSadwi9+YOiojLzOe2inQD4d7DbxPmcIQ WQ3V/HIkC8FxlXH2pi0BaLX4d4x+18TTQVDVYv7caTDDx3vcI7SxtqgO0OTcehfKbQ7D u+KliyTmSSrHtmmp0ti74rSZwTMP/5RXINaWxSJq22O/c5kd3eQd3QB6XgdTiIEmMd9K SumDlfIaBKCFnyb8yjvXdDJuttKZyUpDk1/v0Zoq9Wch9VnrYtE9jvI8/1FPRWrkPa3r PLf/lzkSALUYKUH/mZEUQHVc1ctdNojr5OawWSiyuaUCGeRC8YJ2esx9NDywRGwgOqrN IzQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BK3wkl3j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c27-v6si27964474pfk.235.2018.10.10.00.22.23; Wed, 10 Oct 2018 00:22:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BK3wkl3j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726921AbeJJOmn (ORCPT + 99 others); Wed, 10 Oct 2018 10:42:43 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:40187 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbeJJOmn (ORCPT ); Wed, 10 Oct 2018 10:42:43 -0400 Received: by mail-io1-f68.google.com with SMTP id w16-v6so3134062iom.7 for ; Wed, 10 Oct 2018 00:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V4+AD3EwFltS3outCF1jgU65qiPT/+fK8lPv6uY7r0U=; b=BK3wkl3jkVWvbo6meUbB+oN6/WuQR9JHZWY4mgARdt4HRlDz7wiUeiDckQTqpkiAbs tZR+0vzkwa9o/m7w5YtBA7RCIW1RNH490ngyWzKwtvQagOkyOBJbqK/ojB9alihP6mBm /CRfExhB5QCIWbeCl5VzsbEHNb8FnsrS+TSkk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V4+AD3EwFltS3outCF1jgU65qiPT/+fK8lPv6uY7r0U=; b=DneV9D1uby3ZqttCkN/QeInOCfh3sBzD2w0Np1C9+9wXLoUsGhvFt9HqYWL+U6Ublp h4OBNd3Fz53mXYLY6u6NDXoZvuclBqI99UGyqiT6GKo7HdSy5YbreM9dEfI5gQ9gjCie n59J7lm6rH2m8BQRd0jSdyUeHiqYUnP/Z2ux61xLg6ox3QyM516vvsT64917C8cQySgp giifGVJ40vSOJtWXqlm/vRjJ24ZhoQR4ZLxwBUMbamUUSpMfguK0X8Bp9g096MBuzG33 GdKbZ9oVNuZ+7i8QGySY7DakNN6W5aHlNCVk6dIY3hpcohCzlDv/S4DDhOX2WHn914GC Jv0g== X-Gm-Message-State: ABuFfojJYjTBvUmrpJm9dYtsZOwPjK3Y+swzcOsG0WvlbQ5CDvBnKkuG WifNh2gML9IQr911R5a2E3q1gor+sdB+BUlq+kvTGjN5 X-Received: by 2002:a6b:6302:: with SMTP id p2-v6mr15052660iog.175.1539156113764; Wed, 10 Oct 2018 00:21:53 -0700 (PDT) MIME-Version: 1.0 References: <20180928131531.4598-1-Eugeniy.Paltsev@synopsys.com> In-Reply-To: <20180928131531.4598-1-Eugeniy.Paltsev@synopsys.com> From: Linus Walleij Date: Wed, 10 Oct 2018 09:21:41 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] GPIO: add single-register GPIO via CREG driver To: Eugeniy.Paltsev@synopsys.com Cc: "open list:SYNOPSYS ARC ARCHITECTURE" , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Vineet Gupta , Alexey Brodkin , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 28, 2018 at 3:15 PM Eugeniy Paltsev wrote: > Add single-register MMIO GPIO driver for complex cases where > only several fields in register belong to GPIO lines and each GPIO > line owns a field with different length and on/off value. > > Such CREG GPIOs are used in Synopsys AXS10x and HSDK boards. > > Signed-off-by: Eugeniy Paltsev > --- > Changes v3->v4: > * Cleanup 'include' section. > * Get rid of 'of_mm_gpio_chip' using. > * Get rid of custom 'creg_gpio_xlate' function. > * Get rid of dummy 'creg_gpio_get_direction' function. > * Small fixies. Patch applied. Yours, Linus Walleij