Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp619954imm; Wed, 10 Oct 2018 01:19:54 -0700 (PDT) X-Google-Smtp-Source: ACcGV63vw71A5hD8KRAjaSKkvX7J854NKWcKgaYWfjGf1z44RP93CvAX82d8yR7DsZWLZUjnAOEF X-Received: by 2002:a62:21d1:: with SMTP id o78-v6mr33539999pfj.235.1539159594043; Wed, 10 Oct 2018 01:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539159594; cv=none; d=google.com; s=arc-20160816; b=PA7rLuHgSxBc/EKfbo22JhVgna7g0QkIdOeT5QWFMxE6HIZN2bjEgtR4YL5oBYFOLe 4ID0e0mcgDgpIppkmA7iy2Y1f06RSFD7yXkU1xfEmAW5iv5ugQdnvTDhMCi1/j4+9jV6 kznLYxkd61nbgYZkEElYgUBKzJleya/rxS9pDyhsIY6CAQkiUkEGW/e029/tN11OdX0w hdaCmgovtu1rHhojVG0ff7RnOd3IjbR6tbNX3BA77wUnMz7Jm6yMhnRvIUd3ZSizc4sL RrycuvNwdKPNg4DGC32elxwcGbR5j9Oza2NsOe/5hUDY+b+ugBJ1RLgCLcEdRoTtFk8e dHDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=O0+veDsITTqOfhmThyfxaSTBaGtaVW7Xfzqh5Q81YR8=; b=gz6OD7Utfd1OTSjwI/BdHrMvsRmK9Ce2zhIO6WUhid0V/nKG3oViyUJWL3GaVgjmpm kW1Rdsr9GykiFbPe9RKhhhUuy9nxZ1aXzKuca7QJySl3Zahp5ZvXLkxh4ylY0T2P2tId I4lK+2ntYOYpbDdfeRWnWKGciAqVumtUqEd7XVQu409Qm0ucmKFSWpxn8mbUQQErepC0 t1DCRFdUAVCFrzzI7v7bDBy7eVo94x8KTPXy1/oqvhDvRlbkUBjWSHXFKATEOmn+klFE qJsvcVmBia3Tm00DfZhEZapN1PdvgzsBYUGodreaGWgRcnOETyFErqYzcOIoJLrqcOJE B1jA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10-v6si8987132pgr.403.2018.10.10.01.19.37; Wed, 10 Oct 2018 01:19:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbeJJPkP (ORCPT + 99 others); Wed, 10 Oct 2018 11:40:15 -0400 Received: from mail.skyhub.de ([5.9.137.197]:60090 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726468AbeJJPkP (ORCPT ); Wed, 10 Oct 2018 11:40:15 -0400 X-Virus-Scanned: Nedap ESD1 at mail.skyhub.de Received: from mail.skyhub.de ([127.0.0.1]) by localhost (blast.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9x1sFUDDZZuc; Wed, 10 Oct 2018 10:19:11 +0200 (CEST) Received: from zn.tnic (p200300EC2BCA7500329C23FFFEA6A903.dip0.t-ipconnect.de [IPv6:2003:ec:2bca:7500:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 32B241EC0266; Wed, 10 Oct 2018 10:19:11 +0200 (CEST) Date: Wed, 10 Oct 2018 10:19:06 +0200 From: Borislav Petkov To: Segher Boessenkool , Ingo Molnar Cc: Richard Biener , Michael Matz , gcc@gcc.gnu.org, Nadav Amit , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, Masahiro Yamada , Sam Ravnborg , Alok Kataria , Christopher Li , Greg Kroah-Hartman , "H. Peter Anvin" , Jan Beulich , Josh Poimboeuf , Juergen Gross , Kate Stewart , Kees Cook , linux-sparse@vger.kernel.org, Peter Zijlstra , Philippe Ombredanne , Thomas Gleixner , virtualization@lists.linux-foundation.org, Linus Torvalds , Chris Zankel , Max Filippov , linux-xtensa@linux-xtensa.org, Andrew Morton Subject: Re: PROPOSAL: Extend inline asm syntax with size spec Message-ID: <20181010081906.GA5533@zn.tnic> References: <20181003213100.189959-1-namit@vmware.com> <20181007091805.GA30687@zn.tnic> <20181007132228.GJ29268@gate.crashing.org> <20181008073128.GL29268@gate.crashing.org> <20181009145330.GT29268@gate.crashing.org> <20181010072240.GB103159@gmail.com> <20181010080324.GV29268@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20181010080324.GV29268@gate.crashing.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 10, 2018 at 03:03:25AM -0500, Segher Boessenkool wrote: > The code immediately after this makes it size 1, even for things like > asm(""), I suppose this works better for the inliner. But that's a detail > (and it might change); the description says "consider this asm as minimum > length and cost for inlining decisions", which works for either 0 or 1. Thanks for implementing this, much appreciated. If you need people to test stuff, lemme know. > You can think of it as meaning "we want this asm inlined always", and then > whether that actually happens depends on if the function around it is > inlined or not. My only concern is how we would catch the other extremity where the inline asm grows too big and we end up inlining it everywhere and thus getting fat. The 0day bot already builds tinyconfigs but we should be looking at vmlinux size growth too. Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.