Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp629110imm; Wed, 10 Oct 2018 01:31:18 -0700 (PDT) X-Google-Smtp-Source: ACcGV60r2++mbnPSrIcZRJ2WmEp+OZuFV+FdfVLLjaZMjiy8JR5JAIGRaICx+HFQ6k7mm+4rteMx X-Received: by 2002:a62:1b45:: with SMTP id b66-v6mr33816956pfb.94.1539160278237; Wed, 10 Oct 2018 01:31:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539160278; cv=none; d=google.com; s=arc-20160816; b=GOaksYJ9cbS3dxTQ7PafJpy9itstg/AUMGa6haDMxKf4B3vnRADm2CiVKkUNSqUEjs vrnoDbtHmYXqPgpi3COUNajGZB45G0XpHp/Euw0BG0WfEoxXUGzNJcN4qKbZGYjxea/e 3qCrP66QziVmj5P/x1AWUHLU+hMsl5Z3FvMBizaDk5NoS6qqYDnqrwSzDVHrZb/55fJy +9Uuebo2oArNtQYfcLZ5kC887T6T+piUhzeG5y7VJvMkjh6QxPiylI7EJgmppUNSqIVm yRusC141lrJGye0WZA+VUlUs0uatyA+dgGwCxxFxv7881sgSaAdNmcQSr2hnfOwDp/bk mHoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4q6AUe4sn0mFhuFPN6zYhh2v/khQgoV4JYyb2ywtspE=; b=NUcpvrAiPl2P/L8ApQw2XqK799QmaArMMAGmSitjMn1cjNp7weij7zrqxE/WAqLm2m gVGnfEThieeaAPKdOfvPSrEruRss89B9DFEllHhSscZKydKnlLCYyc8tf8RZH2HgNqGW /3ZDIxNgtRqcAh1gLP7PNUllkvTsUFJFSuTITQXWEh4cWMlBT0vLq9hIaNl1jti6pwTO /xc8K+L03L5sFtfoTlQJ8XOPgLCP8XqqwUqQwjYtKd6SiVHHAbj085+DUyM8W9suEiwE lLEp/zOn5IMPuAxJ+NF3eSXmHCUNuvZHzTWbYNTOxBe8B7qgZxdcfXPDa/xCEGS7yS19 K4Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MUwvb8D3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si23755136pli.238.2018.10.10.01.31.03; Wed, 10 Oct 2018 01:31:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MUwvb8D3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727316AbeJJPvW (ORCPT + 99 others); Wed, 10 Oct 2018 11:51:22 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:35188 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726699AbeJJPvU (ORCPT ); Wed, 10 Oct 2018 11:51:20 -0400 Received: by mail-io1-f66.google.com with SMTP id w11-v6so3274202iob.2 for ; Wed, 10 Oct 2018 01:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4q6AUe4sn0mFhuFPN6zYhh2v/khQgoV4JYyb2ywtspE=; b=MUwvb8D3vqZa9P57163URj/X+Mxn5yklwu7vKzFEWqVAktt4FLUxt8s3Yel+Lo56MG V2NuGfzF2eVBzTc/FVCo516iM7uI2UmppChBLarhN9VQJODKJd95Pq6sP9O7DlMCg4c9 AvWUn2KA2pfv8jTgDIDr1t3i3eeg70skIKqQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4q6AUe4sn0mFhuFPN6zYhh2v/khQgoV4JYyb2ywtspE=; b=pZFczIXMPJqsooLSP6aOWivHm2JFmMAj+tO6a8/spDmcY01TypTL8mA31sAXLzlyey NiaOylOwIuVbzaMPzf1b8tkVPWgvE6Af+FNEHV6IoZPrPUwdPfbS/5iz5sfHKrhOHgaZ XR6Du9GpP5UsUR+uShZBizMuUUudkTjgLJMY/QRTDaxgbSssrh1o0ndN4khjPRf/01Dz 3PxO4K5fFaX+cm/JSSKIFRpwlXUY3fuG0G7WkrFj7mwyuDrxotjzVqM4WH3N+3/56HgS xUJnqyZzL0uTABF7DyJQ9BwJYIv4cDaU5SuGr12HU2BXKWH3U2Q2NVQChaN9ODK83W1X A6RQ== X-Gm-Message-State: ABuFfojVt2TJkgGv6j7wN21kCo2I28ewus3fw9il//GZlS7t+neAe7C2 uzkNdTwBXUeSTbtczTBSE81rHbdK5cpx2a/d2Vk7FQ== X-Received: by 2002:a6b:6302:: with SMTP id p2-v6mr15172145iog.175.1539160215626; Wed, 10 Oct 2018 01:30:15 -0700 (PDT) MIME-Version: 1.0 References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-2-ricardo.ribalda@gmail.com> In-Reply-To: <20181005065300.22882-2-ricardo.ribalda@gmail.com> From: Linus Walleij Date: Wed, 10 Oct 2018 10:30:04 +0200 Message-ID: Subject: Re: [PATCH v5 2/3] pinctrl: msm: Use init_valid_mask exported function To: Ricardo Ribalda Delgado , Bjorn Andersson Cc: jhugo@codeaurora.org, timur@kernel.org, Stephen Boyd , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 5, 2018 at 8:53 AM Ricardo Ribalda Delgado wrote: > The current code produces XPU violation if get_direction is called just > after the initialization. > > Signed-off-by: Ricardo Ribalda Delgado Patch applied with Timur's ACK. The code makes perfect sense. I hope Bjorn has no reservations, if he does I guess I have to just back it out. Yours, Linus Walleij