Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp629980imm; Wed, 10 Oct 2018 01:32:20 -0700 (PDT) X-Google-Smtp-Source: ACcGV60tGu59U/tq+yLOI1X6XuWSMILaYuef1qrt7ivwxLLq88aSJjI6GIJHn0KGqCGeaZGv64IQ X-Received: by 2002:a63:6203:: with SMTP id w3-v6mr28762466pgb.53.1539160340691; Wed, 10 Oct 2018 01:32:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539160340; cv=none; d=google.com; s=arc-20160816; b=gsVZnFQ73z05XgAxI67wisj1/KAafmcMlIROniVr6ZCFrSsC/BpTyhZQ6gfEzt+IQO 376B0k0GIRQ1CO1oUA8CKzOxsLSbSt1wIiMBw1x3K87v5Hd9iWX25lpQYXRjRzsfBeZG 6/LN4GQ20DdzQ2DFzcqpZ0aEkxDZPMdDNHh+kdZDs/r7Jha+184K5Mf7R+8pL2E5DPHH br+AQ18Dba/smE8MHRefVr4IW0DKN/WMltsZVcfpvjRHZfJ2TEqCs8Hm81rh6Fk61lnu Ka6FsOB+zD51uHNKhEo1SdKK6cRepTlRm2LiTVma1KTuzK9fVHihPrClUw5sShYoZhj4 6tHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=LmSZEaRV1T3eXbgC0D6JgFUlnszILPSLsr3Cbuaq2h0=; b=mwiXdYszHMHonDYrGI6FT40X8trfmm0lg7R3P+Ul5iOzYxwcznofUah7zVffQVvgTQ OLZ9RVwlWHj2/WPIENJQxpNW5zQ0G5Mr8RQ2s56Xo7DkqbBcGW7U/6PCUR8JeXFF1qa4 HEA51B870PhISC9Qp5VysnTQyoJjj17wUCrKMA//om2qWVXGXxNMUu8L+En0X9SH6giq hzZNqgpqK0sBIGxVEhbXVzxOUwsCqxbp6f0uB+mybDRMi5jojDI8b+Ku/Cga1R0uTsui inBfGTpwkddlMXRXDBsmTlIo85CJPaq0sjSxTCx0940FjBQK3xMV8ZooWOXzN2iSkxa6 WZzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WFekkP2p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d11-v6si25998673pla.245.2018.10.10.01.32.05; Wed, 10 Oct 2018 01:32:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WFekkP2p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727078AbeJJPwk (ORCPT + 99 others); Wed, 10 Oct 2018 11:52:40 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:35377 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726699AbeJJPwk (ORCPT ); Wed, 10 Oct 2018 11:52:40 -0400 Received: by mail-it1-f196.google.com with SMTP id p64-v6so6814097itp.0 for ; Wed, 10 Oct 2018 01:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LmSZEaRV1T3eXbgC0D6JgFUlnszILPSLsr3Cbuaq2h0=; b=WFekkP2pbPUevZBvKpFWaarT0zIuVePV9aa2JwosDIU3095darMsb8C5hof4w6jJxk F95Uc54gIjgaxcAJ8KzMsiC5dY4YQ+5O0dfudSiVP77utuUu2pUchxVPZ9sxaITKLfNV 3AyWW4/cDKROylvIkDCSeRRPeYunMlGOG0j1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LmSZEaRV1T3eXbgC0D6JgFUlnszILPSLsr3Cbuaq2h0=; b=rELeZ/K14gGKR6THhphwadKIz4R9SIG8NF1fdVMZWqYRRYUzAmoxgBYR+bd70/MARP 2y+UyOBVYj87XFuvpzQAabyOI32EYR7ZhVjy2nAMVVymbwK8QPeXiE3Lbw6gI0Pr31J7 SvDUwfbDUbYXeXoj38WIh11wUfeVH6eYWp5FLuLc98n/iB+prj+ObCFTSFtkIKSs1ufh qUr7LcS2zAbm4YJl22sh/PmyudIyl8C+uBFIYHoUJQRfmJhJGZ8tC0NWiP4ALE6hY86U f6qoDW6QeY8TJwkuyqLa5ZvTnU39YcXgNCVSqNJccbIJdL+DhRyYzwU3FAKzk3iDHM+s 50Vw== X-Gm-Message-State: ABuFfog1BPqbig5y+jXxkg1o6ZVc8yepKvlLD7f1aPzcM43G80FdOJvf iFDNNCViJdUMax+NXc3EveNZfb/15qssaY5woVNpJg== X-Received: by 2002:a24:e0c8:: with SMTP id c191-v6mr7331ith.156.1539160295206; Wed, 10 Oct 2018 01:31:35 -0700 (PDT) MIME-Version: 1.0 References: <20181005065300.22882-1-ricardo.ribalda@gmail.com> <20181005065300.22882-3-ricardo.ribalda@gmail.com> In-Reply-To: <20181005065300.22882-3-ricardo.ribalda@gmail.com> From: Linus Walleij Date: Wed, 10 Oct 2018 10:31:23 +0200 Message-ID: Subject: Re: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning To: Ricardo Ribalda Delgado Cc: jhugo@codeaurora.org, timur@kernel.org, Stephen Boyd , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 5, 2018 at 8:53 AM Ricardo Ribalda Delgado wrote: > Current code assumes that the direction is input if direction_input > function is set. > This might not be the case on GPIOs with programmable direction. > > Signed-off-by: Ricardo Ribalda Delgado Patch applied with the collected ACKs. Thanks for working so hard on fixing this up. Yours, Linus Walleij