Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp632448imm; Wed, 10 Oct 2018 01:35:19 -0700 (PDT) X-Google-Smtp-Source: ACcGV606vYVUF6QmpNOnFdxjA3biw0C7fm1c35yq9JsRVTtmb/jPldYcqV/2f8KtvOLLx4YejtbT X-Received: by 2002:a62:b286:: with SMTP id z6-v6mr34363630pfl.79.1539160519215; Wed, 10 Oct 2018 01:35:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539160519; cv=none; d=google.com; s=arc-20160816; b=MIzMn/Wiruvq0v2Vmkmj9Z5BsL7NcH6muKS/XM/D7J7ZgG+eiIQZirrGZacM78Pwym 7F5hLwAFGOm76iDqcnFWjwe54A7GHeBhIiQR5K5NwYUdxZe38dF00+hVI+PmPRMImc3r gL9jDtSrnBvEFUDuf1hgbpQvOShqgH/kqei/+qTyGsEfK+d7RudtdMG1BGWs3rbQgLJA f5iHoOyTzf/pcUcNSRhXOF2yR5UyX5yDZlCVLPbouERzRKpRadKwFnsAnY1Xb/o36QeQ CX24Ucp7FH7qjgyGqM1qslWtF11atniP9ld65kqpT5vC3RE/s6D1BqIybDTnp4wtxyyY NwnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=eujMYhu6ldzfbJ0RqWpOCG47FzoaXqU2qoLFC87WUFo=; b=It/8UKzrM1QNcOqxVrap+Wgxur50yWD9sFgr+hlzJkxwuhrrfQ8UTEF09onLArSUUS RCbIfyjSmGh7EqmWIZKXNg/CZ6f65u/C8G9Q0QC+gj2dyXyihT7JPudxLzC0sBlDjX6O OOfCbo9Bx/euyYhZOHwJnwh7nr9TRx/32OVUGOrx+0bCS0Um/W37FyzdfgNFhA27AmMB 0UAssXpHjF3IxF7w2tJUg3YG2tDlivxE92f4/JPMGt4RUdQSsQlmaWUkRI5t2MuNIHaZ eDh9tdpguo1qC2i6stXsYR/EC3haVj0RcypCe8gVSlaeCohui3cTvurLzZdnxsJZ+8PP wE/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m125-v6si25031368pgm.541.2018.10.10.01.35.04; Wed, 10 Oct 2018 01:35:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727195AbeJJPzl (ORCPT + 99 others); Wed, 10 Oct 2018 11:55:41 -0400 Received: from mail.bootlin.com ([62.4.15.54]:45050 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbeJJPzk (ORCPT ); Wed, 10 Oct 2018 11:55:40 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 57DCF20898; Wed, 10 Oct 2018 10:34:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from qschulz (AAubervilliers-681-1-28-153.w90-88.abo.wanadoo.fr [90.88.148.153]) by mail.bootlin.com (Postfix) with ESMTPSA id 2488F207C3; Wed, 10 Oct 2018 10:34:22 +0200 (CEST) Date: Wed, 10 Oct 2018 10:34:22 +0200 From: Quentin Schulz To: "Gustavo A. R. Silva" Cc: linux-kernel@vger.kernel.org, Andrew Lunn , Florian Fainelli , "David S. Miller" Subject: Re: [PATCH net-next v2 2/2] net: phy: mscc: fix memory leak in vsc8574_config_pre_init Message-ID: <20181010083422.phokcciqdkzm6u7w@qschulz> References: <6161326e265a99f8ec8e0f7028790a0131c5404e.1539159556.git.gustavo@embeddedor.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="k52oevuihyj2ev4i" Content-Disposition: inline In-Reply-To: <6161326e265a99f8ec8e0f7028790a0131c5404e.1539159556.git.gustavo@embeddedor.com> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k52oevuihyj2ev4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Gustavo, On Wed, Oct 10, 2018 at 10:31:39AM +0200, Gustavo A. R. Silva wrote: > In case memory resources for *fw* were successfully allocated, > release them before return. >=20 > Addresses-Coverity-ID: 1473968 ("Resource leak") > Fixes: 00d70d8e0e78 ("net: phy: mscc: add support for VSC8574 PHY") Reviewed-by: Quentin Schulz Thanks! Quentin --k52oevuihyj2ev4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEXeEYjDsJh38OoyMzhLiadT7g8aMFAlu9uY0ACgkQhLiadT7g 8aMohBAAlQkYmbTdzStBkzHF5bBU4ItEg/jl0yjL/1tHSy2l4R/tJTGpatX6h61/ bwzx/+M/MLxpbcNSPIgUoONRWELGqM8oCSSYYO7sXxNLnB9x7HsNUziPg2X4zDY2 Ie7Ot/vm+gwdNd+Hs9KzCng98bUC8gR1CQqrd4o0fSQg3sz2GpW2ExC4xGa9s0PZ crd88sSjCy9BRou/QKXqQyF2p8mqPGPA36hMnnHEooWkzYJskJkuuwtQOIrvBAZ+ e459/3bqV5qFeXiT+rxVx7MKZ+Ede7v7v3Ahm9Zjee2yE+us3RDydZXg+TMqtUvu UY74G0pJDP6gt6blbN9YhLNqG5q3HBUTPsooYLJOhUCSg+GQ2exQUAaeaAeTf/B6 6lOuN+vCYotXHVCy5h+TZUeVDbAT748NCM/49NxPzWASAGqtp06OLV4GhCwrwbIf CJJWB1+QgnYDoQisTcQ4/AaTOGfTKDCJRU9KSs6ghIDQraQRP6VkUOt4WvZbQ18m 4h2gDFIfn3jMktifUK6c/EmIde2ILBlQTBYq6SvrHISXDdBaDMvdjn05J260YZZS DNwsnFpz56DmByVYDKEpb1lu1MwHpf95fHMgq+kIuevo69PcrB/TGADEeukRUKCu cCDEbPPFV7qHFof35GJ31VIRKkfAru9uW2acCmaNwNVnTSj0UkU= =Llml -----END PGP SIGNATURE----- --k52oevuihyj2ev4i--