Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp830629imm; Wed, 10 Oct 2018 05:08:02 -0700 (PDT) X-Google-Smtp-Source: ACcGV62wUsDFRFBHweyYIcql9ZXP/OQRBZPxO6z/Kqu12RRrWXqV7LrnuCWHVltmpaNxUVQQNOVE X-Received: by 2002:a17:902:8c84:: with SMTP id t4-v6mr33308662plo.188.1539173282235; Wed, 10 Oct 2018 05:08:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539173282; cv=none; d=google.com; s=arc-20160816; b=j3fUH4JXkm1emlUMMrgaMd4leRpG1NL83GT69oKiEgmgi3b/11Q3j1H8Fynb5uDJY2 GeW5dNSafE/z3R+D9BVU+qiTc9DlMbA5QeMSMmwjOi4vzkfwrYHim/XWMsQf+DkOJG2g 1YXnrDITzg4j6fxPuJ1caC6gS8sZtU8FPAi3JF4hai8Xx2d7rMqXvIYEwF73UuLBf0wX duv3Q8C203onSMjJeRHQwx3C8XqmLdeP6TQTQgJAijXYQiWBVQ1QHwZvSEDK0R7xbv8f qgRuTsSHNbn5F+wyKJ2MP8aHkN8XmpB7CWHN9dPmBJ9uiJI4+RJMZWG8yIrMw43tsXaJ p0oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/GmAF/G6IjUUGe4NhyetSoyA6q9c8+m7u1fAHCfS0jk=; b=Sme3Re2cgl41cTeueaTz6tS4NdQnuzLwaVkQhH9//eympxykEPhaYYQX0dO9t1jcDl 4nJGG2ggtEWcGLwIMhyJjkCornqGKBiHhq31sBGzb0hWm1NqRCcfpm5G4ROkf8TpnKM9 SClA4yLU6XqL7EH59WRXy/rFOrIGvQR4VLhsLvtVWInjQxj0G0D/Q10DV4FCuDTNjOcf ZY4yuhKs1mjMwbi6mcCCZ0pwcYSxNh+bbCJavWETPKfWybzCd63zHfqjwRBZFp9qmmfS 4PIWp0hWp4dvj1mvMCf2g6HeDIYDUxVj95GrjTL5/THhzafKyJn4w3HAqMJNI0hPJdjP 7KQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j63-v6si22537506pgd.69.2018.10.10.05.07.47; Wed, 10 Oct 2018 05:08:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727152AbeJJT1e (ORCPT + 99 others); Wed, 10 Oct 2018 15:27:34 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:53005 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727051AbeJJT1e (ORCPT ); Wed, 10 Oct 2018 15:27:34 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gADFD-000075-OT; Wed, 10 Oct 2018 14:05:39 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1gADFD-0007No-8H; Wed, 10 Oct 2018 14:05:39 +0200 Date: Wed, 10 Oct 2018 14:05:39 +0200 From: Marco Felsch To: Arnd Bergmann Cc: Mark Brown , Liam Girdwood , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: max98988: add I2C dependency Message-ID: <20181010120539.ija2n7chqrtx2fdh@pengutronix.de> References: <20181010083758.2874864-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181010083758.2874864-1-arnd@arndb.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:01:13 up 20 days, 15 min, 25 users, load average: 0.06, 0.03, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 18-10-10 10:37, Arnd Bergmann wrote: > max98988 only builds with I2C support enabled, otherwise we get a build error: > > sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror] > module_i2c_driver(max98088_i2c_driver); > ^~~~~~~~~~~~~~~~~ > sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] > sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror] > sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable] > > Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable") > Signed-off-by: Arnd Bergmann Thanks for covering the issue. Reviewed-by: Marco Felsch Regrads, Marco > --- > sound/soc/codecs/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > index 3c6bd6019b92..774d38310875 100644 > --- a/sound/soc/codecs/Kconfig > +++ b/sound/soc/codecs/Kconfig > @@ -641,6 +641,7 @@ config SND_SOC_LM49453 > > config SND_SOC_MAX98088 > tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec" > + depends on I2C > > config SND_SOC_MAX98090 > tristate > -- > 2.18.0 > >