Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp835073imm; Wed, 10 Oct 2018 05:11:32 -0700 (PDT) X-Google-Smtp-Source: ACcGV632+IhpZslZ9EyKPoYSznpVTeY74kPd0+eRWq2pIsq6sagCyHW12GjkE3dMOqG4lBN8tOZq X-Received: by 2002:a63:6c84:: with SMTP id h126-v6mr28672337pgc.237.1539173492233; Wed, 10 Oct 2018 05:11:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539173492; cv=none; d=google.com; s=arc-20160816; b=ECeMQd713PrAp8GL2VQ+ulub3UQOQKL5BLvMyweitYj45ZHUUg1Ffwlf2ZEQm+1lKJ JrO3Irqp6H8cFkqiQLt9+o6QzUpY/dzrmH6nkQBi9kHLsl9uWvFOJGKIAC+nsyuTpJy0 CYFIyTTqoEPPZDelGcoU0JTWBK9fQQbmKoAW1QLYWha4QbfEtYuK438A4sQZueB69eO8 AsynrulHFZkmnrZ/iuWdcCJPgedM2KJ7IoWGaM0v7zJu5mkAug9R1dvANmVJgmIb9ac+ u7b1L0ozIjW17yJzG9yyEvsYfXlVtSW3ANXumAxTD1sXabj+EI3RTP/61cCynYCtYw50 xPzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=dkfKGcjQzKN8hh2//Jg3yjLM/KZEKNiGbJqyEz061ws=; b=YLUbVzRomz6WMvxUETh1rQc3jE6hPG4GiGvbaF1uxnfVd3NHM6HCQEq5I4ngzcxvhp ITkPGVNP3u2N9K94KSm4ylPiY+NV7oi+7GfvR3h7oYqS2eISr9fuZAI3AhDhu420KKz3 E3lCen8n++DR/doxxa0ioOG/fYOyYJi9b1v5cGKkrZSm1eSbWdXOfWxfw3YMDFQa8zqs XTDmoyNGgL1+cO2kVx23QthU5arlPSylvzre5fjZazYmz326Nc3lsvq7YWpNooNbcU8y ukDSaIjX455fCJfvhy7FgC3Q3XkF4daopjI6b1JIcLZuW7T8qYwaBhn5QXNLLMhE+9Dn ha7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g12-v6si25939560pla.70.2018.10.10.05.11.17; Wed, 10 Oct 2018 05:11:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727847AbeJJTa5 (ORCPT + 99 others); Wed, 10 Oct 2018 15:30:57 -0400 Received: from inva021.nxp.com ([92.121.34.21]:59418 "EHLO inva021.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727447AbeJJT3u (ORCPT ); Wed, 10 Oct 2018 15:29:50 -0400 Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id DEEFE2000A2; Wed, 10 Oct 2018 14:07:57 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id D2468200042; Wed, 10 Oct 2018 14:07:57 +0200 (CEST) Received: from fsr-ub1864-101.ea.freescale.net (fsr-ub1864-101.ea.freescale.net [10.171.82.46]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id 1D1C720604; Wed, 10 Oct 2018 14:07:57 +0200 (CEST) From: laurentiu.tudor@nxp.com To: devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm@kernel.org Cc: roy.pledge@nxp.com, madalin.bucur@nxp.com, davem@davemloft.net, shawnguo@kernel.org, leoyang.li@nxp.com, robin.murphy@arm.com, bharat.bhushan@nxp.com, arnd@arndb.de, Laurentiu Tudor Subject: [PATCH v3 15/22] dpaa_eth: fix SG frame cleanup Date: Wed, 10 Oct 2018 15:07:30 +0300 Message-Id: <20181010120737.30300-13-laurentiu.tudor@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181010120737.30300-1-laurentiu.tudor@nxp.com> References: <20181010120737.30300-1-laurentiu.tudor@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laurentiu Tudor Fix issue with the entry indexing in the sg frame cleanup code being off-by-1. This problem showed up when doing some basic iperf tests and manifested in traffic coming to a halt. Signed-off-by: Laurentiu Tudor Acked-by: Madalin Bucur --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index ea814feb4666..ebf982283062 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1663,7 +1663,7 @@ static struct sk_buff *dpaa_cleanup_tx_fd(const struct dpaa_priv *priv, qm_sg_entry_get_len(&sgt[0]), dma_dir); /* remaining pages were mapped with skb_frag_dma_map() */ - for (i = 1; i < nr_frags; i++) { + for (i = 1; i <= nr_frags; i++) { WARN_ON(qm_sg_entry_is_ext(&sgt[i])); dma_unmap_page(dev, qm_sg_addr(&sgt[i]), -- 2.17.1