Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp936285imm; Wed, 10 Oct 2018 06:41:45 -0700 (PDT) X-Google-Smtp-Source: ACcGV63oMYIhTk571BFg8dilM7tASj9rP11Q0iL8ROnC2iq6GoU7ZP6xhJBOxyt52ZTceHQNeHEz X-Received: by 2002:a17:902:ac89:: with SMTP id h9-v6mr32496436plr.174.1539178905933; Wed, 10 Oct 2018 06:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539178905; cv=none; d=google.com; s=arc-20160816; b=l/GXb1jzNN2eezfqaCjKG4Ns1BJxHq/6ocEQ7yZBYF7Iig5fHOQr/5zPBPzphk90Sn 3xfMhHRnYfEek7b3Y2gcnQTf13zNHE5X87wcYDg7MfZCh9nVQDR0SD2SJ9nG2pWl+dw7 8lz9Z8fVYLKcVs22h80NcnBkMF/GROO5L9XCSyIFDol9dito5TiQN2u5ItZb9biwq+5W 35lrpwpUJT1CkeqmymNsprgJZmxpWj+yKS2GEXuP7C6StSrR0GXTOuqajSc6Oj3Hft45 DteL+kbqHAmBuOYOE2En5pCrVi0K6tRbYOWT7Oggr9Dl9L2a4Uo2VrNhfzNWcSgC6mOB 9iHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=nKZFXmA23ViWjvu/c5GFgRudL/J4VXmmfdt+0utR8Uw=; b=toZVso+Gp/jiPsEEQdZLLF11csETWDbYIf0i3lUDQNdpVKgjBnfcwRjwWryX3LUIpC AxI+TdJjpenPmPejlsp2hHcUlfdBqFiiG4OPC+XgQ0SyEUlak9du4Iex8+rV4TXSiw11 Pt3058QVSmSlF8dkyI0lELUCTYpd/iNcy2isD6MyfSsgwzHfdJapEdNJf9uR2BK+BbIa wy4gF69cPelUqTkMK/DGUezARVCy1J70Yj1H4JtqDPHmR7nzNgbZk8RAIAo02UQ3xmDf LwxnEnmCOWW1Lx49yJbwVFVgKsreTDxISTuIzxC4/TRFd5HaBaZn31m4Awe3N20RtrLR XKIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7-v6si23904736plp.9.2018.10.10.06.41.30; Wed, 10 Oct 2018 06:41:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727141AbeJJVDI (ORCPT + 99 others); Wed, 10 Oct 2018 17:03:08 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:38638 "EHLO laurent.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726969AbeJJVDE (ORCPT ); Wed, 10 Oct 2018 17:03:04 -0400 Received: from ramsan.of.borg ([84.194.111.163]) by laurent.telenet-ops.be with bizsmtp id lpgl1y00b3XaVaC01pglJS; Wed, 10 Oct 2018 15:40:48 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.86_2) (envelope-from ) id 1gAEjF-00006x-TZ; Wed, 10 Oct 2018 15:40:45 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1gAEjF-0002Ah-Sc; Wed, 10 Oct 2018 15:40:45 +0200 From: Geert Uytterhoeven To: Arnd Bergmann , Greg Kroah-Hartman , Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-mtd@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH 2/3] eeprom: at25: Use spi_message_init_with_transfers() instead of open coding Date: Wed, 10 Oct 2018 15:40:35 +0200 Message-Id: <20181010134036.8296-3-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181010134036.8296-1-geert+renesas@glider.be> References: <20181010134036.8296-1-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reduce code duplication in at25_ee_read() by using the spi_message_init_with_transfers() helper. Signed-off-by: Geert Uytterhoeven --- drivers/misc/eeprom/at25.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c index 7707d3fb49b526d9..5c8dc7ad391435f7 100644 --- a/drivers/misc/eeprom/at25.c +++ b/drivers/misc/eeprom/at25.c @@ -103,16 +103,15 @@ static int at25_ee_read(void *priv, unsigned int offset, *cp++ = offset >> 0; } - spi_message_init(&m); memset(t, 0, sizeof(t)); t[0].tx_buf = command; t[0].len = at25->addrlen + 1; - spi_message_add_tail(&t[0], &m); t[1].rx_buf = buf; t[1].len = count; - spi_message_add_tail(&t[1], &m); + + spi_message_init_with_transfers(&m, t, ARRAY_SIZE(t)); mutex_lock(&at25->lock); -- 2.17.1