Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1010696imm; Wed, 10 Oct 2018 07:50:10 -0700 (PDT) X-Google-Smtp-Source: ACcGV60XevVFTHN0YGkxycATp1fV3gSLb7yI3NCdJqhqwEoy5SJBjOP2iSttbIdQovNTstQV68FN X-Received: by 2002:a17:902:6948:: with SMTP id k8-v6mr620593plt.75.1539183010881; Wed, 10 Oct 2018 07:50:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539183010; cv=none; d=google.com; s=arc-20160816; b=G4Qiu8juV1hpBPIV9pyus5rMUVmRNn4cIhRdTHbquD1CtgGNUAW1KSxCSwdp2lhIwM ZphvaHF+HzYlprHM9Ea9lVbtqnkSDA+Nd/JNaDaE8h5+k1vRJxDfHhiUQ0s+suxUFCqB 0Tn/DBw/vQ98CoWZNeiyFXXOFXaqXJCdy6e2tU5rTh+bcBjByN7wx14PFk9jJdRHor3B U+sylDsCyJmsoF0zRRnMCrY2fMVaRTCITcPSiHLnDcMmb400vnSkDD1nu7HaYwnR/iiX 4Z0EUPKYR5T3zPpVK1RAa1L4f8McWpbK9mKxwQzMDBYn6itMRcQ+0M6ILRN66/heIndN 3crQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature; bh=6vb8mTHxh+51Y3sbgq4Ms+t4t6l508BHXZnjEgq7fsA=; b=cCwAM3zbAkeMueg4Y+IJR/6FbgxXohc0vTz1yf1ONDhl4S4zaa0Y/f5T6M0cfwV/QJ SYoBGeUNo/WrmuC7rg0Y8e01zZ4ebkqjBKsEZr5h/sRhU07Eqo8PBOgbdReKwPT/oNuM HO7apVh9VYGQsOGbJ1seVjsyigvUTyDvtToHFpoDi7UFaw1h1UxBUS8l7gPUBeHRZVC1 5Y3nQFlYBxl8unLsx88GdTzEWZaKY/XFcCcM8leqO9q7VdvdyB6XFe2XiUIxi+VokCuz nSLjyG/Tn/KYrC0MTjTS6dL2SlCdD+oCpp/4nMqzhTbGujqx/h1ViVt1Scfm/p701zzK f9tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Mhffp8AM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y27-v6si24683247pgc.197.2018.10.10.07.49.55; Wed, 10 Oct 2018 07:50:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Mhffp8AM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbeJJWLx (ORCPT + 99 others); Wed, 10 Oct 2018 18:11:53 -0400 Received: from mail-yw1-f67.google.com ([209.85.161.67]:33103 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbeJJWLw (ORCPT ); Wed, 10 Oct 2018 18:11:52 -0400 Received: by mail-yw1-f67.google.com with SMTP id m127-v6so2276053ywb.0 for ; Wed, 10 Oct 2018 07:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6vb8mTHxh+51Y3sbgq4Ms+t4t6l508BHXZnjEgq7fsA=; b=Mhffp8AMKFwdrB6iAb7AgTcdZn94XJtzeDDD6cD7SaJCfzqbkF/ErOqdlKykwXtzlG uCg4JGrT02WaPtGkR1LmMWy2k8fnZC4XkDT7cDJVOC1cmZ8MLUB0ucKLacmEzHqHh5aK e8EB8Y066H3TA35Yh73/GFg11PbVXnwTmX4TQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6vb8mTHxh+51Y3sbgq4Ms+t4t6l508BHXZnjEgq7fsA=; b=atIE5ST5SrO7dGVBYrX+lrT5pu5zNZqlM/9ScrhAXduSEEQOUo5AmwtX9Zxq2Rr1YG x8K3L/ClTsrqn8RZAgvG8Y4hdR8OkeZIoHX97nCR2u240pmBu15bIXs+eXGMu15yuQ9W oC5+jhB7JYhij1stWBOLTBCRoEWD0j1SggHqjpxSt80b2LxEJ909sLGaNosM5X7aLRwh k/ow7JWqiehpi9IkTvd21RloTTFhFUYCEHRhDmKIV8WWW0v0pfE7XWXEJUKJQ+/0BlfU r3EfjGS9K3+XgcgfOMjThc72nq9Ep56ekTtSqrRIdAWsdgv/Ugg9NhpxArluLUe/UP0Q VGWw== X-Gm-Message-State: ABuFfoib1a5UpRvMv+KPFldbXr7RILZUZowHbhI6DHsw/RrWfeOu3aE3 FM5Kt1vEKb3gsgz6aHEd2JOJvHPqZAM= X-Received: by 2002:a81:9d14:: with SMTP id u20-v6mr19548096ywg.14.1539182960657; Wed, 10 Oct 2018 07:49:20 -0700 (PDT) Received: from mail-yw1-f43.google.com (mail-yw1-f43.google.com. [209.85.161.43]) by smtp.gmail.com with ESMTPSA id j76-v6sm6614660ywj.5.2018.10.10.07.49.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Oct 2018 07:49:18 -0700 (PDT) Received: by mail-yw1-f43.google.com with SMTP id m127-v6so2275941ywb.0 for ; Wed, 10 Oct 2018 07:49:17 -0700 (PDT) X-Received: by 2002:a81:9b83:: with SMTP id s125-v6mr18708565ywg.47.1539182957146; Wed, 10 Oct 2018 07:49:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:d116:0:0:0:0:0 with HTTP; Wed, 10 Oct 2018 07:49:16 -0700 (PDT) In-Reply-To: References: <84cf6ae0-97c8-6b73-ca86-b3d3b3daba5b@pobox.com> <8d5cf8c6-556a-96a1-610d-c92355783a9f@pobox.com> <20180926180019.GD22824@google.com> <20180926184259.GB14797@kroah.com> <20180926190303.GA18293@kroah.com> From: Kees Cook Date: Wed, 10 Oct 2018 07:49:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] compiler.h: give up __compiletime_assert_fallback() To: Miguel Ojeda Cc: Joel Stanley , Nick Desaulniers , Andrew Morton , Matthias Kaehlcke , Linus Torvalds , Masahiro Yamada , Christopher Li , Sparse Mailing-list , linux-kernel , Daniel Santos , Chris Wilson , Jani Nikula , Greg KH Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 10, 2018 at 12:03 AM, Miguel Ojeda wrote: > On Wed, Oct 10, 2018 at 8:12 AM Joel Stanley wrote: >> >> On Thu, 27 Sep 2018 at 05:07, Kees Cook wrote: >> > >> > Yeah, that's what I'd linked to in the patchwork URL. Andrew, can you take this? >> >> clang built -next is blowing up now that Kees' -Wvla patch has been >> included. This patch fixes it. >> >> Kees, perhaps it should go in your tree along side of the -Wvla patch >> if no one else wants to take it? >> > > I can take it along in the compiler attributes tree, since that > touches the compiler*.h stuff. Although that would make it > not-only-attributes, i.e. slightly lying :-) Oh, I had assumed Masahiro was going to carry it. If that's not true, sure I'll pick it up as part of my VLA "series". -Kees -- Kees Cook Pixel Security