Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1187486imm; Wed, 10 Oct 2018 10:24:32 -0700 (PDT) X-Google-Smtp-Source: ACcGV63WFXPH6XrDQUmJi3Qd1Cl9o5xKh27C+OliMIG2Knu9EPH+o3wQeNn2ShZi//F6uEn22WsD X-Received: by 2002:a62:6dc3:: with SMTP id i186-v6mr25474063pfc.218.1539192272488; Wed, 10 Oct 2018 10:24:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539192272; cv=none; d=google.com; s=arc-20160816; b=oRmwJyFuKl+9TR7d71zb0OuZlxYuMrLCejqOHDkAEtiJtYN0DR8RzS4RrfjCotTp/Z fdSyrVwPSmlghWJuD8Ag/erhP8bUk+HTp5U4k7BRDYoiiGH+gVmdg7WIaOMNClxi/KEA myvydVBVB7JWgXFZaVadiAKrIY8Tqbrqm89gxJDK34vU9ZNWUpfkr4zzImrbkZj+3jzk rKMRmkx6eN8ceiJHXAsqAfeyeoSniDTRgdeigVSz5ANisCU4UaYbGHjk/75Elm1FrwPY ysvymWPKXOW0qJUaOOBNGkEFIwJGuvavTrQNNPN/hbBp4mfwpbDdwzNolW90L9BKbXil 1+yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=5WxLt8zLSbXWETsCWIaOnIPOSK0fhW8sMASp9oXsI2w=; b=m3jr3+QJb37RK4kOYpZKuzSvs+MmqdnQWA19/jo1NzaEmEcdo0Ckuu4AQvjBdY+xHa TEiLTw3MMPmP7+jI1Y7qxoxWw/uw2tHZfxGO8OYlhj8l4YbHzoikOlRDKGL6FC/PFXNj qV+rEK+bhWbhAeHjjP1rTYmg2P9viwrM9T33AuWgFYkQ43xG5f00YalsrmScV00q5rw0 zZNyi1ki6w0Gx3SClsCXl4YRKGi+sJVsKuwaTtYG+GjgJFJy3y5UMgJgB9obMRUlUzl7 ZZx99BCKqzneWHh9WhAje1cRKn5XHJqOKG7wLSnLIfqB57KXIk9VBYQq+3tLUabAbVli st9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o19-v6si25197653pgd.164.2018.10.10.10.24.17; Wed, 10 Oct 2018 10:24:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbeJKAqu (ORCPT + 99 others); Wed, 10 Oct 2018 20:46:50 -0400 Received: from shell.v3.sk ([90.176.6.54]:54589 "EHLO shell.v3.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727164AbeJKAqt (ORCPT ); Wed, 10 Oct 2018 20:46:49 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id C8EECBCFAF; Wed, 10 Oct 2018 19:23:38 +0200 (CEST) Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id FHAAkGA8-PN9; Wed, 10 Oct 2018 19:23:21 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zimbra.v3.sk (Postfix) with ESMTP id 619DEBCFB8; Wed, 10 Oct 2018 19:23:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.v3.sk Received: from shell.v3.sk ([127.0.0.1]) by localhost (zimbra.v3.sk [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3AgWpu_dna7n; Wed, 10 Oct 2018 19:23:06 +0200 (CEST) Received: from belphegor.lan (ip-89-102-31-34.net.upcbroadband.cz [89.102.31.34]) by zimbra.v3.sk (Postfix) with ESMTPSA id DA217BCFBD; Wed, 10 Oct 2018 19:23:05 +0200 (CEST) From: Lubomir Rintel To: Mark Brown , Geert Uytterhoeven , Darren Hart , Andy Shevchenko Cc: Greg Kroah-Hartman , James Cameron , Sebastian Reichel , Rob Herring , Mark Rutland , Eric Miao , Haojian Zhuang , Daniel Mack , Robert Jarzmik , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, devel@driverdev.osuosl.org, linux-pm@vger.kernel.org, Lubomir Rintel Subject: [PATCH 07/15] Platform: OLPC: Avoid a warning if the EC didn't register yet Date: Wed, 10 Oct 2018 19:22:52 +0200 Message-Id: <20181010172300.317643-8-lkundrak@v3.sk> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181010172300.317643-1-lkundrak@v3.sk> References: <20181010172300.317643-1-lkundrak@v3.sk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Just return ENODEV, so that whoever attempted to use the EC call can defer their work. Signed-off-by: Lubomir Rintel --- drivers/platform/olpc/olpc-ec.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc= -ec.c index 35a21c66cd0d..342f5bb7f7a8 100644 --- a/drivers/platform/olpc/olpc-ec.c +++ b/drivers/platform/olpc/olpc-ec.c @@ -116,8 +116,11 @@ int olpc_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 = *outbuf, size_t outlen) struct olpc_ec_priv *ec =3D ec_priv; struct ec_cmd_desc desc; =20 - /* Ensure a driver and ec hook have been registered */ - if (WARN_ON(!ec_driver || !ec_driver->ec_cmd)) + /* Driver not yet registered. */ + if (!ec_driver) + return -ENODEV; + + if (WARN_ON(!ec_driver->ec_cmd)) return -ENODEV; =20 if (!ec) --=20 2.19.0