Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1260215imm;
        Wed, 10 Oct 2018 11:36:30 -0700 (PDT)
X-Google-Smtp-Source: ACcGV60qQborrPHHbhYevDWRsz9w3wXDV/L+M8ZJ0o8hVYcvu4sB3PMhurCcsvZuYX3Wcz6v9mHl
X-Received: by 2002:a63:3642:: with SMTP id d63-v6mr30419362pga.404.1539196590549;
        Wed, 10 Oct 2018 11:36:30 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1539196590; cv=none;
        d=google.com; s=arc-20160816;
        b=hkg6tkhtG34PicDyIfhoeR4oy4NIIbcmBsNMFrCAyAbG5ZdY5QtPSkSXR3uI8XuaY1
         47gKXgo4MluO20TPTZhh0kRG28UhH07Zq+7PC8h95zUaFuAvohV6Sp6ZnOZOYVjUm9tK
         lxruuueU0SZ7FceU/MXpOiZiLmrSXku2ouGg5f9LpMLRjIaNWbL9f3grcRBoj2jcfg4j
         mqd5aBk1KpHDdiGtKVJJ0OfMRRc6UchEBtSyodkeA4Pwcy9QbeEPm9Th2mLznhz2boQ4
         6P7M7YaClXzkeDql4+tRsZNbaphjBvi0jRf/yO7DnuaUqhthmYdMYWFjWj/U+h6NxaWw
         uoGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=uuzy98t+35kgVpMWWrEVSc1gMK1AzZ+8sAv9hVmUX0I=;
        b=yz/2C4l+QpqUzb523TUlIp1gI+zo0gV4twaCzmxMQUn/RCNGCBJ7gMTyB3RD+N0TI2
         ezQMWwJofr2Jt/2IMThBVxbou1DfNwo11+aWiUAvRkkVOvKJQAb6xfndt7Qw0q71qojN
         0d/hSlIxwe0HsreoPwaaIm9jvBonXgxsRBGJLABuTk6f0r0DaCpEoADSKl0GRgtPgxdJ
         fJMCbxasuXX3kDcMu6u/vG4pP9ceK8nqe8GZAFeO2jpKnd55Y0BkI0P73vQLHuK9MPI7
         DgbNt5+bDs+0YR9i9sDKIK5D0ZD7yLcRu92hUGclJQm83Arlji1iJtEXhVS0fu9v8ywn
         Bdkw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QmGB2XeW;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 72-v6si8124630pla.334.2018.10.10.11.36.15;
        Wed, 10 Oct 2018 11:36:30 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QmGB2XeW;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726982AbeJKB7P (ORCPT <rfc822;fezhang.suse@gmail.com>
        + 99 others); Wed, 10 Oct 2018 21:59:15 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:16207 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726703AbeJKB7P (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Oct 2018 21:59:15 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5bbe46830000>; Wed, 10 Oct 2018 11:35:47 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Wed, 10 Oct 2018 11:35:52 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Wed, 10 Oct 2018 11:35:52 -0700
Received: from [10.110.48.28] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 10 Oct
 2018 18:35:51 +0000
Subject: Re: [PATCH v5 2/3] mm: introduce put_user_page*(), placeholder
 versions
To:     Jan Kara <jack@suse.cz>, <john.hubbard@gmail.com>
CC:     Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>,
        Christopher Lameter <cl@linux.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Dan Williams <dan.j.williams@intel.com>, <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
        Jerome Glisse <jglisse@redhat.com>,
        Christoph Hellwig <hch@infradead.org>,
        Ralph Campbell <rcampbell@nvidia.com>
References: <20181010041134.14096-1-jhubbard@nvidia.com>
 <20181010041134.14096-3-jhubbard@nvidia.com>
 <20181010080326.GB11507@quack2.suse.cz>
X-Nvconfidentiality: public
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <75681b69-2db6-bc46-efe3-48d029c9ec22@nvidia.com>
Date:   Wed, 10 Oct 2018 11:35:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20181010080326.GB11507@quack2.suse.cz>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1539196547; bh=uuzy98t+35kgVpMWWrEVSc1gMK1AzZ+8sAv9hVmUX0I=;
        h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=QmGB2XeWRlkVSRlElXUd/cvbzb7vLR0/0VysUHcUfB3xAEqpqYoiRQVDlC8vPzUfX
         oQ2stQHp3hUqOE/xagd5YCGrYXu8c4b8CT5aSU0A9ESfQYEZIUgb5pjf81XxOhqBSg
         c6LL/AXjY4OOczKPJy2I+D6VOgjRAyndVti7R3kSWIKNyY7bahSckvInqZzHCYAXKl
         zfXyHKwyEVlmiHaopWgI2OPlAdknxwkmHKuzH1rJrW2x3hSZsykfaqiX+GwwfulFZM
         NyCLVGo/d2J3NwmnhQwRC1DGMg7JC7qCEsgaTQb/I6Cy8y6tg+qzv37oWjS1kkwSBa
         EHt0oNWycVlew==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/10/18 1:03 AM, Jan Kara wrote:
> On Tue 09-10-18 21:11:33, john.hubbard@gmail.com wrote:
>> +/*
>> + * put_user_pages() - for each page in the @pages array, release the page
>> + * using put_user_page().
>> + *
>> + * Please see the put_user_page() documentation for details.
>> + *
>> + * This is just like put_user_pages_dirty(), except that it invokes
>> + * set_page_dirty_lock(), instead of set_page_dirty().
> 
> This paragraph should be deleted. Other than that the patch looks good.
> 

Good catch. Fixed locally, and it will go up with the next spin.

thanks,
-- 
John Hubbard
NVIDIA