Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1419613imm; Wed, 10 Oct 2018 14:23:25 -0700 (PDT) X-Google-Smtp-Source: ACcGV63xBM9llgyf/Naz33kqOqosNYbjWSyiRhyy0Z94bYdy6FvstLb7t3L948XNUxIlnGm8s4gJ X-Received: by 2002:a62:3384:: with SMTP id z126-v6mr35597790pfz.85.1539206605188; Wed, 10 Oct 2018 14:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539206605; cv=none; d=google.com; s=arc-20160816; b=MF4Hd1gVGTRAWTK2vPsNhYjueX9E3KZwCHsqTOZ9CX5qbJ2rcJ8flajbL6QJdN/FJR T4xd9zrjWrtvcDy5oXn0QTF8kQ4061aXm+7JrNsiioIYfl89U7p9++nVGw7oiw/AN9ni y5mwyZVTkSyL7jxc1ZJakvLz4erpLsmmiQHcroGhw/B54UbZlz+fNKFGztL1C4HE4y5H kzMrfF3s2PjXY7O460+MeTRkjnOqIMpWTJJbkI5N+3qLFEf4aZG97OuhWgZrCkaDUSSQ iueuV/VamIHNJqLQhO/bkaIXUYFrSe/E8rjdrDVWog4XtbO4scv/BS7mqwPv4CbKcISX +d2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CEDEPY8dcCv72rc+aveINiF2uttcSMkerfwDEBCzX5c=; b=TU2iNa94dnvak+S9J2+lMyUq7wNa9NJFpxmQwUx+2mjCUaoK/xw2a9HdXFWVwImvh1 dihD3EMfso97n3bxGN5bqJ3wcStgc0AbuNzofOqIs8yt2uWcDwLG9QE2+NMEg7rhRcRQ uclm8j+bFkBS9aQI5IxU9rTFPRaPXSy5HUqhEMljKrWZIebKpQB+rZuoTw+KlJolsmkt KArXESBZu/Kp8dIKCfiH1wWYKCL2v5KkadQR4oLQEt4VqBCEKaxMUleBhYLExvkOHi4u 0FjZYvPYrKPHJzZ+8QgFzwVMSn41DQ0Os2Dw4gO0LCSI0JwIxBFO5iqJi/qG76LonbCG mNXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EuDdUYZ5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22-v6si24827010pgl.261.2018.10.10.14.23.10; Wed, 10 Oct 2018 14:23:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EuDdUYZ5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbeJKEqT (ORCPT + 99 others); Thu, 11 Oct 2018 00:46:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:41324 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbeJKEqS (ORCPT ); Thu, 11 Oct 2018 00:46:18 -0400 Received: from localhost (unknown [104.132.1.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9833F20870; Wed, 10 Oct 2018 21:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1539206538; bh=IVjntiDaCNxdd+KJv5FnSzGNfjvXG7FwQihakmm3PPo=; h=From:To:Cc:Subject:Date:From; b=EuDdUYZ5qACCUIB3ctcvQny54oAzty6Y9Y0VPW9Dry9mPq52DnbQR3XRkezIfurPo xG2eCN7wkIfx1wlCkILcd574EH6+DWWoHtqWpa4KdtUkfCchciLRbyEV6LV0/fTXRz cDOSKeFhzMhvdbFQpJXY+MxI/CNffI2028M442fo= From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: clear cold data flag if IO is not counted Date: Wed, 10 Oct 2018 14:22:17 -0700 Message-Id: <20181010212217.52289-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we clear the cold data flag out of the writeback flow, we can miscount -1 by end_io. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 29a9d3b8f709..4102799b5558 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -2636,10 +2636,6 @@ static int f2fs_set_data_page_dirty(struct page *page) if (!PageUptodate(page)) SetPageUptodate(page); - /* don't remain PG_checked flag which was set during GC */ - if (is_cold_data(page)) - clear_cold_data(page); - if (f2fs_is_atomic_file(inode) && !f2fs_is_commit_atomic_write(inode)) { if (!IS_ATOMIC_WRITTEN_PAGE(page)) { f2fs_register_inmem_page(inode, page); -- 2.19.0.605.g01d371f741-goog