Received: by 2002:ac0:a582:0:0:0:0:0 with SMTP id m2-v6csp1623493imm; Wed, 10 Oct 2018 18:55:25 -0700 (PDT) X-Google-Smtp-Source: ACcGV62N3KtZ1U973t3J4oiy1yWwtKAQSsOu1Q+Sti4Xq6yfnF4gAgcm4Y32rk1DmHy/Rfl9gnYS X-Received: by 2002:a62:6f43:: with SMTP id k64-v6mr36000513pfc.87.1539222925082; Wed, 10 Oct 2018 18:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1539222925; cv=none; d=google.com; s=arc-20160816; b=wbBbmP4hPaiHF50qh5+g7qML1h0cYv76tzSL/ziJm7HWZfCPMJ91cG6GPdRCwEgjT9 dGDt0aasvbzcwXJmAlIzrsTrbD6c4zbJpTMDL2ui5aaG0dlLORRHSXJiK3V7RVEfLNPP 3gDYILdbbQhNJ9E1J0yR8OnfMsE4ZFd22EdbCOB10GZQb/8pd3JTy5OlbnQj36H2oDYS Dg4wp5v5Q/q6TeMIuZZkBzUp4u0xQNucRif3j/i0FsGKwU0cc80DltuQpXB6fC0VUCBH mURmfFa3cS9mSXVbegzX+nB3mCPL4GbNiCEEoi742v31EibRlnrCwHTmDqJcweujwLp2 7wbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=yfavJjfhVoCw2R4O30ZGIq3149w9ikL4D4t8TZakXIM=; b=SZ+LO49JCWQ8ksVNYjt2Q7vlCyYCXdQ9LkNNsEQ09MwxqmV0rd0V8ZT4UQbwFDbTd4 x94n0Ge12q+XflKXZ0QuT+B+4AwpQARw4QTy/sSXTst3YBcF0HyTo282/hqAbY4QNAtd p9WNo8wT39JthPTlsVKhYZPBF+uoIS/VIIvLS9oRjwTwMDHUravQ2RPKCkrgyKi7zx6r 6Baun71Bh03idYdCXJ62oHDAPJpAyUly85xmD6KGYAOizE5IgSFzbDqleJsRX/llpdfs cTnLc2wsHSalzRVV3Qxjzu8czMR+TOv8xnI/3w4mrFtVdeeQoM9TR5nXwKOS3XhQz5Bh zPfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=t7KszScS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t90-v6si27614595pfi.221.2018.10.10.18.55.09; Wed, 10 Oct 2018 18:55:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=t7KszScS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbeJKJTm (ORCPT + 99 others); Thu, 11 Oct 2018 05:19:42 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:54722 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725989AbeJKJTm (ORCPT ); Thu, 11 Oct 2018 05:19:42 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9B1sWEB032080; Thu, 11 Oct 2018 01:54:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=yfavJjfhVoCw2R4O30ZGIq3149w9ikL4D4t8TZakXIM=; b=t7KszScStU+kjVAkCBzrFdhG11p2vYLFmh5/aeJ6HUsuPTtRtruKtp61HkXDg/kX4XrU DpyHFq4bWQNNinZ3o3HzgsSAHgJ869dq7feoxIWgFtpBK71RfPTEsbm6zThiyPBtspbV mpoGm6L02xWiaYK+JYkjGpwFffb1JLAO7xjBKW/SvZCvNHDR2GXBmBlo+EZguSAHEcC6 lO6kZTz9vT75RDc45dAycMZ81T7tEEpFEdtu80fO7EKysUEP4jmSM37CIvYlOrZ2IrM5 JhLX2C2q01TEYT5oIUi7rf89D7NqJInv/eMlhw8ko1LHYW/W9M4Yfwa/CEoke7N/Z118 Ug== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2mxn0q7hbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Oct 2018 01:54:41 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w9B1sZou031908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 11 Oct 2018 01:54:35 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w9B1sY7W004451; Thu, 11 Oct 2018 01:54:34 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Oct 2018 01:54:34 +0000 To: Joe Perches Cc: MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, Sathya Prakash , Chaitra P B , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] Neaten logging uses From: "Martin K. Petersen" Organization: Oracle Corporation References: Date: Wed, 10 Oct 2018 21:54:25 -0400 In-Reply-To: (Joe Perches's message of "Mon, 17 Sep 2018 08:01:07 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9042 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=663 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810110017 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe, > Several defects exist in the logging uses > > o Missing KERN_ > o Unnecessary KERN_ uses with panic > o Mismatched MPT3SAS_FMT and %s: with name and __func__ > > Correct these defects and perhaps add some clarity to the logging. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering